[1/195] 4421 warnings generated. [2/195] 10656 warnings generated. [3/195] /home/runner/work/graphia/graphia/source/shared/graph/elementid.h:35:5: warning: single-argument constructors must be marked explicit to avoid unintentional implicit conversions [google-explicit-constructor] 35 | ElementId(int value = NullValue) : | ^ | explicit 11147 warnings generated. [4/195] 17448 warnings generated. [5/195] /home/runner/work/graphia/graphia/source/shared/graph/elementid.h:35:5: warning: single-argument constructors must be marked explicit to avoid unintentional implicit conversions [google-explicit-constructor] 35 | ElementId(int value = NullValue) : | ^ | explicit 11058 warnings generated. [6/195] /home/runner/work/graphia/graphia/source/shared/graph/elementid.h:35:5: warning: single-argument constructors must be marked explicit to avoid unintentional implicit conversions [google-explicit-constructor] 35 | ElementId(int value = NullValue) : | ^ | explicit /home/runner/work/graphia/graphia/source/shared/graph/grapharray.h:92:9: warning: initializer for member '_mutex' is redundant [readability-redundant-member-init] 92 | _mutex(), | ^~~~~~~~ /home/runner/work/graphia/graphia/source/shared/loading/userelementdata.h:114:16: warning: redundant get() call on smart pointer [readability-redundant-smartptr-get] 114 | return _indexes->get(elementId)._set; // readability-redundant-smartptr-get | ^~~~~~~~~~~~~~~~~~~~~~~ | _indexes /home/runner/work/graphia/graphia/source/shared/loading/userelementdata.h:119:16: warning: redundant get() call on smart pointer [readability-redundant-smartptr-get] 119 | return _indexes->get(elementId)._value; // readability-redundant-smartptr-get | ^~~~~~~~~~~~~~~~~~~~~~~ | _indexes /home/runner/work/graphia/graphia/source/shared/loading/userelementdata.h:345:9: warning: variable 'jsonAttributes' of type 'json' (aka 'basic_json<>') can be declared 'const' [misc-const-correctness] 345 | json jsonAttributes = json::object(); // misc-const-correctness | ^ | const /home/runner/work/graphia/graphia/source/shared/utils/is_detected.h:24:1: warning: nested namespaces can be concatenated [modernize-concat-nested-namespaces] 24 | namespace std{ | ^~~~~~~~~~~~~~ 25 | namespace experimental{ | ~~~~~~~~~~~~~~~~~~~~~~ | namespace std::experimental /home/runner/work/graphia/graphia/source/shared/utils/is_detected.h:25:11: warning: modification of 'std' namespace can result in undefined behavior [cert-dcl58-cpp] 25 | namespace experimental{ | ^ /home/runner/work/graphia/graphia/source/shared/utils/is_detected.h:24:11: note: 'std' namespace opened here 24 | namespace std{ | ^ 18891 warnings generated. [7/195] /home/runner/work/graphia/graphia/source/shared/graph/elementid.h:35:5: warning: single-argument constructors must be marked explicit to avoid unintentional implicit conversions [google-explicit-constructor] 35 | ElementId(int value = NullValue) : | ^ | explicit /home/runner/work/graphia/graphia/source/shared/loading/dotfileparser.cpp:415:5: warning: variable 'istreamIt' of type 'boost::spirit::istream_iterator' (aka 'basic_istream_iterator') can be declared 'const' [misc-const-correctness] 415 | boost::spirit::istream_iterator istreamIt(stream); // misc-const-correctness | ^ | const 26177 warnings generated. [8/195] /home/runner/work/graphia/graphia/source/shared/graph/elementid.h:35:5: warning: single-argument constructors must be marked explicit to avoid unintentional implicit conversions [google-explicit-constructor] 35 | ElementId(int value = NullValue) : | ^ | explicit /home/runner/work/graphia/graphia/source/shared/loading/gmlfileparser.cpp:320:5: warning: variable 'istreamIt' of type 'boost::spirit::istream_iterator' (aka 'basic_istream_iterator') can be declared 'const' [misc-const-correctness] 320 | boost::spirit::istream_iterator istreamIt(stream); // misc-const-correctness | ^ | const 26127 warnings generated. [9/195] /home/runner/work/graphia/graphia/source/shared/graph/elementid.h:35:5: warning: single-argument constructors must be marked explicit to avoid unintentional implicit conversions [google-explicit-constructor] 35 | ElementId(int value = NullValue) : | ^ | explicit 11127 warnings generated. [10/195] /home/runner/work/graphia/graphia/source/shared/graph/elementid.h:35:5: warning: single-argument constructors must be marked explicit to avoid unintentional implicit conversions [google-explicit-constructor] 35 | ElementId(int value = NullValue) : | ^ | explicit 10277 warnings generated. [11/195] 16432 warnings generated. [12/195] 17258 warnings generated. [13/195] /home/runner/work/graphia/graphia/source/shared/graph/elementid.h:35:5: warning: single-argument constructors must be marked explicit to avoid unintentional implicit conversions [google-explicit-constructor] 35 | ElementId(int value = NullValue) : | ^ | explicit /home/runner/work/graphia/graphia/source/shared/utils/scope_exit.h:27:1: warning: nested namespaces can be concatenated [modernize-concat-nested-namespaces] 27 | namespace std{ | ^~~~~~~~~~~~~~ 28 | namespace experimental{ | ~~~~~~~~~~~~~~~~~~~~~~ | namespace std::experimental /home/runner/work/graphia/graphia/source/shared/utils/scope_exit.h:28:11: warning: modification of 'std' namespace can result in undefined behavior [cert-dcl58-cpp] 28 | namespace experimental{ | ^ /home/runner/work/graphia/graphia/source/shared/utils/scope_exit.h:27:11: note: 'std' namespace opened here 27 | namespace std{ | ^ 12886 warnings generated. [14/195] /home/runner/work/graphia/graphia/source/shared/graph/elementid.h:35:5: warning: single-argument constructors must be marked explicit to avoid unintentional implicit conversions [google-explicit-constructor] 35 | ElementId(int value = NullValue) : | ^ | explicit 10943 warnings generated. [15/195] /home/runner/work/graphia/graphia/source/shared/graph/elementid.h:35:5: warning: single-argument constructors must be marked explicit to avoid unintentional implicit conversions [google-explicit-constructor] 35 | ElementId(int value = NullValue) : | ^ | explicit 11292 warnings generated. [16/195] /home/runner/work/graphia/graphia/source/shared/graph/elementid.h:35:5: warning: single-argument constructors must be marked explicit to avoid unintentional implicit conversions [google-explicit-constructor] 35 | ElementId(int value = NullValue) : | ^ | explicit 11060 warnings generated. [17/195] 10192 warnings generated. [18/195] 17198 warnings generated. [19/195] 17155 warnings generated. [20/195] /home/runner/work/graphia/graphia/source/shared/commands/command.h:46:5: warning: single-argument constructors must be marked explicit to avoid unintentional implicit conversions [google-explicit-constructor] 46 | CommandFn(Fn&& fn) : | ^ | explicit /home/runner/work/graphia/graphia/source/shared/commands/command.h:46:20: warning: forwarding reference parameter 'fn' is never forwarded inside the function body [cppcoreguidelines-missing-std-forward] 46 | CommandFn(Fn&& fn) : | ^ /home/runner/work/graphia/graphia/source/shared/commands/command.h:51:5: warning: single-argument constructors must be marked explicit to avoid unintentional implicit conversions [google-explicit-constructor] 51 | CommandFn(Fn&& fn) : | ^ | explicit /home/runner/work/graphia/graphia/source/shared/commands/command.h:51:20: warning: forwarding reference parameter 'fn' is never forwarded inside the function body [cppcoreguidelines-missing-std-forward] 51 | CommandFn(Fn&& fn) : | ^ /home/runner/work/graphia/graphia/source/shared/commands/command.h:85:9: warning: constructors that are callable with a single argument must be marked explicit to avoid unintentional implicit conversions [google-explicit-constructor] 85 | CommandDescription(const QString& description = {}, | ^ | explicit /home/runner/work/graphia/graphia/source/shared/graph/elementid.h:35:5: warning: single-argument constructors must be marked explicit to avoid unintentional implicit conversions [google-explicit-constructor] 35 | ElementId(int value = NullValue) : | ^ | explicit /home/runner/work/graphia/graphia/source/shared/plugins/iplugin.h:101:9: warning: function-like macro 'IPluginIID' used; consider a 'constexpr' template function [cppcoreguidelines-macro-usage] 101 | #define IPluginIID(NAME) "app.graphia.IPlugin:" #NAME "/" VERSION // cppcoreguidelines-macro-usage | ^ /home/runner/work/graphia/graphia/source/shared/utils/flags.h:33:5: warning: single-argument constructors must be marked explicit to avoid unintentional implicit conversions [google-explicit-constructor] 33 | Flags(Enum value) : | ^ | explicit /home/runner/work/graphia/graphia/source/shared/utils/flags.h:38:5: warning: constructors that are callable with a single argument must be marked explicit to avoid unintentional implicit conversions [google-explicit-constructor] 38 | Flags(Enum value, Tail... values) | ^ | explicit 10975 warnings generated. [21/195] /home/runner/work/graphia/graphia/source/shared/commands/command.h:46:5: warning: single-argument constructors must be marked explicit to avoid unintentional implicit conversions [google-explicit-constructor] 46 | CommandFn(Fn&& fn) : | ^ | explicit /home/runner/work/graphia/graphia/source/shared/commands/command.h:46:20: warning: forwarding reference parameter 'fn' is never forwarded inside the function body [cppcoreguidelines-missing-std-forward] 46 | CommandFn(Fn&& fn) : | ^ /home/runner/work/graphia/graphia/source/shared/commands/command.h:51:5: warning: single-argument constructors must be marked explicit to avoid unintentional implicit conversions [google-explicit-constructor] 51 | CommandFn(Fn&& fn) : | ^ | explicit /home/runner/work/graphia/graphia/source/shared/commands/command.h:51:20: warning: forwarding reference parameter 'fn' is never forwarded inside the function body [cppcoreguidelines-missing-std-forward] 51 | CommandFn(Fn&& fn) : | ^ /home/runner/work/graphia/graphia/source/shared/commands/command.h:85:9: warning: constructors that are callable with a single argument must be marked explicit to avoid unintentional implicit conversions [google-explicit-constructor] 85 | CommandDescription(const QString& description = {}, | ^ | explicit /home/runner/work/graphia/graphia/source/shared/graph/elementid.h:35:5: warning: single-argument constructors must be marked explicit to avoid unintentional implicit conversions [google-explicit-constructor] 35 | ElementId(int value = NullValue) : | ^ | explicit /home/runner/work/graphia/graphia/source/shared/graph/grapharray.h:92:9: warning: initializer for member '_mutex' is redundant [readability-redundant-member-init] 92 | _mutex(), | ^~~~~~~~ /home/runner/work/graphia/graphia/source/shared/loading/userelementdata.h:114:16: warning: redundant get() call on smart pointer [readability-redundant-smartptr-get] 114 | return _indexes->get(elementId)._set; // readability-redundant-smartptr-get | ^~~~~~~~~~~~~~~~~~~~~~~ | _indexes /home/runner/work/graphia/graphia/source/shared/loading/userelementdata.h:119:16: warning: redundant get() call on smart pointer [readability-redundant-smartptr-get] 119 | return _indexes->get(elementId)._value; // readability-redundant-smartptr-get | ^~~~~~~~~~~~~~~~~~~~~~~ | _indexes /home/runner/work/graphia/graphia/source/shared/loading/userelementdata.h:345:9: warning: variable 'jsonAttributes' of type 'json' (aka 'basic_json<>') can be declared 'const' [misc-const-correctness] 345 | json jsonAttributes = json::object(); // misc-const-correctness | ^ | const /home/runner/work/graphia/graphia/source/shared/plugins/iplugin.h:101:9: warning: function-like macro 'IPluginIID' used; consider a 'constexpr' template function [cppcoreguidelines-macro-usage] 101 | #define IPluginIID(NAME) "app.graphia.IPlugin:" #NAME "/" VERSION // cppcoreguidelines-macro-usage | ^ /home/runner/work/graphia/graphia/source/shared/utils/flags.h:33:5: warning: single-argument constructors must be marked explicit to avoid unintentional implicit conversions [google-explicit-constructor] 33 | Flags(Enum value) : | ^ | explicit /home/runner/work/graphia/graphia/source/shared/utils/flags.h:38:5: warning: constructors that are callable with a single argument must be marked explicit to avoid unintentional implicit conversions [google-explicit-constructor] 38 | Flags(Enum value, Tail... values) | ^ | explicit /home/runner/work/graphia/graphia/source/shared/utils/is_detected.h:24:1: warning: nested namespaces can be concatenated [modernize-concat-nested-namespaces] 24 | namespace std{ | ^~~~~~~~~~~~~~ 25 | namespace experimental{ | ~~~~~~~~~~~~~~~~~~~~~~ | namespace std::experimental /home/runner/work/graphia/graphia/source/shared/utils/is_detected.h:25:11: warning: modification of 'std' namespace can result in undefined behavior [cert-dcl58-cpp] 25 | namespace experimental{ | ^ /home/runner/work/graphia/graphia/source/shared/utils/is_detected.h:24:11: note: 'std' namespace opened here 24 | namespace std{ | ^ 20109 warnings generated. [22/195] /home/runner/work/graphia/graphia/source/shared/commands/command.h:46:5: warning: single-argument constructors must be marked explicit to avoid unintentional implicit conversions [google-explicit-constructor] 46 | CommandFn(Fn&& fn) : | ^ | explicit /home/runner/work/graphia/graphia/source/shared/commands/command.h:46:20: warning: forwarding reference parameter 'fn' is never forwarded inside the function body [cppcoreguidelines-missing-std-forward] 46 | CommandFn(Fn&& fn) : | ^ /home/runner/work/graphia/graphia/source/shared/commands/command.h:51:5: warning: single-argument constructors must be marked explicit to avoid unintentional implicit conversions [google-explicit-constructor] 51 | CommandFn(Fn&& fn) : | ^ | explicit /home/runner/work/graphia/graphia/source/shared/commands/command.h:51:20: warning: forwarding reference parameter 'fn' is never forwarded inside the function body [cppcoreguidelines-missing-std-forward] 51 | CommandFn(Fn&& fn) : | ^ /home/runner/work/graphia/graphia/source/shared/commands/command.h:85:9: warning: constructors that are callable with a single argument must be marked explicit to avoid unintentional implicit conversions [google-explicit-constructor] 85 | CommandDescription(const QString& description = {}, | ^ | explicit /home/runner/work/graphia/graphia/source/shared/graph/elementid.h:35:5: warning: single-argument constructors must be marked explicit to avoid unintentional implicit conversions [google-explicit-constructor] 35 | ElementId(int value = NullValue) : | ^ | explicit /home/runner/work/graphia/graphia/source/shared/utils/flags.h:33:5: warning: single-argument constructors must be marked explicit to avoid unintentional implicit conversions [google-explicit-constructor] 33 | Flags(Enum value) : | ^ | explicit /home/runner/work/graphia/graphia/source/shared/utils/flags.h:38:5: warning: constructors that are callable with a single argument must be marked explicit to avoid unintentional implicit conversions [google-explicit-constructor] 38 | Flags(Enum value, Tail... values) | ^ | explicit 11276 warnings generated. [23/195] /home/runner/work/graphia/graphia/source/shared/graph/elementid.h:35:5: warning: single-argument constructors must be marked explicit to avoid unintentional implicit conversions [google-explicit-constructor] 35 | ElementId(int value = NullValue) : | ^ | explicit /home/runner/work/graphia/graphia/source/shared/utils/flags.h:33:5: warning: single-argument constructors must be marked explicit to avoid unintentional implicit conversions [google-explicit-constructor] 33 | Flags(Enum value) : | ^ | explicit /home/runner/work/graphia/graphia/source/shared/utils/flags.h:38:5: warning: constructors that are callable with a single argument must be marked explicit to avoid unintentional implicit conversions [google-explicit-constructor] 38 | Flags(Enum value, Tail... values) | ^ | explicit 12206 warnings generated. [24/195] 18825 warnings generated. [25/195] 12078 warnings generated. [26/195] 12113 warnings generated. [27/195] 16609 warnings generated. [28/195] 16705 warnings generated. [29/195] 10102 warnings generated. [30/195] 7259 warnings generated. [31/195] 4369 warnings generated. [32/195] 10168 warnings generated. [33/195] /home/runner/work/graphia/graphia/source/shared/utils/crypto.cpp:50:12: warning: avoid repeating the return type from the declaration; use a braced initializer list instead [modernize-return-braced-init-list] 50 | return std::string(reinterpret_cast(outBytes.data()), outBytes.size()); | ^ /home/runner/work/graphia/graphia/source/shared/utils/crypto.cpp:61:12: warning: avoid repeating the return type from the declaration; use a braced initializer list instead [modernize-return-braced-init-list] 61 | return std::string(reinterpret_cast(outBytes.data()), outBytes.size()); | ^ /home/runner/work/graphia/graphia/source/shared/utils/crypto.cpp:66:5: warning: 'auto inBytes' can be declared as 'const auto *inBytes' [readability-qualified-auto] 66 | auto inBytes = reinterpret_cast(string.data()); | ^~~~ | const auto * /home/runner/work/graphia/graphia/source/thirdparty/cryptopp/filters.h:1264:4: warning: Call to virtual method 'StringStore::StoreInitialize' during construction bypasses virtual dispatch [clang-analyzer-optin.cplusplus.VirtualCall] 1264 | {StoreInitialize(MakeParameters("InputBuffer", ConstByteArrayParameter(string)));} | ^ /home/runner/work/graphia/graphia/source/shared/utils/crypto.cpp:182:22: note: Calling 'loadKey' 182 | auto publicKey = loadKey(publicKeyFileName); | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ /home/runner/work/graphia/graphia/source/shared/utils/crypto.cpp:102:8: note: Assuming the condition is false 102 | if(!file.open(QIODevice::ReadOnly)) | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ /home/runner/work/graphia/graphia/source/shared/utils/crypto.cpp:102:5: note: Taking false branch 102 | if(!file.open(QIODevice::ReadOnly)) | ^ /home/runner/work/graphia/graphia/source/shared/utils/crypto.cpp:110:27: note: Calling constructor for 'StringSource' 110 | CryptoPP::ArraySource arraySource(reinterpret_cast(byteArray.constData()), | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ 111 | static_cast(byteArray.size()), true); | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ /home/runner/work/graphia/graphia/source/thirdparty/cryptopp/filters.h:1479:5: note: Calling constructor for 'SourceTemplate' 1479 | : SourceTemplate(attachment) {SourceInitialize(pumpAll, MakeParameters("InputBuffer", ConstByteArrayParameter(string, length)));} | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ /home/runner/work/graphia/graphia/source/thirdparty/cryptopp/filters.h:1435:2: note: Calling default constructor for 'StringStore' 1435 | SourceTemplate(BufferedTransformation *attachment) | ^~~~~~~~~~~~~~ /home/runner/work/graphia/graphia/source/thirdparty/cryptopp/filters.h:1264:4: note: Call to virtual method 'StringStore::StoreInitialize' during construction bypasses virtual dispatch 1264 | {StoreInitialize(MakeParameters("InputBuffer", ConstByteArrayParameter(string)));} | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ 12821 warnings generated. [34/195] 10867 warnings generated. [35/195] 11011 warnings generated. [36/195] 6916 warnings generated. [37/195] 10375 warnings generated. [38/195] 10804 warnings generated. [39/195] 5811 warnings generated. [40/195] 11320 warnings generated. [41/195] 7650 warnings generated. [42/195] 9875 warnings generated. [43/195] 10121 warnings generated. [44/195] 9828 warnings generated. [45/195] 3154 warnings generated. [46/195] 9990 warnings generated. [47/195] /home/runner/work/graphia/graphia/source/shared/utils/is_detected.h:24:1: warning: nested namespaces can be concatenated [modernize-concat-nested-namespaces] 24 | namespace std{ | ^~~~~~~~~~~~~~ 25 | namespace experimental{ | ~~~~~~~~~~~~~~~~~~~~~~ | namespace std::experimental /home/runner/work/graphia/graphia/source/shared/utils/is_detected.h:25:11: warning: modification of 'std' namespace can result in undefined behavior [cert-dcl58-cpp] 25 | namespace experimental{ | ^ /home/runner/work/graphia/graphia/source/shared/utils/is_detected.h:24:11: note: 'std' namespace opened here 24 | namespace std{ | ^ /home/runner/work/graphia/graphia/source/shared/utils/threadpool.h:66:109: warning: forwarding reference parameter 'args' is never forwarded inside the function body [cppcoreguidelines-missing-std-forward] 66 | template std::future> makeFuture(Fn f, Args&&... args) | ^ 10684 warnings generated. [48/195] 10656 warnings generated. [49/195] 7203 warnings generated. [50/195] 22026 warnings generated. [51/195] 19057 warnings generated. 38114 warnings generated. [52/195] 10706 warnings generated. [53/195] /home/runner/work/graphia/graphia/source/shared/utils/doasyncthen.h:42:28: warning: forwarding reference parameter 'thenFn' is never forwarded inside the function body [cppcoreguidelines-missing-std-forward] 42 | void then(ThenFn&& thenFn) | ^ /home/runner/work/graphia/graphia/source/shared/utils/scope_exit.h:27:1: warning: nested namespaces can be concatenated [modernize-concat-nested-namespaces] 27 | namespace std{ | ^~~~~~~~~~~~~~ 28 | namespace experimental{ | ~~~~~~~~~~~~~~~~~~~~~~ | namespace std::experimental /home/runner/work/graphia/graphia/source/shared/utils/scope_exit.h:28:11: warning: modification of 'std' namespace can result in undefined behavior [cert-dcl58-cpp] 28 | namespace experimental{ | ^ /home/runner/work/graphia/graphia/source/shared/utils/scope_exit.h:27:11: note: 'std' namespace opened here 27 | namespace std{ | ^ 17635 warnings generated. [54/195] 18417 warnings generated. [55/195] /home/runner/work/graphia/graphia/source/shared/graph/elementid.h:35:5: warning: single-argument constructors must be marked explicit to avoid unintentional implicit conversions [google-explicit-constructor] 35 | ElementId(int value = NullValue) : | ^ | explicit 18526 warnings generated. [56/195] 9870 warnings generated. [57/195] /home/runner/work/graphia/graphia/source/shared/graph/elementid.h:35:5: warning: single-argument constructors must be marked explicit to avoid unintentional implicit conversions [google-explicit-constructor] 35 | ElementId(int value = NullValue) : | ^ | explicit /home/runner/work/graphia/graphia/source/shared/utils/is_detected.h:24:1: warning: nested namespaces can be concatenated [modernize-concat-nested-namespaces] 24 | namespace std{ | ^~~~~~~~~~~~~~ 25 | namespace experimental{ | ~~~~~~~~~~~~~~~~~~~~~~ | namespace std::experimental /home/runner/work/graphia/graphia/source/shared/utils/is_detected.h:25:11: warning: modification of 'std' namespace can result in undefined behavior [cert-dcl58-cpp] 25 | namespace experimental{ | ^ /home/runner/work/graphia/graphia/source/shared/utils/is_detected.h:24:11: note: 'std' namespace opened here 24 | namespace std{ | ^ /home/runner/work/graphia/graphia/source/shared/utils/threadpool.h:66:109: warning: forwarding reference parameter 'args' is never forwarded inside the function body [cppcoreguidelines-missing-std-forward] 66 | template std::future> makeFuture(Fn f, Args&&... args) | ^ 14323 warnings generated. [58/195] /home/runner/work/graphia/graphia/source/shared/graph/elementid.h:35:5: warning: single-argument constructors must be marked explicit to avoid unintentional implicit conversions [google-explicit-constructor] 35 | ElementId(int value = NullValue) : | ^ | explicit 7358 warnings generated. [59/195] /home/runner/work/graphia/graphia/source/shared/graph/elementid.h:35:5: warning: single-argument constructors must be marked explicit to avoid unintentional implicit conversions [google-explicit-constructor] 35 | ElementId(int value = NullValue) : | ^ | explicit /home/runner/work/graphia/graphia/source/shared/utils/flags.h:33:5: warning: single-argument constructors must be marked explicit to avoid unintentional implicit conversions [google-explicit-constructor] 33 | Flags(Enum value) : | ^ | explicit /home/runner/work/graphia/graphia/source/shared/utils/flags.h:38:5: warning: constructors that are callable with a single argument must be marked explicit to avoid unintentional implicit conversions [google-explicit-constructor] 38 | Flags(Enum value, Tail... values) | ^ | explicit 10259 warnings generated. [60/195] /home/runner/work/graphia/graphia/source/shared/commands/command.h:46:5: warning: single-argument constructors must be marked explicit to avoid unintentional implicit conversions [google-explicit-constructor] 46 | CommandFn(Fn&& fn) : | ^ | explicit /home/runner/work/graphia/graphia/source/shared/commands/command.h:46:20: warning: forwarding reference parameter 'fn' is never forwarded inside the function body [cppcoreguidelines-missing-std-forward] 46 | CommandFn(Fn&& fn) : | ^ /home/runner/work/graphia/graphia/source/shared/commands/command.h:51:5: warning: single-argument constructors must be marked explicit to avoid unintentional implicit conversions [google-explicit-constructor] 51 | CommandFn(Fn&& fn) : | ^ | explicit /home/runner/work/graphia/graphia/source/shared/commands/command.h:51:20: warning: forwarding reference parameter 'fn' is never forwarded inside the function body [cppcoreguidelines-missing-std-forward] 51 | CommandFn(Fn&& fn) : | ^ /home/runner/work/graphia/graphia/source/shared/commands/command.h:85:9: warning: constructors that are callable with a single argument must be marked explicit to avoid unintentional implicit conversions [google-explicit-constructor] 85 | CommandDescription(const QString& description = {}, | ^ | explicit /home/runner/work/graphia/graphia/source/shared/graph/elementid.h:35:5: warning: single-argument constructors must be marked explicit to avoid unintentional implicit conversions [google-explicit-constructor] 35 | ElementId(int value = NullValue) : | ^ | explicit /home/runner/work/graphia/graphia/source/shared/graph/grapharray.h:92:9: warning: initializer for member '_mutex' is redundant [readability-redundant-member-init] 92 | _mutex(), | ^~~~~~~~ /home/runner/work/graphia/graphia/source/shared/loading/userelementdata.h:114:16: warning: redundant get() call on smart pointer [readability-redundant-smartptr-get] 114 | return _indexes->get(elementId)._set; // readability-redundant-smartptr-get | ^~~~~~~~~~~~~~~~~~~~~~~ | _indexes /home/runner/work/graphia/graphia/source/shared/loading/userelementdata.h:119:16: warning: redundant get() call on smart pointer [readability-redundant-smartptr-get] 119 | return _indexes->get(elementId)._value; // readability-redundant-smartptr-get | ^~~~~~~~~~~~~~~~~~~~~~~ | _indexes /home/runner/work/graphia/graphia/source/shared/loading/userelementdata.h:345:9: warning: variable 'jsonAttributes' of type 'json' (aka 'basic_json<>') can be declared 'const' [misc-const-correctness] 345 | json jsonAttributes = json::object(); // misc-const-correctness | ^ | const /home/runner/work/graphia/graphia/source/shared/plugins/iplugin.h:101:9: warning: function-like macro 'IPluginIID' used; consider a 'constexpr' template function [cppcoreguidelines-macro-usage] 101 | #define IPluginIID(NAME) "app.graphia.IPlugin:" #NAME "/" VERSION // cppcoreguidelines-macro-usage | ^ /home/runner/work/graphia/graphia/source/shared/utils/flags.h:33:5: warning: single-argument constructors must be marked explicit to avoid unintentional implicit conversions [google-explicit-constructor] 33 | Flags(Enum value) : | ^ | explicit /home/runner/work/graphia/graphia/source/shared/utils/flags.h:38:5: warning: constructors that are callable with a single argument must be marked explicit to avoid unintentional implicit conversions [google-explicit-constructor] 38 | Flags(Enum value, Tail... values) | ^ | explicit /home/runner/work/graphia/graphia/source/shared/utils/scope_exit.h:27:1: warning: nested namespaces can be concatenated [modernize-concat-nested-namespaces] 27 | namespace std{ | ^~~~~~~~~~~~~~ 28 | namespace experimental{ | ~~~~~~~~~~~~~~~~~~~~~~ | namespace std::experimental /home/runner/work/graphia/graphia/source/shared/utils/scope_exit.h:28:11: warning: modification of 'std' namespace can result in undefined behavior [cert-dcl58-cpp] 28 | namespace experimental{ | ^ /home/runner/work/graphia/graphia/source/shared/utils/scope_exit.h:27:11: note: 'std' namespace opened here 27 | namespace std{ | ^ 37301 warnings generated. [61/195] /home/runner/work/graphia/graphia/source/shared/commands/command.h:46:5: warning: single-argument constructors must be marked explicit to avoid unintentional implicit conversions [google-explicit-constructor] 46 | CommandFn(Fn&& fn) : | ^ | explicit /home/runner/work/graphia/graphia/source/shared/commands/command.h:46:20: warning: forwarding reference parameter 'fn' is never forwarded inside the function body [cppcoreguidelines-missing-std-forward] 46 | CommandFn(Fn&& fn) : | ^ /home/runner/work/graphia/graphia/source/shared/commands/command.h:51:5: warning: single-argument constructors must be marked explicit to avoid unintentional implicit conversions [google-explicit-constructor] 51 | CommandFn(Fn&& fn) : | ^ | explicit /home/runner/work/graphia/graphia/source/shared/commands/command.h:51:20: warning: forwarding reference parameter 'fn' is never forwarded inside the function body [cppcoreguidelines-missing-std-forward] 51 | CommandFn(Fn&& fn) : | ^ /home/runner/work/graphia/graphia/source/shared/commands/command.h:85:9: warning: constructors that are callable with a single argument must be marked explicit to avoid unintentional implicit conversions [google-explicit-constructor] 85 | CommandDescription(const QString& description = {}, | ^ | explicit /home/runner/work/graphia/graphia/source/shared/graph/elementid.h:35:5: warning: single-argument constructors must be marked explicit to avoid unintentional implicit conversions [google-explicit-constructor] 35 | ElementId(int value = NullValue) : | ^ | explicit /home/runner/work/graphia/graphia/source/shared/graph/grapharray.h:92:9: warning: initializer for member '_mutex' is redundant [readability-redundant-member-init] 92 | _mutex(), | ^~~~~~~~ /home/runner/work/graphia/graphia/source/shared/loading/userelementdata.h:114:16: warning: redundant get() call on smart pointer [readability-redundant-smartptr-get] 114 | return _indexes->get(elementId)._set; // readability-redundant-smartptr-get | ^~~~~~~~~~~~~~~~~~~~~~~ | _indexes /home/runner/work/graphia/graphia/source/shared/loading/userelementdata.h:119:16: warning: redundant get() call on smart pointer [readability-redundant-smartptr-get] 119 | return _indexes->get(elementId)._value; // readability-redundant-smartptr-get | ^~~~~~~~~~~~~~~~~~~~~~~ | _indexes /home/runner/work/graphia/graphia/source/shared/loading/userelementdata.h:345:9: warning: variable 'jsonAttributes' of type 'json' (aka 'basic_json<>') can be declared 'const' [misc-const-correctness] 345 | json jsonAttributes = json::object(); // misc-const-correctness | ^ | const /home/runner/work/graphia/graphia/source/shared/plugins/iplugin.h:101:9: warning: function-like macro 'IPluginIID' used; consider a 'constexpr' template function [cppcoreguidelines-macro-usage] 101 | #define IPluginIID(NAME) "app.graphia.IPlugin:" #NAME "/" VERSION // cppcoreguidelines-macro-usage | ^ /home/runner/work/graphia/graphia/source/shared/utils/flags.h:33:5: warning: single-argument constructors must be marked explicit to avoid unintentional implicit conversions [google-explicit-constructor] 33 | Flags(Enum value) : | ^ | explicit /home/runner/work/graphia/graphia/source/shared/utils/flags.h:38:5: warning: constructors that are callable with a single argument must be marked explicit to avoid unintentional implicit conversions [google-explicit-constructor] 38 | Flags(Enum value, Tail... values) | ^ | explicit 36570 warnings generated. [62/195] /home/runner/work/graphia/graphia/source/shared/commands/command.h:46:5: warning: single-argument constructors must be marked explicit to avoid unintentional implicit conversions [google-explicit-constructor] 46 | CommandFn(Fn&& fn) : | ^ | explicit /home/runner/work/graphia/graphia/source/shared/commands/command.h:46:20: warning: forwarding reference parameter 'fn' is never forwarded inside the function body [cppcoreguidelines-missing-std-forward] 46 | CommandFn(Fn&& fn) : | ^ /home/runner/work/graphia/graphia/source/shared/commands/command.h:51:5: warning: single-argument constructors must be marked explicit to avoid unintentional implicit conversions [google-explicit-constructor] 51 | CommandFn(Fn&& fn) : | ^ | explicit /home/runner/work/graphia/graphia/source/shared/commands/command.h:51:20: warning: forwarding reference parameter 'fn' is never forwarded inside the function body [cppcoreguidelines-missing-std-forward] 51 | CommandFn(Fn&& fn) : | ^ /home/runner/work/graphia/graphia/source/shared/commands/command.h:85:9: warning: constructors that are callable with a single argument must be marked explicit to avoid unintentional implicit conversions [google-explicit-constructor] 85 | CommandDescription(const QString& description = {}, | ^ | explicit /home/runner/work/graphia/graphia/source/shared/graph/elementid.h:35:5: warning: single-argument constructors must be marked explicit to avoid unintentional implicit conversions [google-explicit-constructor] 35 | ElementId(int value = NullValue) : | ^ | explicit /home/runner/work/graphia/graphia/source/shared/graph/grapharray.h:92:9: warning: initializer for member '_mutex' is redundant [readability-redundant-member-init] 92 | _mutex(), | ^~~~~~~~ /home/runner/work/graphia/graphia/source/shared/loading/userelementdata.h:114:16: warning: redundant get() call on smart pointer [readability-redundant-smartptr-get] 114 | return _indexes->get(elementId)._set; // readability-redundant-smartptr-get | ^~~~~~~~~~~~~~~~~~~~~~~ | _indexes /home/runner/work/graphia/graphia/source/shared/loading/userelementdata.h:119:16: warning: redundant get() call on smart pointer [readability-redundant-smartptr-get] 119 | return _indexes->get(elementId)._value; // readability-redundant-smartptr-get | ^~~~~~~~~~~~~~~~~~~~~~~ | _indexes /home/runner/work/graphia/graphia/source/shared/loading/userelementdata.h:345:9: warning: variable 'jsonAttributes' of type 'json' (aka 'basic_json<>') can be declared 'const' [misc-const-correctness] 345 | json jsonAttributes = json::object(); // misc-const-correctness | ^ | const /home/runner/work/graphia/graphia/source/shared/plugins/iplugin.h:101:9: warning: function-like macro 'IPluginIID' used; consider a 'constexpr' template function [cppcoreguidelines-macro-usage] 101 | #define IPluginIID(NAME) "app.graphia.IPlugin:" #NAME "/" VERSION // cppcoreguidelines-macro-usage | ^ /home/runner/work/graphia/graphia/source/shared/utils/flags.h:33:5: warning: single-argument constructors must be marked explicit to avoid unintentional implicit conversions [google-explicit-constructor] 33 | Flags(Enum value) : | ^ | explicit /home/runner/work/graphia/graphia/source/shared/utils/flags.h:38:5: warning: constructors that are callable with a single argument must be marked explicit to avoid unintentional implicit conversions [google-explicit-constructor] 38 | Flags(Enum value, Tail... values) | ^ | explicit 36719 warnings generated. [63/195] /home/runner/work/graphia/graphia/source/shared/commands/command.h:46:5: warning: single-argument constructors must be marked explicit to avoid unintentional implicit conversions [google-explicit-constructor] 46 | CommandFn(Fn&& fn) : | ^ | explicit /home/runner/work/graphia/graphia/source/shared/commands/command.h:46:20: warning: forwarding reference parameter 'fn' is never forwarded inside the function body [cppcoreguidelines-missing-std-forward] 46 | CommandFn(Fn&& fn) : | ^ /home/runner/work/graphia/graphia/source/shared/commands/command.h:51:5: warning: single-argument constructors must be marked explicit to avoid unintentional implicit conversions [google-explicit-constructor] 51 | CommandFn(Fn&& fn) : | ^ | explicit /home/runner/work/graphia/graphia/source/shared/commands/command.h:51:20: warning: forwarding reference parameter 'fn' is never forwarded inside the function body [cppcoreguidelines-missing-std-forward] 51 | CommandFn(Fn&& fn) : | ^ /home/runner/work/graphia/graphia/source/shared/commands/command.h:85:9: warning: constructors that are callable with a single argument must be marked explicit to avoid unintentional implicit conversions [google-explicit-constructor] 85 | CommandDescription(const QString& description = {}, | ^ | explicit /home/runner/work/graphia/graphia/source/shared/graph/elementid.h:35:5: warning: single-argument constructors must be marked explicit to avoid unintentional implicit conversions [google-explicit-constructor] 35 | ElementId(int value = NullValue) : | ^ | explicit /home/runner/work/graphia/graphia/source/shared/graph/grapharray.h:92:9: warning: initializer for member '_mutex' is redundant [readability-redundant-member-init] 92 | _mutex(), | ^~~~~~~~ /home/runner/work/graphia/graphia/source/shared/loading/userelementdata.h:114:16: warning: redundant get() call on smart pointer [readability-redundant-smartptr-get] 114 | return _indexes->get(elementId)._set; // readability-redundant-smartptr-get | ^~~~~~~~~~~~~~~~~~~~~~~ | _indexes /home/runner/work/graphia/graphia/source/shared/loading/userelementdata.h:119:16: warning: redundant get() call on smart pointer [readability-redundant-smartptr-get] 119 | return _indexes->get(elementId)._value; // readability-redundant-smartptr-get | ^~~~~~~~~~~~~~~~~~~~~~~ | _indexes /home/runner/work/graphia/graphia/source/shared/loading/userelementdata.h:345:9: warning: variable 'jsonAttributes' of type 'json' (aka 'basic_json<>') can be declared 'const' [misc-const-correctness] 345 | json jsonAttributes = json::object(); // misc-const-correctness | ^ | const /home/runner/work/graphia/graphia/source/shared/plugins/iplugin.h:101:9: warning: function-like macro 'IPluginIID' used; consider a 'constexpr' template function [cppcoreguidelines-macro-usage] 101 | #define IPluginIID(NAME) "app.graphia.IPlugin:" #NAME "/" VERSION // cppcoreguidelines-macro-usage | ^ /home/runner/work/graphia/graphia/source/shared/utils/flags.h:33:5: warning: single-argument constructors must be marked explicit to avoid unintentional implicit conversions [google-explicit-constructor] 33 | Flags(Enum value) : | ^ | explicit /home/runner/work/graphia/graphia/source/shared/utils/flags.h:38:5: warning: constructors that are callable with a single argument must be marked explicit to avoid unintentional implicit conversions [google-explicit-constructor] 38 | Flags(Enum value, Tail... values) | ^ | explicit 36651 warnings generated. [64/195] /home/runner/work/graphia/graphia/source/shared/commands/command.h:46:5: warning: single-argument constructors must be marked explicit to avoid unintentional implicit conversions [google-explicit-constructor] 46 | CommandFn(Fn&& fn) : | ^ | explicit /home/runner/work/graphia/graphia/source/shared/commands/command.h:46:20: warning: forwarding reference parameter 'fn' is never forwarded inside the function body [cppcoreguidelines-missing-std-forward] 46 | CommandFn(Fn&& fn) : | ^ /home/runner/work/graphia/graphia/source/shared/commands/command.h:51:5: warning: single-argument constructors must be marked explicit to avoid unintentional implicit conversions [google-explicit-constructor] 51 | CommandFn(Fn&& fn) : | ^ | explicit /home/runner/work/graphia/graphia/source/shared/commands/command.h:51:20: warning: forwarding reference parameter 'fn' is never forwarded inside the function body [cppcoreguidelines-missing-std-forward] 51 | CommandFn(Fn&& fn) : | ^ /home/runner/work/graphia/graphia/source/shared/commands/command.h:85:9: warning: constructors that are callable with a single argument must be marked explicit to avoid unintentional implicit conversions [google-explicit-constructor] 85 | CommandDescription(const QString& description = {}, | ^ | explicit /home/runner/work/graphia/graphia/source/shared/graph/elementid.h:35:5: warning: single-argument constructors must be marked explicit to avoid unintentional implicit conversions [google-explicit-constructor] 35 | ElementId(int value = NullValue) : | ^ | explicit /home/runner/work/graphia/graphia/source/shared/graph/grapharray.h:92:9: warning: initializer for member '_mutex' is redundant [readability-redundant-member-init] 92 | _mutex(), | ^~~~~~~~ /home/runner/work/graphia/graphia/source/shared/loading/userelementdata.h:114:16: warning: redundant get() call on smart pointer [readability-redundant-smartptr-get] 114 | return _indexes->get(elementId)._set; // readability-redundant-smartptr-get | ^~~~~~~~~~~~~~~~~~~~~~~ | _indexes /home/runner/work/graphia/graphia/source/shared/loading/userelementdata.h:119:16: warning: redundant get() call on smart pointer [readability-redundant-smartptr-get] 119 | return _indexes->get(elementId)._value; // readability-redundant-smartptr-get | ^~~~~~~~~~~~~~~~~~~~~~~ | _indexes /home/runner/work/graphia/graphia/source/shared/loading/userelementdata.h:345:9: warning: variable 'jsonAttributes' of type 'json' (aka 'basic_json<>') can be declared 'const' [misc-const-correctness] 345 | json jsonAttributes = json::object(); // misc-const-correctness | ^ | const /home/runner/work/graphia/graphia/source/shared/plugins/iplugin.h:101:9: warning: function-like macro 'IPluginIID' used; consider a 'constexpr' template function [cppcoreguidelines-macro-usage] 101 | #define IPluginIID(NAME) "app.graphia.IPlugin:" #NAME "/" VERSION // cppcoreguidelines-macro-usage | ^ /home/runner/work/graphia/graphia/source/shared/utils/flags.h:33:5: warning: single-argument constructors must be marked explicit to avoid unintentional implicit conversions [google-explicit-constructor] 33 | Flags(Enum value) : | ^ | explicit /home/runner/work/graphia/graphia/source/shared/utils/flags.h:38:5: warning: constructors that are callable with a single argument must be marked explicit to avoid unintentional implicit conversions [google-explicit-constructor] 38 | Flags(Enum value, Tail... values) | ^ | explicit 36541 warnings generated. [65/195] /home/runner/work/graphia/graphia/source/shared/commands/command.h:46:5: warning: single-argument constructors must be marked explicit to avoid unintentional implicit conversions [google-explicit-constructor] 46 | CommandFn(Fn&& fn) : | ^ | explicit /home/runner/work/graphia/graphia/source/shared/commands/command.h:46:20: warning: forwarding reference parameter 'fn' is never forwarded inside the function body [cppcoreguidelines-missing-std-forward] 46 | CommandFn(Fn&& fn) : | ^ /home/runner/work/graphia/graphia/source/shared/commands/command.h:51:5: warning: single-argument constructors must be marked explicit to avoid unintentional implicit conversions [google-explicit-constructor] 51 | CommandFn(Fn&& fn) : | ^ | explicit /home/runner/work/graphia/graphia/source/shared/commands/command.h:51:20: warning: forwarding reference parameter 'fn' is never forwarded inside the function body [cppcoreguidelines-missing-std-forward] 51 | CommandFn(Fn&& fn) : | ^ /home/runner/work/graphia/graphia/source/shared/commands/command.h:85:9: warning: constructors that are callable with a single argument must be marked explicit to avoid unintentional implicit conversions [google-explicit-constructor] 85 | CommandDescription(const QString& description = {}, | ^ | explicit /home/runner/work/graphia/graphia/source/shared/graph/elementid.h:35:5: warning: single-argument constructors must be marked explicit to avoid unintentional implicit conversions [google-explicit-constructor] 35 | ElementId(int value = NullValue) : | ^ | explicit /home/runner/work/graphia/graphia/source/shared/graph/grapharray.h:92:9: warning: initializer for member '_mutex' is redundant [readability-redundant-member-init] 92 | _mutex(), | ^~~~~~~~ /home/runner/work/graphia/graphia/source/shared/loading/userelementdata.h:114:16: warning: redundant get() call on smart pointer [readability-redundant-smartptr-get] 114 | return _indexes->get(elementId)._set; // readability-redundant-smartptr-get | ^~~~~~~~~~~~~~~~~~~~~~~ | _indexes /home/runner/work/graphia/graphia/source/shared/loading/userelementdata.h:119:16: warning: redundant get() call on smart pointer [readability-redundant-smartptr-get] 119 | return _indexes->get(elementId)._value; // readability-redundant-smartptr-get | ^~~~~~~~~~~~~~~~~~~~~~~ | _indexes /home/runner/work/graphia/graphia/source/shared/loading/userelementdata.h:345:9: warning: variable 'jsonAttributes' of type 'json' (aka 'basic_json<>') can be declared 'const' [misc-const-correctness] 345 | json jsonAttributes = json::object(); // misc-const-correctness | ^ | const /home/runner/work/graphia/graphia/source/shared/plugins/iplugin.h:101:9: warning: function-like macro 'IPluginIID' used; consider a 'constexpr' template function [cppcoreguidelines-macro-usage] 101 | #define IPluginIID(NAME) "app.graphia.IPlugin:" #NAME "/" VERSION // cppcoreguidelines-macro-usage | ^ /home/runner/work/graphia/graphia/source/shared/utils/flags.h:33:5: warning: single-argument constructors must be marked explicit to avoid unintentional implicit conversions [google-explicit-constructor] 33 | Flags(Enum value) : | ^ | explicit /home/runner/work/graphia/graphia/source/shared/utils/flags.h:38:5: warning: constructors that are callable with a single argument must be marked explicit to avoid unintentional implicit conversions [google-explicit-constructor] 38 | Flags(Enum value, Tail... values) | ^ | explicit /home/runner/work/graphia/graphia/source/shared/utils/is_detected.h:24:1: warning: nested namespaces can be concatenated [modernize-concat-nested-namespaces] 24 | namespace std{ | ^~~~~~~~~~~~~~ 25 | namespace experimental{ | ~~~~~~~~~~~~~~~~~~~~~~ | namespace std::experimental /home/runner/work/graphia/graphia/source/shared/utils/is_detected.h:25:11: warning: modification of 'std' namespace can result in undefined behavior [cert-dcl58-cpp] 25 | namespace experimental{ | ^ /home/runner/work/graphia/graphia/source/shared/utils/is_detected.h:24:11: note: 'std' namespace opened here 24 | namespace std{ | ^ /home/runner/work/graphia/graphia/source/shared/utils/threadpool.h:66:109: warning: forwarding reference parameter 'args' is never forwarded inside the function body [cppcoreguidelines-missing-std-forward] 66 | template std::future> makeFuture(Fn f, Args&&... args) | ^ 38131 warnings generated. [66/195] 10716 warnings generated. [67/195] /home/runner/work/graphia/graphia/source/shared/graph/elementid.h:35:5: warning: single-argument constructors must be marked explicit to avoid unintentional implicit conversions [google-explicit-constructor] 35 | ElementId(int value = NullValue) : | ^ | explicit 7348 warnings generated. [68/195] 28557 warnings generated. [69/195] /home/runner/work/graphia/graphia/source/shared/commands/command.h:46:5: warning: single-argument constructors must be marked explicit to avoid unintentional implicit conversions [google-explicit-constructor] 46 | CommandFn(Fn&& fn) : | ^ | explicit /home/runner/work/graphia/graphia/source/shared/commands/command.h:46:20: warning: forwarding reference parameter 'fn' is never forwarded inside the function body [cppcoreguidelines-missing-std-forward] 46 | CommandFn(Fn&& fn) : | ^ /home/runner/work/graphia/graphia/source/shared/commands/command.h:51:5: warning: single-argument constructors must be marked explicit to avoid unintentional implicit conversions [google-explicit-constructor] 51 | CommandFn(Fn&& fn) : | ^ | explicit /home/runner/work/graphia/graphia/source/shared/commands/command.h:51:20: warning: forwarding reference parameter 'fn' is never forwarded inside the function body [cppcoreguidelines-missing-std-forward] 51 | CommandFn(Fn&& fn) : | ^ /home/runner/work/graphia/graphia/source/shared/commands/command.h:85:9: warning: constructors that are callable with a single argument must be marked explicit to avoid unintentional implicit conversions [google-explicit-constructor] 85 | CommandDescription(const QString& description = {}, | ^ | explicit /home/runner/work/graphia/graphia/source/shared/graph/elementid.h:35:5: warning: single-argument constructors must be marked explicit to avoid unintentional implicit conversions [google-explicit-constructor] 35 | ElementId(int value = NullValue) : | ^ | explicit /home/runner/work/graphia/graphia/source/shared/graph/grapharray.h:92:9: warning: initializer for member '_mutex' is redundant [readability-redundant-member-init] 92 | _mutex(), | ^~~~~~~~ /home/runner/work/graphia/graphia/source/shared/loading/userelementdata.h:114:16: warning: redundant get() call on smart pointer [readability-redundant-smartptr-get] 114 | return _indexes->get(elementId)._set; // readability-redundant-smartptr-get | ^~~~~~~~~~~~~~~~~~~~~~~ | _indexes /home/runner/work/graphia/graphia/source/shared/loading/userelementdata.h:119:16: warning: redundant get() call on smart pointer [readability-redundant-smartptr-get] 119 | return _indexes->get(elementId)._value; // readability-redundant-smartptr-get | ^~~~~~~~~~~~~~~~~~~~~~~ | _indexes /home/runner/work/graphia/graphia/source/shared/loading/userelementdata.h:345:9: warning: variable 'jsonAttributes' of type 'json' (aka 'basic_json<>') can be declared 'const' [misc-const-correctness] 345 | json jsonAttributes = json::object(); // misc-const-correctness | ^ | const /home/runner/work/graphia/graphia/source/shared/plugins/iplugin.h:101:9: warning: function-like macro 'IPluginIID' used; consider a 'constexpr' template function [cppcoreguidelines-macro-usage] 101 | #define IPluginIID(NAME) "app.graphia.IPlugin:" #NAME "/" VERSION // cppcoreguidelines-macro-usage | ^ /home/runner/work/graphia/graphia/source/shared/utils/flags.h:33:5: warning: single-argument constructors must be marked explicit to avoid unintentional implicit conversions [google-explicit-constructor] 33 | Flags(Enum value) : | ^ | explicit /home/runner/work/graphia/graphia/source/shared/utils/flags.h:38:5: warning: constructors that are callable with a single argument must be marked explicit to avoid unintentional implicit conversions [google-explicit-constructor] 38 | Flags(Enum value, Tail... values) | ^ | explicit /home/runner/work/graphia/graphia/source/shared/utils/is_detected.h:24:1: warning: nested namespaces can be concatenated [modernize-concat-nested-namespaces] 24 | namespace std{ | ^~~~~~~~~~~~~~ 25 | namespace experimental{ | ~~~~~~~~~~~~~~~~~~~~~~ | namespace std::experimental /home/runner/work/graphia/graphia/source/shared/utils/is_detected.h:25:11: warning: modification of 'std' namespace can result in undefined behavior [cert-dcl58-cpp] 25 | namespace experimental{ | ^ /home/runner/work/graphia/graphia/source/shared/utils/is_detected.h:24:11: note: 'std' namespace opened here 24 | namespace std{ | ^ /home/runner/work/graphia/graphia/source/shared/utils/threadpool.h:66:109: warning: forwarding reference parameter 'args' is never forwarded inside the function body [cppcoreguidelines-missing-std-forward] 66 | template std::future> makeFuture(Fn f, Args&&... args) | ^ 20095 warnings generated. [70/195] /home/runner/work/graphia/graphia/source/shared/commands/command.h:46:5: warning: single-argument constructors must be marked explicit to avoid unintentional implicit conversions [google-explicit-constructor] 46 | CommandFn(Fn&& fn) : | ^ | explicit /home/runner/work/graphia/graphia/source/shared/commands/command.h:46:20: warning: forwarding reference parameter 'fn' is never forwarded inside the function body [cppcoreguidelines-missing-std-forward] 46 | CommandFn(Fn&& fn) : | ^ /home/runner/work/graphia/graphia/source/shared/commands/command.h:51:5: warning: single-argument constructors must be marked explicit to avoid unintentional implicit conversions [google-explicit-constructor] 51 | CommandFn(Fn&& fn) : | ^ | explicit /home/runner/work/graphia/graphia/source/shared/commands/command.h:51:20: warning: forwarding reference parameter 'fn' is never forwarded inside the function body [cppcoreguidelines-missing-std-forward] 51 | CommandFn(Fn&& fn) : | ^ /home/runner/work/graphia/graphia/source/shared/commands/command.h:85:9: warning: constructors that are callable with a single argument must be marked explicit to avoid unintentional implicit conversions [google-explicit-constructor] 85 | CommandDescription(const QString& description = {}, | ^ | explicit /home/runner/work/graphia/graphia/source/shared/graph/elementid.h:35:5: warning: single-argument constructors must be marked explicit to avoid unintentional implicit conversions [google-explicit-constructor] 35 | ElementId(int value = NullValue) : | ^ | explicit /home/runner/work/graphia/graphia/source/shared/graph/grapharray.h:92:9: warning: initializer for member '_mutex' is redundant [readability-redundant-member-init] 92 | _mutex(), | ^~~~~~~~ /home/runner/work/graphia/graphia/source/shared/loading/userelementdata.h:114:16: warning: redundant get() call on smart pointer [readability-redundant-smartptr-get] 114 | return _indexes->get(elementId)._set; // readability-redundant-smartptr-get | ^~~~~~~~~~~~~~~~~~~~~~~ | _indexes /home/runner/work/graphia/graphia/source/shared/loading/userelementdata.h:119:16: warning: redundant get() call on smart pointer [readability-redundant-smartptr-get] 119 | return _indexes->get(elementId)._value; // readability-redundant-smartptr-get | ^~~~~~~~~~~~~~~~~~~~~~~ | _indexes /home/runner/work/graphia/graphia/source/shared/loading/userelementdata.h:345:9: warning: variable 'jsonAttributes' of type 'json' (aka 'basic_json<>') can be declared 'const' [misc-const-correctness] 345 | json jsonAttributes = json::object(); // misc-const-correctness | ^ | const /home/runner/work/graphia/graphia/source/shared/plugins/iplugin.h:101:9: warning: function-like macro 'IPluginIID' used; consider a 'constexpr' template function [cppcoreguidelines-macro-usage] 101 | #define IPluginIID(NAME) "app.graphia.IPlugin:" #NAME "/" VERSION // cppcoreguidelines-macro-usage | ^ /home/runner/work/graphia/graphia/source/shared/utils/flags.h:33:5: warning: single-argument constructors must be marked explicit to avoid unintentional implicit conversions [google-explicit-constructor] 33 | Flags(Enum value) : | ^ | explicit /home/runner/work/graphia/graphia/source/shared/utils/flags.h:38:5: warning: constructors that are callable with a single argument must be marked explicit to avoid unintentional implicit conversions [google-explicit-constructor] 38 | Flags(Enum value, Tail... values) | ^ | explicit 19760 warnings generated. [71/195] /home/runner/work/graphia/graphia/source/shared/commands/command.h:46:5: warning: single-argument constructors must be marked explicit to avoid unintentional implicit conversions [google-explicit-constructor] 46 | CommandFn(Fn&& fn) : | ^ | explicit /home/runner/work/graphia/graphia/source/shared/commands/command.h:46:20: warning: forwarding reference parameter 'fn' is never forwarded inside the function body [cppcoreguidelines-missing-std-forward] 46 | CommandFn(Fn&& fn) : | ^ /home/runner/work/graphia/graphia/source/shared/commands/command.h:51:5: warning: single-argument constructors must be marked explicit to avoid unintentional implicit conversions [google-explicit-constructor] 51 | CommandFn(Fn&& fn) : | ^ | explicit /home/runner/work/graphia/graphia/source/shared/commands/command.h:51:20: warning: forwarding reference parameter 'fn' is never forwarded inside the function body [cppcoreguidelines-missing-std-forward] 51 | CommandFn(Fn&& fn) : | ^ /home/runner/work/graphia/graphia/source/shared/commands/command.h:85:9: warning: constructors that are callable with a single argument must be marked explicit to avoid unintentional implicit conversions [google-explicit-constructor] 85 | CommandDescription(const QString& description = {}, | ^ | explicit /home/runner/work/graphia/graphia/source/shared/graph/elementid.h:35:5: warning: single-argument constructors must be marked explicit to avoid unintentional implicit conversions [google-explicit-constructor] 35 | ElementId(int value = NullValue) : | ^ | explicit /home/runner/work/graphia/graphia/source/shared/graph/grapharray.h:92:9: warning: initializer for member '_mutex' is redundant [readability-redundant-member-init] 92 | _mutex(), | ^~~~~~~~ /home/runner/work/graphia/graphia/source/shared/loading/userelementdata.h:114:16: warning: redundant get() call on smart pointer [readability-redundant-smartptr-get] 114 | return _indexes->get(elementId)._set; // readability-redundant-smartptr-get | ^~~~~~~~~~~~~~~~~~~~~~~ | _indexes /home/runner/work/graphia/graphia/source/shared/loading/userelementdata.h:119:16: warning: redundant get() call on smart pointer [readability-redundant-smartptr-get] 119 | return _indexes->get(elementId)._value; // readability-redundant-smartptr-get | ^~~~~~~~~~~~~~~~~~~~~~~ | _indexes /home/runner/work/graphia/graphia/source/shared/loading/userelementdata.h:345:9: warning: variable 'jsonAttributes' of type 'json' (aka 'basic_json<>') can be declared 'const' [misc-const-correctness] 345 | json jsonAttributes = json::object(); // misc-const-correctness | ^ | const /home/runner/work/graphia/graphia/source/shared/plugins/iplugin.h:101:9: warning: function-like macro 'IPluginIID' used; consider a 'constexpr' template function [cppcoreguidelines-macro-usage] 101 | #define IPluginIID(NAME) "app.graphia.IPlugin:" #NAME "/" VERSION // cppcoreguidelines-macro-usage | ^ /home/runner/work/graphia/graphia/source/shared/utils/flags.h:33:5: warning: single-argument constructors must be marked explicit to avoid unintentional implicit conversions [google-explicit-constructor] 33 | Flags(Enum value) : | ^ | explicit /home/runner/work/graphia/graphia/source/shared/utils/flags.h:38:5: warning: constructors that are callable with a single argument must be marked explicit to avoid unintentional implicit conversions [google-explicit-constructor] 38 | Flags(Enum value, Tail... values) | ^ | explicit 20007 warnings generated. [72/195] /home/runner/work/graphia/graphia/source/shared/commands/command.h:46:5: warning: single-argument constructors must be marked explicit to avoid unintentional implicit conversions [google-explicit-constructor] 46 | CommandFn(Fn&& fn) : | ^ | explicit /home/runner/work/graphia/graphia/source/shared/commands/command.h:46:20: warning: forwarding reference parameter 'fn' is never forwarded inside the function body [cppcoreguidelines-missing-std-forward] 46 | CommandFn(Fn&& fn) : | ^ /home/runner/work/graphia/graphia/source/shared/commands/command.h:51:5: warning: single-argument constructors must be marked explicit to avoid unintentional implicit conversions [google-explicit-constructor] 51 | CommandFn(Fn&& fn) : | ^ | explicit /home/runner/work/graphia/graphia/source/shared/commands/command.h:51:20: warning: forwarding reference parameter 'fn' is never forwarded inside the function body [cppcoreguidelines-missing-std-forward] 51 | CommandFn(Fn&& fn) : | ^ /home/runner/work/graphia/graphia/source/shared/commands/command.h:85:9: warning: constructors that are callable with a single argument must be marked explicit to avoid unintentional implicit conversions [google-explicit-constructor] 85 | CommandDescription(const QString& description = {}, | ^ | explicit /home/runner/work/graphia/graphia/source/shared/graph/elementid.h:35:5: warning: single-argument constructors must be marked explicit to avoid unintentional implicit conversions [google-explicit-constructor] 35 | ElementId(int value = NullValue) : | ^ | explicit /home/runner/work/graphia/graphia/source/shared/graph/grapharray.h:92:9: warning: initializer for member '_mutex' is redundant [readability-redundant-member-init] 92 | _mutex(), | ^~~~~~~~ /home/runner/work/graphia/graphia/source/shared/loading/userelementdata.h:114:16: warning: redundant get() call on smart pointer [readability-redundant-smartptr-get] 114 | return _indexes->get(elementId)._set; // readability-redundant-smartptr-get | ^~~~~~~~~~~~~~~~~~~~~~~ | _indexes /home/runner/work/graphia/graphia/source/shared/loading/userelementdata.h:119:16: warning: redundant get() call on smart pointer [readability-redundant-smartptr-get] 119 | return _indexes->get(elementId)._value; // readability-redundant-smartptr-get | ^~~~~~~~~~~~~~~~~~~~~~~ | _indexes /home/runner/work/graphia/graphia/source/shared/loading/userelementdata.h:345:9: warning: variable 'jsonAttributes' of type 'json' (aka 'basic_json<>') can be declared 'const' [misc-const-correctness] 345 | json jsonAttributes = json::object(); // misc-const-correctness | ^ | const /home/runner/work/graphia/graphia/source/shared/plugins/iplugin.h:101:9: warning: function-like macro 'IPluginIID' used; consider a 'constexpr' template function [cppcoreguidelines-macro-usage] 101 | #define IPluginIID(NAME) "app.graphia.IPlugin:" #NAME "/" VERSION // cppcoreguidelines-macro-usage | ^ /home/runner/work/graphia/graphia/source/shared/utils/flags.h:33:5: warning: single-argument constructors must be marked explicit to avoid unintentional implicit conversions [google-explicit-constructor] 33 | Flags(Enum value) : | ^ | explicit /home/runner/work/graphia/graphia/source/shared/utils/flags.h:38:5: warning: constructors that are callable with a single argument must be marked explicit to avoid unintentional implicit conversions [google-explicit-constructor] 38 | Flags(Enum value, Tail... values) | ^ | explicit /home/runner/work/graphia/graphia/source/shared/utils/is_detected.h:24:1: warning: nested namespaces can be concatenated [modernize-concat-nested-namespaces] 24 | namespace std{ | ^~~~~~~~~~~~~~ 25 | namespace experimental{ | ~~~~~~~~~~~~~~~~~~~~~~ | namespace std::experimental /home/runner/work/graphia/graphia/source/shared/utils/is_detected.h:25:11: warning: modification of 'std' namespace can result in undefined behavior [cert-dcl58-cpp] 25 | namespace experimental{ | ^ /home/runner/work/graphia/graphia/source/shared/utils/is_detected.h:24:11: note: 'std' namespace opened here 24 | namespace std{ | ^ /home/runner/work/graphia/graphia/source/shared/utils/scope_exit.h:27:1: warning: nested namespaces can be concatenated [modernize-concat-nested-namespaces] 27 | namespace std{ | ^~~~~~~~~~~~~~ 28 | namespace experimental{ | ~~~~~~~~~~~~~~~~~~~~~~ | namespace std::experimental /home/runner/work/graphia/graphia/source/shared/utils/scope_exit.h:28:11: warning: modification of 'std' namespace can result in undefined behavior [cert-dcl58-cpp] 28 | namespace experimental{ | ^ /home/runner/work/graphia/graphia/source/shared/utils/scope_exit.h:27:11: note: 'std' namespace opened here 27 | namespace std{ | ^ /home/runner/work/graphia/graphia/source/shared/utils/threadpool.h:66:109: warning: forwarding reference parameter 'args' is never forwarded inside the function body [cppcoreguidelines-missing-std-forward] 66 | template std::future> makeFuture(Fn f, Args&&... args) | ^ 20484 warnings generated. [73/195] 28324 warnings generated. [74/195] /home/runner/work/graphia/graphia/source/shared/graph/elementid.h:35:5: warning: single-argument constructors must be marked explicit to avoid unintentional implicit conversions [google-explicit-constructor] 35 | ElementId(int value = NullValue) : | ^ | explicit 7421 warnings generated. [75/195] /home/runner/work/graphia/graphia/source/shared/commands/command.h:46:5: warning: single-argument constructors must be marked explicit to avoid unintentional implicit conversions [google-explicit-constructor] 46 | CommandFn(Fn&& fn) : | ^ | explicit /home/runner/work/graphia/graphia/source/shared/commands/command.h:46:20: warning: forwarding reference parameter 'fn' is never forwarded inside the function body [cppcoreguidelines-missing-std-forward] 46 | CommandFn(Fn&& fn) : | ^ /home/runner/work/graphia/graphia/source/shared/commands/command.h:51:5: warning: single-argument constructors must be marked explicit to avoid unintentional implicit conversions [google-explicit-constructor] 51 | CommandFn(Fn&& fn) : | ^ | explicit /home/runner/work/graphia/graphia/source/shared/commands/command.h:51:20: warning: forwarding reference parameter 'fn' is never forwarded inside the function body [cppcoreguidelines-missing-std-forward] 51 | CommandFn(Fn&& fn) : | ^ /home/runner/work/graphia/graphia/source/shared/commands/command.h:85:9: warning: constructors that are callable with a single argument must be marked explicit to avoid unintentional implicit conversions [google-explicit-constructor] 85 | CommandDescription(const QString& description = {}, | ^ | explicit /home/runner/work/graphia/graphia/source/shared/graph/elementid.h:35:5: warning: single-argument constructors must be marked explicit to avoid unintentional implicit conversions [google-explicit-constructor] 35 | ElementId(int value = NullValue) : | ^ | explicit /home/runner/work/graphia/graphia/source/shared/graph/grapharray.h:92:9: warning: initializer for member '_mutex' is redundant [readability-redundant-member-init] 92 | _mutex(), | ^~~~~~~~ /home/runner/work/graphia/graphia/source/shared/loading/userelementdata.h:114:16: warning: redundant get() call on smart pointer [readability-redundant-smartptr-get] 114 | return _indexes->get(elementId)._set; // readability-redundant-smartptr-get | ^~~~~~~~~~~~~~~~~~~~~~~ | _indexes /home/runner/work/graphia/graphia/source/shared/loading/userelementdata.h:119:16: warning: redundant get() call on smart pointer [readability-redundant-smartptr-get] 119 | return _indexes->get(elementId)._value; // readability-redundant-smartptr-get | ^~~~~~~~~~~~~~~~~~~~~~~ | _indexes /home/runner/work/graphia/graphia/source/shared/loading/userelementdata.h:345:9: warning: variable 'jsonAttributes' of type 'json' (aka 'basic_json<>') can be declared 'const' [misc-const-correctness] 345 | json jsonAttributes = json::object(); // misc-const-correctness | ^ | const /home/runner/work/graphia/graphia/source/shared/plugins/iplugin.h:101:9: warning: function-like macro 'IPluginIID' used; consider a 'constexpr' template function [cppcoreguidelines-macro-usage] 101 | #define IPluginIID(NAME) "app.graphia.IPlugin:" #NAME "/" VERSION // cppcoreguidelines-macro-usage | ^ /home/runner/work/graphia/graphia/source/shared/utils/flags.h:33:5: warning: single-argument constructors must be marked explicit to avoid unintentional implicit conversions [google-explicit-constructor] 33 | Flags(Enum value) : | ^ | explicit /home/runner/work/graphia/graphia/source/shared/utils/flags.h:38:5: warning: constructors that are callable with a single argument must be marked explicit to avoid unintentional implicit conversions [google-explicit-constructor] 38 | Flags(Enum value, Tail... values) | ^ | explicit 18543 warnings generated. [76/195] /home/runner/work/graphia/graphia/source/shared/commands/command.h:46:5: warning: single-argument constructors must be marked explicit to avoid unintentional implicit conversions [google-explicit-constructor] 46 | CommandFn(Fn&& fn) : | ^ | explicit /home/runner/work/graphia/graphia/source/shared/commands/command.h:46:20: warning: forwarding reference parameter 'fn' is never forwarded inside the function body [cppcoreguidelines-missing-std-forward] 46 | CommandFn(Fn&& fn) : | ^ /home/runner/work/graphia/graphia/source/shared/commands/command.h:51:5: warning: single-argument constructors must be marked explicit to avoid unintentional implicit conversions [google-explicit-constructor] 51 | CommandFn(Fn&& fn) : | ^ | explicit /home/runner/work/graphia/graphia/source/shared/commands/command.h:51:20: warning: forwarding reference parameter 'fn' is never forwarded inside the function body [cppcoreguidelines-missing-std-forward] 51 | CommandFn(Fn&& fn) : | ^ /home/runner/work/graphia/graphia/source/shared/commands/command.h:85:9: warning: constructors that are callable with a single argument must be marked explicit to avoid unintentional implicit conversions [google-explicit-constructor] 85 | CommandDescription(const QString& description = {}, | ^ | explicit /home/runner/work/graphia/graphia/source/shared/graph/elementid.h:35:5: warning: single-argument constructors must be marked explicit to avoid unintentional implicit conversions [google-explicit-constructor] 35 | ElementId(int value = NullValue) : | ^ | explicit /home/runner/work/graphia/graphia/source/shared/graph/grapharray.h:92:9: warning: initializer for member '_mutex' is redundant [readability-redundant-member-init] 92 | _mutex(), | ^~~~~~~~ /home/runner/work/graphia/graphia/source/shared/loading/userelementdata.h:114:16: warning: redundant get() call on smart pointer [readability-redundant-smartptr-get] 114 | return _indexes->get(elementId)._set; // readability-redundant-smartptr-get | ^~~~~~~~~~~~~~~~~~~~~~~ | _indexes /home/runner/work/graphia/graphia/source/shared/loading/userelementdata.h:119:16: warning: redundant get() call on smart pointer [readability-redundant-smartptr-get] 119 | return _indexes->get(elementId)._value; // readability-redundant-smartptr-get | ^~~~~~~~~~~~~~~~~~~~~~~ | _indexes /home/runner/work/graphia/graphia/source/shared/loading/userelementdata.h:345:9: warning: variable 'jsonAttributes' of type 'json' (aka 'basic_json<>') can be declared 'const' [misc-const-correctness] 345 | json jsonAttributes = json::object(); // misc-const-correctness | ^ | const /home/runner/work/graphia/graphia/source/shared/plugins/iplugin.h:101:9: warning: function-like macro 'IPluginIID' used; consider a 'constexpr' template function [cppcoreguidelines-macro-usage] 101 | #define IPluginIID(NAME) "app.graphia.IPlugin:" #NAME "/" VERSION // cppcoreguidelines-macro-usage | ^ /home/runner/work/graphia/graphia/source/shared/utils/flags.h:33:5: warning: single-argument constructors must be marked explicit to avoid unintentional implicit conversions [google-explicit-constructor] 33 | Flags(Enum value) : | ^ | explicit /home/runner/work/graphia/graphia/source/shared/utils/flags.h:38:5: warning: constructors that are callable with a single argument must be marked explicit to avoid unintentional implicit conversions [google-explicit-constructor] 38 | Flags(Enum value, Tail... values) | ^ | explicit 18543 warnings generated. [77/195] /home/runner/work/graphia/graphia/source/shared/commands/command.h:46:5: warning: single-argument constructors must be marked explicit to avoid unintentional implicit conversions [google-explicit-constructor] 46 | CommandFn(Fn&& fn) : | ^ | explicit /home/runner/work/graphia/graphia/source/shared/commands/command.h:46:20: warning: forwarding reference parameter 'fn' is never forwarded inside the function body [cppcoreguidelines-missing-std-forward] 46 | CommandFn(Fn&& fn) : | ^ /home/runner/work/graphia/graphia/source/shared/commands/command.h:51:5: warning: single-argument constructors must be marked explicit to avoid unintentional implicit conversions [google-explicit-constructor] 51 | CommandFn(Fn&& fn) : | ^ | explicit /home/runner/work/graphia/graphia/source/shared/commands/command.h:51:20: warning: forwarding reference parameter 'fn' is never forwarded inside the function body [cppcoreguidelines-missing-std-forward] 51 | CommandFn(Fn&& fn) : | ^ /home/runner/work/graphia/graphia/source/shared/commands/command.h:85:9: warning: constructors that are callable with a single argument must be marked explicit to avoid unintentional implicit conversions [google-explicit-constructor] 85 | CommandDescription(const QString& description = {}, | ^ | explicit /home/runner/work/graphia/graphia/source/shared/graph/grapharray.h:92:9: warning: initializer for member '_mutex' is redundant [readability-redundant-member-init] 92 | _mutex(), | ^~~~~~~~ /home/runner/work/graphia/graphia/source/shared/loading/userelementdata.h:114:16: warning: redundant get() call on smart pointer [readability-redundant-smartptr-get] 114 | return _indexes->get(elementId)._set; // readability-redundant-smartptr-get | ^~~~~~~~~~~~~~~~~~~~~~~ | _indexes /home/runner/work/graphia/graphia/source/shared/loading/userelementdata.h:119:16: warning: redundant get() call on smart pointer [readability-redundant-smartptr-get] 119 | return _indexes->get(elementId)._value; // readability-redundant-smartptr-get | ^~~~~~~~~~~~~~~~~~~~~~~ | _indexes /home/runner/work/graphia/graphia/source/shared/loading/userelementdata.h:345:9: warning: variable 'jsonAttributes' of type 'json' (aka 'basic_json<>') can be declared 'const' [misc-const-correctness] 345 | json jsonAttributes = json::object(); // misc-const-correctness | ^ | const /home/runner/work/graphia/graphia/source/shared/plugins/iplugin.h:101:9: warning: function-like macro 'IPluginIID' used; consider a 'constexpr' template function [cppcoreguidelines-macro-usage] 101 | #define IPluginIID(NAME) "app.graphia.IPlugin:" #NAME "/" VERSION // cppcoreguidelines-macro-usage | ^ /home/runner/work/graphia/graphia/source/shared/utils/flags.h:33:5: warning: single-argument constructors must be marked explicit to avoid unintentional implicit conversions [google-explicit-constructor] 33 | Flags(Enum value) : | ^ | explicit /home/runner/work/graphia/graphia/source/shared/utils/flags.h:38:5: warning: constructors that are callable with a single argument must be marked explicit to avoid unintentional implicit conversions [google-explicit-constructor] 38 | Flags(Enum value, Tail... values) | ^ | explicit 33839 warnings generated. [78/195] /home/runner/work/graphia/graphia/source/shared/graph/elementid.h:35:5: warning: single-argument constructors must be marked explicit to avoid unintentional implicit conversions [google-explicit-constructor] 35 | ElementId(int value = NullValue) : | ^ | explicit /home/runner/work/graphia/graphia/source/shared/utils/flags.h:33:5: warning: single-argument constructors must be marked explicit to avoid unintentional implicit conversions [google-explicit-constructor] 33 | Flags(Enum value) : | ^ | explicit /home/runner/work/graphia/graphia/source/shared/utils/flags.h:38:5: warning: constructors that are callable with a single argument must be marked explicit to avoid unintentional implicit conversions [google-explicit-constructor] 38 | Flags(Enum value, Tail... values) | ^ | explicit 12707 warnings generated. [79/195] /home/runner/work/graphia/graphia/source/shared/graph/elementid.h:35:5: warning: single-argument constructors must be marked explicit to avoid unintentional implicit conversions [google-explicit-constructor] 35 | ElementId(int value = NullValue) : | ^ | explicit /home/runner/work/graphia/graphia/source/shared/graph/grapharray.h:92:9: warning: initializer for member '_mutex' is redundant [readability-redundant-member-init] 92 | _mutex(), | ^~~~~~~~ /home/runner/work/graphia/graphia/source/shared/loading/userelementdata.h:114:16: warning: redundant get() call on smart pointer [readability-redundant-smartptr-get] 114 | return _indexes->get(elementId)._set; // readability-redundant-smartptr-get | ^~~~~~~~~~~~~~~~~~~~~~~ | _indexes /home/runner/work/graphia/graphia/source/shared/loading/userelementdata.h:119:16: warning: redundant get() call on smart pointer [readability-redundant-smartptr-get] 119 | return _indexes->get(elementId)._value; // readability-redundant-smartptr-get | ^~~~~~~~~~~~~~~~~~~~~~~ | _indexes /home/runner/work/graphia/graphia/source/shared/loading/userelementdata.h:345:9: warning: variable 'jsonAttributes' of type 'json' (aka 'basic_json<>') can be declared 'const' [misc-const-correctness] 345 | json jsonAttributes = json::object(); // misc-const-correctness | ^ | const /home/runner/work/graphia/graphia/source/shared/utils/flags.h:33:5: warning: single-argument constructors must be marked explicit to avoid unintentional implicit conversions [google-explicit-constructor] 33 | Flags(Enum value) : | ^ | explicit /home/runner/work/graphia/graphia/source/shared/utils/flags.h:38:5: warning: constructors that are callable with a single argument must be marked explicit to avoid unintentional implicit conversions [google-explicit-constructor] 38 | Flags(Enum value, Tail... values) | ^ | explicit 20795 warnings generated. [80/195] /home/runner/work/graphia/graphia/source/app/attributes/conditionfncreator.h:51:9: warning: single-argument constructors must be marked explicit to avoid unintentional implicit conversions [google-explicit-constructor] 51 | TerminalValueWrapper(GraphTransformConfig::TerminalValue terminalValue) : | ^ | explicit /home/runner/work/graphia/graphia/source/shared/graph/elementid.h:35:5: warning: single-argument constructors must be marked explicit to avoid unintentional implicit conversions [google-explicit-constructor] 35 | ElementId(int value = NullValue) : | ^ | explicit /home/runner/work/graphia/graphia/source/shared/graph/grapharray.h:92:9: warning: initializer for member '_mutex' is redundant [readability-redundant-member-init] 92 | _mutex(), | ^~~~~~~~ /home/runner/work/graphia/graphia/source/shared/loading/userelementdata.h:114:16: warning: redundant get() call on smart pointer [readability-redundant-smartptr-get] 114 | return _indexes->get(elementId)._set; // readability-redundant-smartptr-get | ^~~~~~~~~~~~~~~~~~~~~~~ | _indexes /home/runner/work/graphia/graphia/source/shared/loading/userelementdata.h:119:16: warning: redundant get() call on smart pointer [readability-redundant-smartptr-get] 119 | return _indexes->get(elementId)._value; // readability-redundant-smartptr-get | ^~~~~~~~~~~~~~~~~~~~~~~ | _indexes /home/runner/work/graphia/graphia/source/shared/loading/userelementdata.h:345:9: warning: variable 'jsonAttributes' of type 'json' (aka 'basic_json<>') can be declared 'const' [misc-const-correctness] 345 | json jsonAttributes = json::object(); // misc-const-correctness | ^ | const /home/runner/work/graphia/graphia/source/shared/utils/flags.h:33:5: warning: single-argument constructors must be marked explicit to avoid unintentional implicit conversions [google-explicit-constructor] 33 | Flags(Enum value) : | ^ | explicit /home/runner/work/graphia/graphia/source/shared/utils/flags.h:38:5: warning: constructors that are callable with a single argument must be marked explicit to avoid unintentional implicit conversions [google-explicit-constructor] 38 | Flags(Enum value, Tail... values) | ^ | explicit 24736 warnings generated. [81/195] /home/runner/work/graphia/graphia/source/shared/commands/command.h:46:5: warning: single-argument constructors must be marked explicit to avoid unintentional implicit conversions [google-explicit-constructor] 46 | CommandFn(Fn&& fn) : | ^ | explicit /home/runner/work/graphia/graphia/source/shared/commands/command.h:46:20: warning: forwarding reference parameter 'fn' is never forwarded inside the function body [cppcoreguidelines-missing-std-forward] 46 | CommandFn(Fn&& fn) : | ^ /home/runner/work/graphia/graphia/source/shared/commands/command.h:51:5: warning: single-argument constructors must be marked explicit to avoid unintentional implicit conversions [google-explicit-constructor] 51 | CommandFn(Fn&& fn) : | ^ | explicit /home/runner/work/graphia/graphia/source/shared/commands/command.h:51:20: warning: forwarding reference parameter 'fn' is never forwarded inside the function body [cppcoreguidelines-missing-std-forward] 51 | CommandFn(Fn&& fn) : | ^ /home/runner/work/graphia/graphia/source/shared/commands/command.h:85:9: warning: constructors that are callable with a single argument must be marked explicit to avoid unintentional implicit conversions [google-explicit-constructor] 85 | CommandDescription(const QString& description = {}, | ^ | explicit /home/runner/work/graphia/graphia/source/shared/graph/elementid.h:35:5: warning: single-argument constructors must be marked explicit to avoid unintentional implicit conversions [google-explicit-constructor] 35 | ElementId(int value = NullValue) : | ^ | explicit /home/runner/work/graphia/graphia/source/shared/graph/grapharray.h:92:9: warning: initializer for member '_mutex' is redundant [readability-redundant-member-init] 92 | _mutex(), | ^~~~~~~~ /home/runner/work/graphia/graphia/source/shared/plugins/iplugin.h:101:9: warning: function-like macro 'IPluginIID' used; consider a 'constexpr' template function [cppcoreguidelines-macro-usage] 101 | #define IPluginIID(NAME) "app.graphia.IPlugin:" #NAME "/" VERSION // cppcoreguidelines-macro-usage | ^ /home/runner/work/graphia/graphia/source/shared/utils/flags.h:33:5: warning: single-argument constructors must be marked explicit to avoid unintentional implicit conversions [google-explicit-constructor] 33 | Flags(Enum value) : | ^ | explicit /home/runner/work/graphia/graphia/source/shared/utils/flags.h:38:5: warning: constructors that are callable with a single argument must be marked explicit to avoid unintentional implicit conversions [google-explicit-constructor] 38 | Flags(Enum value, Tail... values) | ^ | explicit 13473 warnings generated. [82/195] /home/runner/work/graphia/graphia/source/shared/commands/command.h:46:5: warning: single-argument constructors must be marked explicit to avoid unintentional implicit conversions [google-explicit-constructor] 46 | CommandFn(Fn&& fn) : | ^ | explicit /home/runner/work/graphia/graphia/source/shared/commands/command.h:46:20: warning: forwarding reference parameter 'fn' is never forwarded inside the function body [cppcoreguidelines-missing-std-forward] 46 | CommandFn(Fn&& fn) : | ^ /home/runner/work/graphia/graphia/source/shared/commands/command.h:51:5: warning: single-argument constructors must be marked explicit to avoid unintentional implicit conversions [google-explicit-constructor] 51 | CommandFn(Fn&& fn) : | ^ | explicit /home/runner/work/graphia/graphia/source/shared/commands/command.h:51:20: warning: forwarding reference parameter 'fn' is never forwarded inside the function body [cppcoreguidelines-missing-std-forward] 51 | CommandFn(Fn&& fn) : | ^ /home/runner/work/graphia/graphia/source/shared/commands/command.h:85:9: warning: constructors that are callable with a single argument must be marked explicit to avoid unintentional implicit conversions [google-explicit-constructor] 85 | CommandDescription(const QString& description = {}, | ^ | explicit /home/runner/work/graphia/graphia/source/shared/graph/elementid.h:35:5: warning: single-argument constructors must be marked explicit to avoid unintentional implicit conversions [google-explicit-constructor] 35 | ElementId(int value = NullValue) : | ^ | explicit 11070 warnings generated. [83/195] 10410 warnings generated. [84/195] /home/runner/work/graphia/graphia/source/shared/commands/command.h:46:5: warning: single-argument constructors must be marked explicit to avoid unintentional implicit conversions [google-explicit-constructor] 46 | CommandFn(Fn&& fn) : | ^ | explicit /home/runner/work/graphia/graphia/source/shared/commands/command.h:46:20: warning: forwarding reference parameter 'fn' is never forwarded inside the function body [cppcoreguidelines-missing-std-forward] 46 | CommandFn(Fn&& fn) : | ^ /home/runner/work/graphia/graphia/source/shared/commands/command.h:51:5: warning: single-argument constructors must be marked explicit to avoid unintentional implicit conversions [google-explicit-constructor] 51 | CommandFn(Fn&& fn) : | ^ | explicit /home/runner/work/graphia/graphia/source/shared/commands/command.h:51:20: warning: forwarding reference parameter 'fn' is never forwarded inside the function body [cppcoreguidelines-missing-std-forward] 51 | CommandFn(Fn&& fn) : | ^ /home/runner/work/graphia/graphia/source/shared/commands/command.h:85:9: warning: constructors that are callable with a single argument must be marked explicit to avoid unintentional implicit conversions [google-explicit-constructor] 85 | CommandDescription(const QString& description = {}, | ^ | explicit /home/runner/work/graphia/graphia/source/shared/graph/elementid.h:35:5: warning: single-argument constructors must be marked explicit to avoid unintentional implicit conversions [google-explicit-constructor] 35 | ElementId(int value = NullValue) : | ^ | explicit /home/runner/work/graphia/graphia/source/shared/graph/grapharray.h:92:9: warning: initializer for member '_mutex' is redundant [readability-redundant-member-init] 92 | _mutex(), | ^~~~~~~~ /home/runner/work/graphia/graphia/source/shared/loading/userelementdata.h:114:16: warning: redundant get() call on smart pointer [readability-redundant-smartptr-get] 114 | return _indexes->get(elementId)._set; // readability-redundant-smartptr-get | ^~~~~~~~~~~~~~~~~~~~~~~ | _indexes /home/runner/work/graphia/graphia/source/shared/loading/userelementdata.h:119:16: warning: redundant get() call on smart pointer [readability-redundant-smartptr-get] 119 | return _indexes->get(elementId)._value; // readability-redundant-smartptr-get | ^~~~~~~~~~~~~~~~~~~~~~~ | _indexes /home/runner/work/graphia/graphia/source/shared/loading/userelementdata.h:345:9: warning: variable 'jsonAttributes' of type 'json' (aka 'basic_json<>') can be declared 'const' [misc-const-correctness] 345 | json jsonAttributes = json::object(); // misc-const-correctness | ^ | const /home/runner/work/graphia/graphia/source/shared/plugins/iplugin.h:101:9: warning: function-like macro 'IPluginIID' used; consider a 'constexpr' template function [cppcoreguidelines-macro-usage] 101 | #define IPluginIID(NAME) "app.graphia.IPlugin:" #NAME "/" VERSION // cppcoreguidelines-macro-usage | ^ /home/runner/work/graphia/graphia/source/shared/utils/flags.h:33:5: warning: single-argument constructors must be marked explicit to avoid unintentional implicit conversions [google-explicit-constructor] 33 | Flags(Enum value) : | ^ | explicit /home/runner/work/graphia/graphia/source/shared/utils/flags.h:38:5: warning: constructors that are callable with a single argument must be marked explicit to avoid unintentional implicit conversions [google-explicit-constructor] 38 | Flags(Enum value, Tail... values) | ^ | explicit 21622 warnings generated. [85/195] /home/runner/work/graphia/graphia/source/shared/commands/command.h:46:5: warning: single-argument constructors must be marked explicit to avoid unintentional implicit conversions [google-explicit-constructor] 46 | CommandFn(Fn&& fn) : | ^ | explicit /home/runner/work/graphia/graphia/source/shared/commands/command.h:46:20: warning: forwarding reference parameter 'fn' is never forwarded inside the function body [cppcoreguidelines-missing-std-forward] 46 | CommandFn(Fn&& fn) : | ^ /home/runner/work/graphia/graphia/source/shared/commands/command.h:51:5: warning: single-argument constructors must be marked explicit to avoid unintentional implicit conversions [google-explicit-constructor] 51 | CommandFn(Fn&& fn) : | ^ | explicit /home/runner/work/graphia/graphia/source/shared/commands/command.h:51:20: warning: forwarding reference parameter 'fn' is never forwarded inside the function body [cppcoreguidelines-missing-std-forward] 51 | CommandFn(Fn&& fn) : | ^ /home/runner/work/graphia/graphia/source/shared/commands/command.h:85:9: warning: constructors that are callable with a single argument must be marked explicit to avoid unintentional implicit conversions [google-explicit-constructor] 85 | CommandDescription(const QString& description = {}, | ^ | explicit /home/runner/work/graphia/graphia/source/shared/graph/elementid.h:35:5: warning: single-argument constructors must be marked explicit to avoid unintentional implicit conversions [google-explicit-constructor] 35 | ElementId(int value = NullValue) : | ^ | explicit /home/runner/work/graphia/graphia/source/shared/graph/grapharray.h:92:9: warning: initializer for member '_mutex' is redundant [readability-redundant-member-init] 92 | _mutex(), | ^~~~~~~~ /home/runner/work/graphia/graphia/source/shared/loading/userelementdata.h:114:16: warning: redundant get() call on smart pointer [readability-redundant-smartptr-get] 114 | return _indexes->get(elementId)._set; // readability-redundant-smartptr-get | ^~~~~~~~~~~~~~~~~~~~~~~ | _indexes /home/runner/work/graphia/graphia/source/shared/loading/userelementdata.h:119:16: warning: redundant get() call on smart pointer [readability-redundant-smartptr-get] 119 | return _indexes->get(elementId)._value; // readability-redundant-smartptr-get | ^~~~~~~~~~~~~~~~~~~~~~~ | _indexes /home/runner/work/graphia/graphia/source/shared/loading/userelementdata.h:345:9: warning: variable 'jsonAttributes' of type 'json' (aka 'basic_json<>') can be declared 'const' [misc-const-correctness] 345 | json jsonAttributes = json::object(); // misc-const-correctness | ^ | const /home/runner/work/graphia/graphia/source/shared/plugins/iplugin.h:101:9: warning: function-like macro 'IPluginIID' used; consider a 'constexpr' template function [cppcoreguidelines-macro-usage] 101 | #define IPluginIID(NAME) "app.graphia.IPlugin:" #NAME "/" VERSION // cppcoreguidelines-macro-usage | ^ /home/runner/work/graphia/graphia/source/shared/utils/flags.h:33:5: warning: single-argument constructors must be marked explicit to avoid unintentional implicit conversions [google-explicit-constructor] 33 | Flags(Enum value) : | ^ | explicit /home/runner/work/graphia/graphia/source/shared/utils/flags.h:38:5: warning: constructors that are callable with a single argument must be marked explicit to avoid unintentional implicit conversions [google-explicit-constructor] 38 | Flags(Enum value, Tail... values) | ^ | explicit 21675 warnings generated. [86/195] /home/runner/work/graphia/graphia/source/shared/graph/elementid.h:35:5: warning: single-argument constructors must be marked explicit to avoid unintentional implicit conversions [google-explicit-constructor] 35 | ElementId(int value = NullValue) : | ^ | explicit /home/runner/work/graphia/graphia/source/shared/graph/grapharray.h:92:9: warning: initializer for member '_mutex' is redundant [readability-redundant-member-init] 92 | _mutex(), | ^~~~~~~~ /home/runner/work/graphia/graphia/source/shared/loading/userelementdata.h:114:16: warning: redundant get() call on smart pointer [readability-redundant-smartptr-get] 114 | return _indexes->get(elementId)._set; // readability-redundant-smartptr-get | ^~~~~~~~~~~~~~~~~~~~~~~ | _indexes /home/runner/work/graphia/graphia/source/shared/loading/userelementdata.h:119:16: warning: redundant get() call on smart pointer [readability-redundant-smartptr-get] 119 | return _indexes->get(elementId)._value; // readability-redundant-smartptr-get | ^~~~~~~~~~~~~~~~~~~~~~~ | _indexes /home/runner/work/graphia/graphia/source/shared/loading/userelementdata.h:345:9: warning: variable 'jsonAttributes' of type 'json' (aka 'basic_json<>') can be declared 'const' [misc-const-correctness] 345 | json jsonAttributes = json::object(); // misc-const-correctness | ^ | const /home/runner/work/graphia/graphia/source/shared/utils/flags.h:33:5: warning: single-argument constructors must be marked explicit to avoid unintentional implicit conversions [google-explicit-constructor] 33 | Flags(Enum value) : | ^ | explicit /home/runner/work/graphia/graphia/source/shared/utils/flags.h:38:5: warning: constructors that are callable with a single argument must be marked explicit to avoid unintentional implicit conversions [google-explicit-constructor] 38 | Flags(Enum value, Tail... values) | ^ | explicit 19811 warnings generated. [87/195] /home/runner/work/graphia/graphia/source/shared/commands/command.h:46:5: warning: single-argument constructors must be marked explicit to avoid unintentional implicit conversions [google-explicit-constructor] 46 | CommandFn(Fn&& fn) : | ^ | explicit /home/runner/work/graphia/graphia/source/shared/commands/command.h:46:20: warning: forwarding reference parameter 'fn' is never forwarded inside the function body [cppcoreguidelines-missing-std-forward] 46 | CommandFn(Fn&& fn) : | ^ /home/runner/work/graphia/graphia/source/shared/commands/command.h:51:5: warning: single-argument constructors must be marked explicit to avoid unintentional implicit conversions [google-explicit-constructor] 51 | CommandFn(Fn&& fn) : | ^ | explicit /home/runner/work/graphia/graphia/source/shared/commands/command.h:51:20: warning: forwarding reference parameter 'fn' is never forwarded inside the function body [cppcoreguidelines-missing-std-forward] 51 | CommandFn(Fn&& fn) : | ^ /home/runner/work/graphia/graphia/source/shared/commands/command.h:85:9: warning: constructors that are callable with a single argument must be marked explicit to avoid unintentional implicit conversions [google-explicit-constructor] 85 | CommandDescription(const QString& description = {}, | ^ | explicit 10783 warnings generated. [88/195] /home/runner/work/graphia/graphia/source/shared/graph/elementid.h:35:5: warning: single-argument constructors must be marked explicit to avoid unintentional implicit conversions [google-explicit-constructor] 35 | ElementId(int value = NullValue) : | ^ | explicit /home/runner/work/graphia/graphia/source/shared/graph/grapharray.h:92:9: warning: initializer for member '_mutex' is redundant [readability-redundant-member-init] 92 | _mutex(), | ^~~~~~~~ /home/runner/work/graphia/graphia/source/shared/loading/userelementdata.h:114:16: warning: redundant get() call on smart pointer [readability-redundant-smartptr-get] 114 | return _indexes->get(elementId)._set; // readability-redundant-smartptr-get | ^~~~~~~~~~~~~~~~~~~~~~~ | _indexes /home/runner/work/graphia/graphia/source/shared/loading/userelementdata.h:119:16: warning: redundant get() call on smart pointer [readability-redundant-smartptr-get] 119 | return _indexes->get(elementId)._value; // readability-redundant-smartptr-get | ^~~~~~~~~~~~~~~~~~~~~~~ | _indexes /home/runner/work/graphia/graphia/source/shared/loading/userelementdata.h:345:9: warning: variable 'jsonAttributes' of type 'json' (aka 'basic_json<>') can be declared 'const' [misc-const-correctness] 345 | json jsonAttributes = json::object(); // misc-const-correctness | ^ | const /home/runner/work/graphia/graphia/source/shared/utils/flags.h:33:5: warning: single-argument constructors must be marked explicit to avoid unintentional implicit conversions [google-explicit-constructor] 33 | Flags(Enum value) : | ^ | explicit /home/runner/work/graphia/graphia/source/shared/utils/flags.h:38:5: warning: constructors that are callable with a single argument must be marked explicit to avoid unintentional implicit conversions [google-explicit-constructor] 38 | Flags(Enum value, Tail... values) | ^ | explicit 19496 warnings generated. [89/195] /home/runner/work/graphia/graphia/source/shared/graph/elementid.h:35:5: warning: single-argument constructors must be marked explicit to avoid unintentional implicit conversions [google-explicit-constructor] 35 | ElementId(int value = NullValue) : | ^ | explicit /home/runner/work/graphia/graphia/source/shared/graph/grapharray.h:92:9: warning: initializer for member '_mutex' is redundant [readability-redundant-member-init] 92 | _mutex(), | ^~~~~~~~ /home/runner/work/graphia/graphia/source/shared/loading/userelementdata.h:114:16: warning: redundant get() call on smart pointer [readability-redundant-smartptr-get] 114 | return _indexes->get(elementId)._set; // readability-redundant-smartptr-get | ^~~~~~~~~~~~~~~~~~~~~~~ | _indexes /home/runner/work/graphia/graphia/source/shared/loading/userelementdata.h:119:16: warning: redundant get() call on smart pointer [readability-redundant-smartptr-get] 119 | return _indexes->get(elementId)._value; // readability-redundant-smartptr-get | ^~~~~~~~~~~~~~~~~~~~~~~ | _indexes /home/runner/work/graphia/graphia/source/shared/loading/userelementdata.h:345:9: warning: variable 'jsonAttributes' of type 'json' (aka 'basic_json<>') can be declared 'const' [misc-const-correctness] 345 | json jsonAttributes = json::object(); // misc-const-correctness | ^ | const /home/runner/work/graphia/graphia/source/shared/utils/flags.h:33:5: warning: single-argument constructors must be marked explicit to avoid unintentional implicit conversions [google-explicit-constructor] 33 | Flags(Enum value) : | ^ | explicit /home/runner/work/graphia/graphia/source/shared/utils/flags.h:38:5: warning: constructors that are callable with a single argument must be marked explicit to avoid unintentional implicit conversions [google-explicit-constructor] 38 | Flags(Enum value, Tail... values) | ^ | explicit 19616 warnings generated. [90/195] /home/runner/work/graphia/graphia/source/shared/graph/elementid.h:35:5: warning: single-argument constructors must be marked explicit to avoid unintentional implicit conversions [google-explicit-constructor] 35 | ElementId(int value = NullValue) : | ^ | explicit /home/runner/work/graphia/graphia/source/shared/graph/grapharray.h:92:9: warning: initializer for member '_mutex' is redundant [readability-redundant-member-init] 92 | _mutex(), | ^~~~~~~~ /home/runner/work/graphia/graphia/source/shared/loading/userelementdata.h:114:16: warning: redundant get() call on smart pointer [readability-redundant-smartptr-get] 114 | return _indexes->get(elementId)._set; // readability-redundant-smartptr-get | ^~~~~~~~~~~~~~~~~~~~~~~ | _indexes /home/runner/work/graphia/graphia/source/shared/loading/userelementdata.h:119:16: warning: redundant get() call on smart pointer [readability-redundant-smartptr-get] 119 | return _indexes->get(elementId)._value; // readability-redundant-smartptr-get | ^~~~~~~~~~~~~~~~~~~~~~~ | _indexes /home/runner/work/graphia/graphia/source/shared/loading/userelementdata.h:345:9: warning: variable 'jsonAttributes' of type 'json' (aka 'basic_json<>') can be declared 'const' [misc-const-correctness] 345 | json jsonAttributes = json::object(); // misc-const-correctness | ^ | const /home/runner/work/graphia/graphia/source/shared/utils/flags.h:33:5: warning: single-argument constructors must be marked explicit to avoid unintentional implicit conversions [google-explicit-constructor] 33 | Flags(Enum value) : | ^ | explicit /home/runner/work/graphia/graphia/source/shared/utils/flags.h:38:5: warning: constructors that are callable with a single argument must be marked explicit to avoid unintentional implicit conversions [google-explicit-constructor] 38 | Flags(Enum value, Tail... values) | ^ | explicit 20477 warnings generated. [91/195] /home/runner/work/graphia/graphia/source/shared/graph/grapharray.h:92:9: warning: initializer for member '_mutex' is redundant [readability-redundant-member-init] 92 | _mutex(), | ^~~~~~~~ /home/runner/work/graphia/graphia/source/shared/loading/userelementdata.h:114:16: warning: redundant get() call on smart pointer [readability-redundant-smartptr-get] 114 | return _indexes->get(elementId)._set; // readability-redundant-smartptr-get | ^~~~~~~~~~~~~~~~~~~~~~~ | _indexes /home/runner/work/graphia/graphia/source/shared/loading/userelementdata.h:119:16: warning: redundant get() call on smart pointer [readability-redundant-smartptr-get] 119 | return _indexes->get(elementId)._value; // readability-redundant-smartptr-get | ^~~~~~~~~~~~~~~~~~~~~~~ | _indexes /home/runner/work/graphia/graphia/source/shared/loading/userelementdata.h:345:9: warning: variable 'jsonAttributes' of type 'json' (aka 'basic_json<>') can be declared 'const' [misc-const-correctness] 345 | json jsonAttributes = json::object(); // misc-const-correctness | ^ | const /home/runner/work/graphia/graphia/source/shared/utils/flags.h:33:5: warning: single-argument constructors must be marked explicit to avoid unintentional implicit conversions [google-explicit-constructor] 33 | Flags(Enum value) : | ^ | explicit /home/runner/work/graphia/graphia/source/shared/utils/flags.h:38:5: warning: constructors that are callable with a single argument must be marked explicit to avoid unintentional implicit conversions [google-explicit-constructor] 38 | Flags(Enum value, Tail... values) | ^ | explicit 19796 warnings generated. [92/195] /home/runner/work/graphia/graphia/source/shared/graph/elementid.h:35:5: warning: single-argument constructors must be marked explicit to avoid unintentional implicit conversions [google-explicit-constructor] 35 | ElementId(int value = NullValue) : | ^ | explicit /home/runner/work/graphia/graphia/source/shared/graph/grapharray.h:92:9: warning: initializer for member '_mutex' is redundant [readability-redundant-member-init] 92 | _mutex(), | ^~~~~~~~ 11515 warnings generated. [93/195] /home/runner/work/graphia/graphia/source/shared/graph/elementid.h:35:5: warning: single-argument constructors must be marked explicit to avoid unintentional implicit conversions [google-explicit-constructor] 35 | ElementId(int value = NullValue) : | ^ | explicit /home/runner/work/graphia/graphia/source/shared/graph/grapharray.h:92:9: warning: initializer for member '_mutex' is redundant [readability-redundant-member-init] 92 | _mutex(), | ^~~~~~~~ 10207 warnings generated. [94/195] /home/runner/work/graphia/graphia/source/shared/graph/elementid.h:35:5: warning: single-argument constructors must be marked explicit to avoid unintentional implicit conversions [google-explicit-constructor] 35 | ElementId(int value = NullValue) : | ^ | explicit /home/runner/work/graphia/graphia/source/shared/graph/grapharray.h:92:9: warning: initializer for member '_mutex' is redundant [readability-redundant-member-init] 92 | _mutex(), | ^~~~~~~~ 10489 warnings generated. [95/195] /home/runner/work/graphia/graphia/source/app/graph/graphmodel.cpp:285:5: warning: Call to virtual method 'GraphModel::createAttribute' during construction bypasses virtual dispatch [clang-analyzer-optin.cplusplus.VirtualCall] 285 | createAttribute(tr("Node Degree")) | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ /home/runner/work/graphia/graphia/source/app/graph/graphmodel.cpp:285:5: note: Call to virtual method 'GraphModel::createAttribute' during construction bypasses virtual dispatch 285 | createAttribute(tr("Node Degree")) | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ /home/runner/work/graphia/graphia/source/app/graph/graphmodel.cpp:293:9: warning: Call to virtual method 'GraphModel::createAttribute' during construction bypasses virtual dispatch [clang-analyzer-optin.cplusplus.VirtualCall] 293 | createAttribute(tr("Node In Degree")) | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ /home/runner/work/graphia/graphia/source/app/graph/graphmodel.cpp:290:8: note: Assuming the condition is true 290 | if(directed()) | ^~~~~~~~~~ /home/runner/work/graphia/graphia/source/app/graph/graphmodel.cpp:290:5: note: Taking true branch 290 | if(directed()) | ^ /home/runner/work/graphia/graphia/source/app/graph/graphmodel.cpp:293:9: note: Call to virtual method 'GraphModel::createAttribute' during construction bypasses virtual dispatch 293 | createAttribute(tr("Node In Degree")) | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ /home/runner/work/graphia/graphia/source/app/graph/graphmodel.cpp:299:9: warning: Call to virtual method 'GraphModel::createAttribute' during construction bypasses virtual dispatch [clang-analyzer-optin.cplusplus.VirtualCall] 299 | createAttribute(tr("Node Out Degree")) | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ /home/runner/work/graphia/graphia/source/app/graph/graphmodel.cpp:290:8: note: Assuming the condition is true 290 | if(directed()) | ^~~~~~~~~~ /home/runner/work/graphia/graphia/source/app/graph/graphmodel.cpp:290:5: note: Taking true branch 290 | if(directed()) | ^ /home/runner/work/graphia/graphia/source/app/graph/graphmodel.cpp:299:9: note: Call to virtual method 'GraphModel::createAttribute' during construction bypasses virtual dispatch 299 | createAttribute(tr("Node Out Degree")) | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ /home/runner/work/graphia/graphia/source/app/graph/graphmodel.cpp:306:5: warning: Call to virtual method 'GraphModel::createAttribute' during construction bypasses virtual dispatch [clang-analyzer-optin.cplusplus.VirtualCall] 306 | createAttribute(tr("Node Multiplicity")) | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ /home/runner/work/graphia/graphia/source/app/graph/graphmodel.cpp:290:8: note: Assuming the condition is false 290 | if(directed()) | ^~~~~~~~~~ /home/runner/work/graphia/graphia/source/app/graph/graphmodel.cpp:290:5: note: Taking false branch 290 | if(directed()) | ^ /home/runner/work/graphia/graphia/source/app/graph/graphmodel.cpp:306:5: note: Call to virtual method 'GraphModel::createAttribute' during construction bypasses virtual dispatch 306 | createAttribute(tr("Node Multiplicity")) | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ /home/runner/work/graphia/graphia/source/app/graph/graphmodel.cpp:312:5: warning: Call to virtual method 'GraphModel::createAttribute' during construction bypasses virtual dispatch [clang-analyzer-optin.cplusplus.VirtualCall] 312 | createAttribute(tr("Edge Multiplicity")) | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ /home/runner/work/graphia/graphia/source/app/graph/graphmodel.cpp:290:8: note: Assuming the condition is false 290 | if(directed()) | ^~~~~~~~~~ /home/runner/work/graphia/graphia/source/app/graph/graphmodel.cpp:290:5: note: Taking false branch 290 | if(directed()) | ^ /home/runner/work/graphia/graphia/source/app/graph/graphmodel.cpp:312:5: note: Call to virtual method 'GraphModel::createAttribute' during construction bypasses virtual dispatch 312 | createAttribute(tr("Edge Multiplicity")) | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ /home/runner/work/graphia/graphia/source/app/graph/graphmodel.cpp:318:5: warning: Call to virtual method 'GraphModel::createAttribute' during construction bypasses virtual dispatch [clang-analyzer-optin.cplusplus.VirtualCall] 318 | createAttribute(tr("Component Size")) | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ /home/runner/work/graphia/graphia/source/app/graph/graphmodel.cpp:290:8: note: Assuming the condition is false 290 | if(directed()) | ^~~~~~~~~~ /home/runner/work/graphia/graphia/source/app/graph/graphmodel.cpp:290:5: note: Taking false branch 290 | if(directed()) | ^ /home/runner/work/graphia/graphia/source/app/graph/graphmodel.cpp:318:5: note: Call to virtual method 'GraphModel::createAttribute' during construction bypasses virtual dispatch 318 | createAttribute(tr("Component Size")) | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ /home/runner/work/graphia/graphia/source/app/graph/graphmodel.cpp:324:5: warning: Call to virtual method 'GraphModel::createAttribute' during construction bypasses virtual dispatch [clang-analyzer-optin.cplusplus.VirtualCall] 324 | createAttribute(tr("Node Component Identifier")) | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ /home/runner/work/graphia/graphia/source/app/graph/graphmodel.cpp:290:8: note: Assuming the condition is false 290 | if(directed()) | ^~~~~~~~~~ /home/runner/work/graphia/graphia/source/app/graph/graphmodel.cpp:290:5: note: Taking false branch 290 | if(directed()) | ^ /home/runner/work/graphia/graphia/source/app/graph/graphmodel.cpp:324:5: note: Call to virtual method 'GraphModel::createAttribute' during construction bypasses virtual dispatch 324 | createAttribute(tr("Node Component Identifier")) | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ /home/runner/work/graphia/graphia/source/app/graph/graphmodel.cpp:333:5: warning: Call to virtual method 'GraphModel::createAttribute' during construction bypasses virtual dispatch [clang-analyzer-optin.cplusplus.VirtualCall] 333 | createAttribute(tr("Edge Component Identifier")) | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ /home/runner/work/graphia/graphia/source/app/graph/graphmodel.cpp:290:8: note: Assuming the condition is false 290 | if(directed()) | ^~~~~~~~~~ /home/runner/work/graphia/graphia/source/app/graph/graphmodel.cpp:290:5: note: Taking false branch 290 | if(directed()) | ^ /home/runner/work/graphia/graphia/source/app/graph/graphmodel.cpp:333:5: note: Call to virtual method 'GraphModel::createAttribute' during construction bypasses virtual dispatch 333 | createAttribute(tr("Edge Component Identifier")) | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ /home/runner/work/graphia/graphia/source/app/graph/graphmodel.cpp:378:13: warning: use '= default' to define a trivial destructor [modernize-use-equals-default] 378 | GraphModel::~GraphModel() | ^ /home/runner/work/graphia/graphia/source/shared/commands/command.h:46:5: warning: single-argument constructors must be marked explicit to avoid unintentional implicit conversions [google-explicit-constructor] 46 | CommandFn(Fn&& fn) : | ^ | explicit /home/runner/work/graphia/graphia/source/shared/commands/command.h:46:20: warning: forwarding reference parameter 'fn' is never forwarded inside the function body [cppcoreguidelines-missing-std-forward] 46 | CommandFn(Fn&& fn) : | ^ /home/runner/work/graphia/graphia/source/shared/commands/command.h:51:5: warning: single-argument constructors must be marked explicit to avoid unintentional implicit conversions [google-explicit-constructor] 51 | CommandFn(Fn&& fn) : | ^ | explicit /home/runner/work/graphia/graphia/source/shared/commands/command.h:51:20: warning: forwarding reference parameter 'fn' is never forwarded inside the function body [cppcoreguidelines-missing-std-forward] 51 | CommandFn(Fn&& fn) : | ^ /home/runner/work/graphia/graphia/source/shared/commands/command.h:85:9: warning: constructors that are callable with a single argument must be marked explicit to avoid unintentional implicit conversions [google-explicit-constructor] 85 | CommandDescription(const QString& description = {}, | ^ | explicit /home/runner/work/graphia/graphia/source/shared/graph/elementid.h:35:5: warning: single-argument constructors must be marked explicit to avoid unintentional implicit conversions [google-explicit-constructor] 35 | ElementId(int value = NullValue) : | ^ | explicit /home/runner/work/graphia/graphia/source/shared/graph/grapharray.h:92:9: warning: initializer for member '_mutex' is redundant [readability-redundant-member-init] 92 | _mutex(), | ^~~~~~~~ /home/runner/work/graphia/graphia/source/shared/loading/userelementdata.h:114:16: warning: redundant get() call on smart pointer [readability-redundant-smartptr-get] 114 | return _indexes->get(elementId)._set; // readability-redundant-smartptr-get | ^~~~~~~~~~~~~~~~~~~~~~~ | _indexes /home/runner/work/graphia/graphia/source/shared/loading/userelementdata.h:119:16: warning: redundant get() call on smart pointer [readability-redundant-smartptr-get] 119 | return _indexes->get(elementId)._value; // readability-redundant-smartptr-get | ^~~~~~~~~~~~~~~~~~~~~~~ | _indexes /home/runner/work/graphia/graphia/source/shared/loading/userelementdata.h:345:9: warning: variable 'jsonAttributes' of type 'json' (aka 'basic_json<>') can be declared 'const' [misc-const-correctness] 345 | json jsonAttributes = json::object(); // misc-const-correctness | ^ | const /home/runner/work/graphia/graphia/source/shared/plugins/iplugin.h:101:9: warning: function-like macro 'IPluginIID' used; consider a 'constexpr' template function [cppcoreguidelines-macro-usage] 101 | #define IPluginIID(NAME) "app.graphia.IPlugin:" #NAME "/" VERSION // cppcoreguidelines-macro-usage | ^ /home/runner/work/graphia/graphia/source/shared/utils/flags.h:33:5: warning: single-argument constructors must be marked explicit to avoid unintentional implicit conversions [google-explicit-constructor] 33 | Flags(Enum value) : | ^ | explicit /home/runner/work/graphia/graphia/source/shared/utils/flags.h:38:5: warning: constructors that are callable with a single argument must be marked explicit to avoid unintentional implicit conversions [google-explicit-constructor] 38 | Flags(Enum value, Tail... values) | ^ | explicit /home/runner/work/graphia/graphia/source/shared/utils/passkey.h:28:5: warning: use '= default' to define a trivial default constructor [modernize-use-equals-default] 28 | PassKey() {} | ^ ~~ | = default; /home/runner/work/graphia/graphia/source/shared/utils/passkey.h:29:5: warning: use '= default' to define a trivial copy constructor [modernize-use-equals-default] 29 | PassKey(PassKey const&) {} | ^ ~~ | = default; 27215 warnings generated. [96/195] /home/runner/work/graphia/graphia/source/shared/graph/elementid.h:35:5: warning: single-argument constructors must be marked explicit to avoid unintentional implicit conversions [google-explicit-constructor] 35 | ElementId(int value = NullValue) : | ^ | explicit /home/runner/work/graphia/graphia/source/shared/graph/grapharray.h:92:9: warning: initializer for member '_mutex' is redundant [readability-redundant-member-init] 92 | _mutex(), | ^~~~~~~~ 10172 warnings generated. [97/195] /home/runner/work/graphia/graphia/source/app/headless.cpp:73:11: warning: use '= default' to define a trivial destructor [modernize-use-equals-default] 73 | Headless::~Headless() | ^ /home/runner/work/graphia/graphia/source/shared/commands/command.h:46:5: warning: single-argument constructors must be marked explicit to avoid unintentional implicit conversions [google-explicit-constructor] 46 | CommandFn(Fn&& fn) : | ^ | explicit /home/runner/work/graphia/graphia/source/shared/commands/command.h:46:20: warning: forwarding reference parameter 'fn' is never forwarded inside the function body [cppcoreguidelines-missing-std-forward] 46 | CommandFn(Fn&& fn) : | ^ /home/runner/work/graphia/graphia/source/shared/commands/command.h:51:5: warning: single-argument constructors must be marked explicit to avoid unintentional implicit conversions [google-explicit-constructor] 51 | CommandFn(Fn&& fn) : | ^ | explicit /home/runner/work/graphia/graphia/source/shared/commands/command.h:51:20: warning: forwarding reference parameter 'fn' is never forwarded inside the function body [cppcoreguidelines-missing-std-forward] 51 | CommandFn(Fn&& fn) : | ^ /home/runner/work/graphia/graphia/source/shared/commands/command.h:85:9: warning: constructors that are callable with a single argument must be marked explicit to avoid unintentional implicit conversions [google-explicit-constructor] 85 | CommandDescription(const QString& description = {}, | ^ | explicit /home/runner/work/graphia/graphia/source/shared/graph/elementid.h:35:5: warning: single-argument constructors must be marked explicit to avoid unintentional implicit conversions [google-explicit-constructor] 35 | ElementId(int value = NullValue) : | ^ | explicit /home/runner/work/graphia/graphia/source/shared/graph/grapharray.h:92:9: warning: initializer for member '_mutex' is redundant [readability-redundant-member-init] 92 | _mutex(), | ^~~~~~~~ /home/runner/work/graphia/graphia/source/shared/plugins/iplugin.h:101:9: warning: function-like macro 'IPluginIID' used; consider a 'constexpr' template function [cppcoreguidelines-macro-usage] 101 | #define IPluginIID(NAME) "app.graphia.IPlugin:" #NAME "/" VERSION // cppcoreguidelines-macro-usage | ^ /home/runner/work/graphia/graphia/source/shared/utils/flags.h:33:5: warning: single-argument constructors must be marked explicit to avoid unintentional implicit conversions [google-explicit-constructor] 33 | Flags(Enum value) : | ^ | explicit /home/runner/work/graphia/graphia/source/shared/utils/flags.h:38:5: warning: constructors that are callable with a single argument must be marked explicit to avoid unintentional implicit conversions [google-explicit-constructor] 38 | Flags(Enum value, Tail... values) | ^ | explicit 19830 warnings generated. [98/195] /home/runner/work/graphia/graphia/source/shared/graph/elementid.h:35:5: warning: single-argument constructors must be marked explicit to avoid unintentional implicit conversions [google-explicit-constructor] 35 | ElementId(int value = NullValue) : | ^ | explicit /home/runner/work/graphia/graphia/source/shared/graph/grapharray.h:92:9: warning: initializer for member '_mutex' is redundant [readability-redundant-member-init] 92 | _mutex(), | ^~~~~~~~ 10625 warnings generated. [99/195] /home/runner/work/graphia/graphia/source/shared/graph/elementid.h:35:5: warning: single-argument constructors must be marked explicit to avoid unintentional implicit conversions [google-explicit-constructor] 35 | ElementId(int value = NullValue) : | ^ | explicit /home/runner/work/graphia/graphia/source/shared/graph/grapharray.h:92:9: warning: initializer for member '_mutex' is redundant [readability-redundant-member-init] 92 | _mutex(), | ^~~~~~~~ 10593 warnings generated. [100/195] /home/runner/work/graphia/graphia/source/shared/graph/elementid.h:35:5: warning: single-argument constructors must be marked explicit to avoid unintentional implicit conversions [google-explicit-constructor] 35 | ElementId(int value = NullValue) : | ^ | explicit /home/runner/work/graphia/graphia/source/shared/graph/grapharray.h:92:9: warning: initializer for member '_mutex' is redundant [readability-redundant-member-init] 92 | _mutex(), | ^~~~~~~~ /home/runner/work/graphia/graphia/source/shared/loading/userelementdata.h:114:16: warning: redundant get() call on smart pointer [readability-redundant-smartptr-get] 114 | return _indexes->get(elementId)._set; // readability-redundant-smartptr-get | ^~~~~~~~~~~~~~~~~~~~~~~ | _indexes /home/runner/work/graphia/graphia/source/shared/loading/userelementdata.h:119:16: warning: redundant get() call on smart pointer [readability-redundant-smartptr-get] 119 | return _indexes->get(elementId)._value; // readability-redundant-smartptr-get | ^~~~~~~~~~~~~~~~~~~~~~~ | _indexes /home/runner/work/graphia/graphia/source/shared/loading/userelementdata.h:345:9: warning: variable 'jsonAttributes' of type 'json' (aka 'basic_json<>') can be declared 'const' [misc-const-correctness] 345 | json jsonAttributes = json::object(); // misc-const-correctness | ^ | const /home/runner/work/graphia/graphia/source/shared/utils/flags.h:33:5: warning: single-argument constructors must be marked explicit to avoid unintentional implicit conversions [google-explicit-constructor] 33 | Flags(Enum value) : | ^ | explicit /home/runner/work/graphia/graphia/source/shared/utils/flags.h:38:5: warning: constructors that are callable with a single argument must be marked explicit to avoid unintentional implicit conversions [google-explicit-constructor] 38 | Flags(Enum value, Tail... values) | ^ | explicit 20452 warnings generated. [101/195] /home/runner/work/graphia/graphia/source/shared/graph/elementid.h:35:5: warning: single-argument constructors must be marked explicit to avoid unintentional implicit conversions [google-explicit-constructor] 35 | ElementId(int value = NullValue) : | ^ | explicit /home/runner/work/graphia/graphia/source/shared/graph/grapharray.h:92:9: warning: initializer for member '_mutex' is redundant [readability-redundant-member-init] 92 | _mutex(), | ^~~~~~~~ 9763 warnings generated. [102/195] /home/runner/work/graphia/graphia/source/shared/graph/elementid.h:35:5: warning: single-argument constructors must be marked explicit to avoid unintentional implicit conversions [google-explicit-constructor] 35 | ElementId(int value = NullValue) : | ^ | explicit /home/runner/work/graphia/graphia/source/shared/graph/grapharray.h:92:9: warning: initializer for member '_mutex' is redundant [readability-redundant-member-init] 92 | _mutex(), | ^~~~~~~~ 11247 warnings generated. [103/195] /home/runner/work/graphia/graphia/source/shared/graph/elementid.h:35:5: warning: single-argument constructors must be marked explicit to avoid unintentional implicit conversions [google-explicit-constructor] 35 | ElementId(int value = NullValue) : | ^ | explicit /home/runner/work/graphia/graphia/source/shared/graph/grapharray.h:92:9: warning: initializer for member '_mutex' is redundant [readability-redundant-member-init] 92 | _mutex(), | ^~~~~~~~ /home/runner/work/graphia/graphia/source/shared/loading/userelementdata.h:114:16: warning: redundant get() call on smart pointer [readability-redundant-smartptr-get] 114 | return _indexes->get(elementId)._set; // readability-redundant-smartptr-get | ^~~~~~~~~~~~~~~~~~~~~~~ | _indexes /home/runner/work/graphia/graphia/source/shared/loading/userelementdata.h:119:16: warning: redundant get() call on smart pointer [readability-redundant-smartptr-get] 119 | return _indexes->get(elementId)._value; // readability-redundant-smartptr-get | ^~~~~~~~~~~~~~~~~~~~~~~ | _indexes /home/runner/work/graphia/graphia/source/shared/loading/userelementdata.h:345:9: warning: variable 'jsonAttributes' of type 'json' (aka 'basic_json<>') can be declared 'const' [misc-const-correctness] 345 | json jsonAttributes = json::object(); // misc-const-correctness | ^ | const /home/runner/work/graphia/graphia/source/shared/utils/flags.h:33:5: warning: single-argument constructors must be marked explicit to avoid unintentional implicit conversions [google-explicit-constructor] 33 | Flags(Enum value) : | ^ | explicit /home/runner/work/graphia/graphia/source/shared/utils/flags.h:38:5: warning: constructors that are callable with a single argument must be marked explicit to avoid unintentional implicit conversions [google-explicit-constructor] 38 | Flags(Enum value, Tail... values) | ^ | explicit /home/runner/work/graphia/graphia/source/shared/utils/is_detected.h:24:1: warning: nested namespaces can be concatenated [modernize-concat-nested-namespaces] 24 | namespace std{ | ^~~~~~~~~~~~~~ 25 | namespace experimental{ | ~~~~~~~~~~~~~~~~~~~~~~ | namespace std::experimental /home/runner/work/graphia/graphia/source/shared/utils/is_detected.h:25:11: warning: modification of 'std' namespace can result in undefined behavior [cert-dcl58-cpp] 25 | namespace experimental{ | ^ /home/runner/work/graphia/graphia/source/shared/utils/is_detected.h:24:11: note: 'std' namespace opened here 24 | namespace std{ | ^ /home/runner/work/graphia/graphia/source/shared/utils/threadpool.h:66:109: warning: forwarding reference parameter 'args' is never forwarded inside the function body [cppcoreguidelines-missing-std-forward] 66 | template std::future> makeFuture(Fn f, Args&&... args) | ^ 22040 warnings generated. [104/195] /home/runner/work/graphia/graphia/source/shared/graph/elementid.h:35:5: warning: single-argument constructors must be marked explicit to avoid unintentional implicit conversions [google-explicit-constructor] 35 | ElementId(int value = NullValue) : | ^ | explicit /home/runner/work/graphia/graphia/source/shared/graph/grapharray.h:92:9: warning: initializer for member '_mutex' is redundant [readability-redundant-member-init] 92 | _mutex(), | ^~~~~~~~ /home/runner/work/graphia/graphia/source/shared/loading/userelementdata.h:114:16: warning: redundant get() call on smart pointer [readability-redundant-smartptr-get] 114 | return _indexes->get(elementId)._set; // readability-redundant-smartptr-get | ^~~~~~~~~~~~~~~~~~~~~~~ | _indexes /home/runner/work/graphia/graphia/source/shared/loading/userelementdata.h:119:16: warning: redundant get() call on smart pointer [readability-redundant-smartptr-get] 119 | return _indexes->get(elementId)._value; // readability-redundant-smartptr-get | ^~~~~~~~~~~~~~~~~~~~~~~ | _indexes /home/runner/work/graphia/graphia/source/shared/loading/userelementdata.h:345:9: warning: variable 'jsonAttributes' of type 'json' (aka 'basic_json<>') can be declared 'const' [misc-const-correctness] 345 | json jsonAttributes = json::object(); // misc-const-correctness | ^ | const /home/runner/work/graphia/graphia/source/shared/utils/flags.h:33:5: warning: single-argument constructors must be marked explicit to avoid unintentional implicit conversions [google-explicit-constructor] 33 | Flags(Enum value) : | ^ | explicit /home/runner/work/graphia/graphia/source/shared/utils/flags.h:38:5: warning: constructors that are callable with a single argument must be marked explicit to avoid unintentional implicit conversions [google-explicit-constructor] 38 | Flags(Enum value, Tail... values) | ^ | explicit 20706 warnings generated. [105/195] 9718 warnings generated. [106/195] /home/runner/work/graphia/graphia/source/shared/graph/elementid.h:35:5: warning: single-argument constructors must be marked explicit to avoid unintentional implicit conversions [google-explicit-constructor] 35 | ElementId(int value = NullValue) : | ^ | explicit /home/runner/work/graphia/graphia/source/shared/graph/grapharray.h:92:9: warning: initializer for member '_mutex' is redundant [readability-redundant-member-init] 92 | _mutex(), | ^~~~~~~~ 7738 warnings generated. [107/195] /home/runner/work/graphia/graphia/source/shared/graph/elementid.h:35:5: warning: single-argument constructors must be marked explicit to avoid unintentional implicit conversions [google-explicit-constructor] 35 | ElementId(int value = NullValue) : | ^ | explicit /home/runner/work/graphia/graphia/source/shared/graph/grapharray.h:92:9: warning: initializer for member '_mutex' is redundant [readability-redundant-member-init] 92 | _mutex(), | ^~~~~~~~ 10109 warnings generated. [108/195] /home/runner/work/graphia/graphia/source/shared/graph/elementid.h:35:5: warning: single-argument constructors must be marked explicit to avoid unintentional implicit conversions [google-explicit-constructor] 35 | ElementId(int value = NullValue) : | ^ | explicit /home/runner/work/graphia/graphia/source/shared/graph/grapharray.h:92:9: warning: initializer for member '_mutex' is redundant [readability-redundant-member-init] 92 | _mutex(), | ^~~~~~~~ 10691 warnings generated. [109/195] /home/runner/work/graphia/graphia/source/shared/graph/elementid.h:35:5: warning: single-argument constructors must be marked explicit to avoid unintentional implicit conversions [google-explicit-constructor] 35 | ElementId(int value = NullValue) : | ^ | explicit /home/runner/work/graphia/graphia/source/shared/graph/grapharray.h:92:9: warning: initializer for member '_mutex' is redundant [readability-redundant-member-init] 92 | _mutex(), | ^~~~~~~~ 10625 warnings generated. [110/195] 10368 warnings generated. [111/195] /home/runner/work/graphia/graphia/source/shared/commands/command.h:46:5: warning: single-argument constructors must be marked explicit to avoid unintentional implicit conversions [google-explicit-constructor] 46 | CommandFn(Fn&& fn) : | ^ | explicit /home/runner/work/graphia/graphia/source/shared/commands/command.h:46:20: warning: forwarding reference parameter 'fn' is never forwarded inside the function body [cppcoreguidelines-missing-std-forward] 46 | CommandFn(Fn&& fn) : | ^ /home/runner/work/graphia/graphia/source/shared/commands/command.h:51:5: warning: single-argument constructors must be marked explicit to avoid unintentional implicit conversions [google-explicit-constructor] 51 | CommandFn(Fn&& fn) : | ^ | explicit /home/runner/work/graphia/graphia/source/shared/commands/command.h:51:20: warning: forwarding reference parameter 'fn' is never forwarded inside the function body [cppcoreguidelines-missing-std-forward] 51 | CommandFn(Fn&& fn) : | ^ /home/runner/work/graphia/graphia/source/shared/commands/command.h:85:9: warning: constructors that are callable with a single argument must be marked explicit to avoid unintentional implicit conversions [google-explicit-constructor] 85 | CommandDescription(const QString& description = {}, | ^ | explicit /home/runner/work/graphia/graphia/source/shared/graph/elementid.h:35:5: warning: single-argument constructors must be marked explicit to avoid unintentional implicit conversions [google-explicit-constructor] 35 | ElementId(int value = NullValue) : | ^ | explicit /home/runner/work/graphia/graphia/source/shared/graph/grapharray.h:92:9: warning: initializer for member '_mutex' is redundant [readability-redundant-member-init] 92 | _mutex(), | ^~~~~~~~ /home/runner/work/graphia/graphia/source/shared/loading/userelementdata.h:114:16: warning: redundant get() call on smart pointer [readability-redundant-smartptr-get] 114 | return _indexes->get(elementId)._set; // readability-redundant-smartptr-get | ^~~~~~~~~~~~~~~~~~~~~~~ | _indexes /home/runner/work/graphia/graphia/source/shared/loading/userelementdata.h:119:16: warning: redundant get() call on smart pointer [readability-redundant-smartptr-get] 119 | return _indexes->get(elementId)._value; // readability-redundant-smartptr-get | ^~~~~~~~~~~~~~~~~~~~~~~ | _indexes /home/runner/work/graphia/graphia/source/shared/loading/userelementdata.h:345:9: warning: variable 'jsonAttributes' of type 'json' (aka 'basic_json<>') can be declared 'const' [misc-const-correctness] 345 | json jsonAttributes = json::object(); // misc-const-correctness | ^ | const /home/runner/work/graphia/graphia/source/shared/plugins/iplugin.h:101:9: warning: function-like macro 'IPluginIID' used; consider a 'constexpr' template function [cppcoreguidelines-macro-usage] 101 | #define IPluginIID(NAME) "app.graphia.IPlugin:" #NAME "/" VERSION // cppcoreguidelines-macro-usage | ^ /home/runner/work/graphia/graphia/source/shared/utils/flags.h:33:5: warning: single-argument constructors must be marked explicit to avoid unintentional implicit conversions [google-explicit-constructor] 33 | Flags(Enum value) : | ^ | explicit /home/runner/work/graphia/graphia/source/shared/utils/flags.h:38:5: warning: constructors that are callable with a single argument must be marked explicit to avoid unintentional implicit conversions [google-explicit-constructor] 38 | Flags(Enum value, Tail... values) | ^ | explicit 21887 warnings generated. [112/195] /home/runner/work/graphia/graphia/source/shared/commands/command.h:46:5: warning: single-argument constructors must be marked explicit to avoid unintentional implicit conversions [google-explicit-constructor] 46 | CommandFn(Fn&& fn) : | ^ | explicit /home/runner/work/graphia/graphia/source/shared/commands/command.h:46:20: warning: forwarding reference parameter 'fn' is never forwarded inside the function body [cppcoreguidelines-missing-std-forward] 46 | CommandFn(Fn&& fn) : | ^ /home/runner/work/graphia/graphia/source/shared/commands/command.h:51:5: warning: single-argument constructors must be marked explicit to avoid unintentional implicit conversions [google-explicit-constructor] 51 | CommandFn(Fn&& fn) : | ^ | explicit /home/runner/work/graphia/graphia/source/shared/commands/command.h:51:20: warning: forwarding reference parameter 'fn' is never forwarded inside the function body [cppcoreguidelines-missing-std-forward] 51 | CommandFn(Fn&& fn) : | ^ /home/runner/work/graphia/graphia/source/shared/commands/command.h:85:9: warning: constructors that are callable with a single argument must be marked explicit to avoid unintentional implicit conversions [google-explicit-constructor] 85 | CommandDescription(const QString& description = {}, | ^ | explicit /home/runner/work/graphia/graphia/source/shared/graph/elementid.h:35:5: warning: single-argument constructors must be marked explicit to avoid unintentional implicit conversions [google-explicit-constructor] 35 | ElementId(int value = NullValue) : | ^ | explicit /home/runner/work/graphia/graphia/source/shared/graph/grapharray.h:92:9: warning: initializer for member '_mutex' is redundant [readability-redundant-member-init] 92 | _mutex(), | ^~~~~~~~ /home/runner/work/graphia/graphia/source/shared/loading/userelementdata.h:114:16: warning: redundant get() call on smart pointer [readability-redundant-smartptr-get] 114 | return _indexes->get(elementId)._set; // readability-redundant-smartptr-get | ^~~~~~~~~~~~~~~~~~~~~~~ | _indexes /home/runner/work/graphia/graphia/source/shared/loading/userelementdata.h:119:16: warning: redundant get() call on smart pointer [readability-redundant-smartptr-get] 119 | return _indexes->get(elementId)._value; // readability-redundant-smartptr-get | ^~~~~~~~~~~~~~~~~~~~~~~ | _indexes /home/runner/work/graphia/graphia/source/shared/loading/userelementdata.h:345:9: warning: variable 'jsonAttributes' of type 'json' (aka 'basic_json<>') can be declared 'const' [misc-const-correctness] 345 | json jsonAttributes = json::object(); // misc-const-correctness | ^ | const /home/runner/work/graphia/graphia/source/shared/plugins/iplugin.h:101:9: warning: function-like macro 'IPluginIID' used; consider a 'constexpr' template function [cppcoreguidelines-macro-usage] 101 | #define IPluginIID(NAME) "app.graphia.IPlugin:" #NAME "/" VERSION // cppcoreguidelines-macro-usage | ^ /home/runner/work/graphia/graphia/source/shared/utils/flags.h:33:5: warning: single-argument constructors must be marked explicit to avoid unintentional implicit conversions [google-explicit-constructor] 33 | Flags(Enum value) : | ^ | explicit /home/runner/work/graphia/graphia/source/shared/utils/flags.h:38:5: warning: constructors that are callable with a single argument must be marked explicit to avoid unintentional implicit conversions [google-explicit-constructor] 38 | Flags(Enum value, Tail... values) | ^ | explicit 21981 warnings generated. [113/195] /home/runner/work/graphia/graphia/source/shared/commands/command.h:46:5: warning: single-argument constructors must be marked explicit to avoid unintentional implicit conversions [google-explicit-constructor] 46 | CommandFn(Fn&& fn) : | ^ | explicit /home/runner/work/graphia/graphia/source/shared/commands/command.h:46:20: warning: forwarding reference parameter 'fn' is never forwarded inside the function body [cppcoreguidelines-missing-std-forward] 46 | CommandFn(Fn&& fn) : | ^ /home/runner/work/graphia/graphia/source/shared/commands/command.h:51:5: warning: single-argument constructors must be marked explicit to avoid unintentional implicit conversions [google-explicit-constructor] 51 | CommandFn(Fn&& fn) : | ^ | explicit /home/runner/work/graphia/graphia/source/shared/commands/command.h:51:20: warning: forwarding reference parameter 'fn' is never forwarded inside the function body [cppcoreguidelines-missing-std-forward] 51 | CommandFn(Fn&& fn) : | ^ /home/runner/work/graphia/graphia/source/shared/commands/command.h:85:9: warning: constructors that are callable with a single argument must be marked explicit to avoid unintentional implicit conversions [google-explicit-constructor] 85 | CommandDescription(const QString& description = {}, | ^ | explicit /home/runner/work/graphia/graphia/source/shared/graph/elementid.h:35:5: warning: single-argument constructors must be marked explicit to avoid unintentional implicit conversions [google-explicit-constructor] 35 | ElementId(int value = NullValue) : | ^ | explicit /home/runner/work/graphia/graphia/source/shared/graph/grapharray.h:92:9: warning: initializer for member '_mutex' is redundant [readability-redundant-member-init] 92 | _mutex(), | ^~~~~~~~ /home/runner/work/graphia/graphia/source/shared/plugins/iplugin.h:101:9: warning: function-like macro 'IPluginIID' used; consider a 'constexpr' template function [cppcoreguidelines-macro-usage] 101 | #define IPluginIID(NAME) "app.graphia.IPlugin:" #NAME "/" VERSION // cppcoreguidelines-macro-usage | ^ /home/runner/work/graphia/graphia/source/shared/utils/flags.h:33:5: warning: single-argument constructors must be marked explicit to avoid unintentional implicit conversions [google-explicit-constructor] 33 | Flags(Enum value) : | ^ | explicit /home/runner/work/graphia/graphia/source/shared/utils/flags.h:38:5: warning: constructors that are callable with a single argument must be marked explicit to avoid unintentional implicit conversions [google-explicit-constructor] 38 | Flags(Enum value, Tail... values) | ^ | explicit 14524 warnings generated. [114/195] /home/runner/work/graphia/graphia/source/shared/commands/command.h:46:5: warning: single-argument constructors must be marked explicit to avoid unintentional implicit conversions [google-explicit-constructor] 46 | CommandFn(Fn&& fn) : | ^ | explicit /home/runner/work/graphia/graphia/source/shared/commands/command.h:46:20: warning: forwarding reference parameter 'fn' is never forwarded inside the function body [cppcoreguidelines-missing-std-forward] 46 | CommandFn(Fn&& fn) : | ^ /home/runner/work/graphia/graphia/source/shared/commands/command.h:51:5: warning: single-argument constructors must be marked explicit to avoid unintentional implicit conversions [google-explicit-constructor] 51 | CommandFn(Fn&& fn) : | ^ | explicit /home/runner/work/graphia/graphia/source/shared/commands/command.h:51:20: warning: forwarding reference parameter 'fn' is never forwarded inside the function body [cppcoreguidelines-missing-std-forward] 51 | CommandFn(Fn&& fn) : | ^ /home/runner/work/graphia/graphia/source/shared/commands/command.h:85:9: warning: constructors that are callable with a single argument must be marked explicit to avoid unintentional implicit conversions [google-explicit-constructor] 85 | CommandDescription(const QString& description = {}, | ^ | explicit /home/runner/work/graphia/graphia/source/shared/graph/grapharray.h:92:9: warning: initializer for member '_mutex' is redundant [readability-redundant-member-init] 92 | _mutex(), | ^~~~~~~~ /home/runner/work/graphia/graphia/source/shared/loading/userelementdata.h:114:16: warning: redundant get() call on smart pointer [readability-redundant-smartptr-get] 114 | return _indexes->get(elementId)._set; // readability-redundant-smartptr-get | ^~~~~~~~~~~~~~~~~~~~~~~ | _indexes /home/runner/work/graphia/graphia/source/shared/loading/userelementdata.h:119:16: warning: redundant get() call on smart pointer [readability-redundant-smartptr-get] 119 | return _indexes->get(elementId)._value; // readability-redundant-smartptr-get | ^~~~~~~~~~~~~~~~~~~~~~~ | _indexes /home/runner/work/graphia/graphia/source/shared/loading/userelementdata.h:345:9: warning: variable 'jsonAttributes' of type 'json' (aka 'basic_json<>') can be declared 'const' [misc-const-correctness] 345 | json jsonAttributes = json::object(); // misc-const-correctness | ^ | const /home/runner/work/graphia/graphia/source/shared/plugins/iplugin.h:101:9: warning: function-like macro 'IPluginIID' used; consider a 'constexpr' template function [cppcoreguidelines-macro-usage] 101 | #define IPluginIID(NAME) "app.graphia.IPlugin:" #NAME "/" VERSION // cppcoreguidelines-macro-usage | ^ /home/runner/work/graphia/graphia/source/shared/utils/flags.h:33:5: warning: single-argument constructors must be marked explicit to avoid unintentional implicit conversions [google-explicit-constructor] 33 | Flags(Enum value) : | ^ | explicit /home/runner/work/graphia/graphia/source/shared/utils/flags.h:38:5: warning: constructors that are callable with a single argument must be marked explicit to avoid unintentional implicit conversions [google-explicit-constructor] 38 | Flags(Enum value, Tail... values) | ^ | explicit 22157 warnings generated. [115/195] /home/runner/work/graphia/graphia/source/shared/commands/command.h:46:5: warning: single-argument constructors must be marked explicit to avoid unintentional implicit conversions [google-explicit-constructor] 46 | CommandFn(Fn&& fn) : | ^ | explicit /home/runner/work/graphia/graphia/source/shared/commands/command.h:46:20: warning: forwarding reference parameter 'fn' is never forwarded inside the function body [cppcoreguidelines-missing-std-forward] 46 | CommandFn(Fn&& fn) : | ^ /home/runner/work/graphia/graphia/source/shared/commands/command.h:51:5: warning: single-argument constructors must be marked explicit to avoid unintentional implicit conversions [google-explicit-constructor] 51 | CommandFn(Fn&& fn) : | ^ | explicit /home/runner/work/graphia/graphia/source/shared/commands/command.h:51:20: warning: forwarding reference parameter 'fn' is never forwarded inside the function body [cppcoreguidelines-missing-std-forward] 51 | CommandFn(Fn&& fn) : | ^ /home/runner/work/graphia/graphia/source/shared/commands/command.h:85:9: warning: constructors that are callable with a single argument must be marked explicit to avoid unintentional implicit conversions [google-explicit-constructor] 85 | CommandDescription(const QString& description = {}, | ^ | explicit /home/runner/work/graphia/graphia/source/shared/graph/elementid.h:35:5: warning: single-argument constructors must be marked explicit to avoid unintentional implicit conversions [google-explicit-constructor] 35 | ElementId(int value = NullValue) : | ^ | explicit /home/runner/work/graphia/graphia/source/shared/graph/grapharray.h:92:9: warning: initializer for member '_mutex' is redundant [readability-redundant-member-init] 92 | _mutex(), | ^~~~~~~~ /home/runner/work/graphia/graphia/source/shared/loading/userelementdata.h:114:16: warning: redundant get() call on smart pointer [readability-redundant-smartptr-get] 114 | return _indexes->get(elementId)._set; // readability-redundant-smartptr-get | ^~~~~~~~~~~~~~~~~~~~~~~ | _indexes /home/runner/work/graphia/graphia/source/shared/loading/userelementdata.h:119:16: warning: redundant get() call on smart pointer [readability-redundant-smartptr-get] 119 | return _indexes->get(elementId)._value; // readability-redundant-smartptr-get | ^~~~~~~~~~~~~~~~~~~~~~~ | _indexes /home/runner/work/graphia/graphia/source/shared/loading/userelementdata.h:345:9: warning: variable 'jsonAttributes' of type 'json' (aka 'basic_json<>') can be declared 'const' [misc-const-correctness] 345 | json jsonAttributes = json::object(); // misc-const-correctness | ^ | const /home/runner/work/graphia/graphia/source/shared/plugins/iplugin.h:101:9: warning: function-like macro 'IPluginIID' used; consider a 'constexpr' template function [cppcoreguidelines-macro-usage] 101 | #define IPluginIID(NAME) "app.graphia.IPlugin:" #NAME "/" VERSION // cppcoreguidelines-macro-usage | ^ /home/runner/work/graphia/graphia/source/shared/utils/flags.h:33:5: warning: single-argument constructors must be marked explicit to avoid unintentional implicit conversions [google-explicit-constructor] 33 | Flags(Enum value) : | ^ | explicit /home/runner/work/graphia/graphia/source/shared/utils/flags.h:38:5: warning: constructors that are callable with a single argument must be marked explicit to avoid unintentional implicit conversions [google-explicit-constructor] 38 | Flags(Enum value, Tail... values) | ^ | explicit /home/runner/work/graphia/graphia/source/shared/utils/scope_exit.h:27:1: warning: nested namespaces can be concatenated [modernize-concat-nested-namespaces] 27 | namespace std{ | ^~~~~~~~~~~~~~ 28 | namespace experimental{ | ~~~~~~~~~~~~~~~~~~~~~~ | namespace std::experimental /home/runner/work/graphia/graphia/source/shared/utils/scope_exit.h:28:11: warning: modification of 'std' namespace can result in undefined behavior [cert-dcl58-cpp] 28 | namespace experimental{ | ^ /home/runner/work/graphia/graphia/source/shared/utils/scope_exit.h:27:11: note: 'std' namespace opened here 27 | namespace std{ | ^ 22484 warnings generated. [116/195] /home/runner/work/graphia/graphia/source/shared/graph/elementid.h:35:5: warning: single-argument constructors must be marked explicit to avoid unintentional implicit conversions [google-explicit-constructor] 35 | ElementId(int value = NullValue) : | ^ | explicit /home/runner/work/graphia/graphia/source/shared/graph/grapharray.h:92:9: warning: initializer for member '_mutex' is redundant [readability-redundant-member-init] 92 | _mutex(), | ^~~~~~~~ /home/runner/work/graphia/graphia/source/shared/loading/userelementdata.h:114:16: warning: redundant get() call on smart pointer [readability-redundant-smartptr-get] 114 | return _indexes->get(elementId)._set; // readability-redundant-smartptr-get | ^~~~~~~~~~~~~~~~~~~~~~~ | _indexes /home/runner/work/graphia/graphia/source/shared/loading/userelementdata.h:119:16: warning: redundant get() call on smart pointer [readability-redundant-smartptr-get] 119 | return _indexes->get(elementId)._value; // readability-redundant-smartptr-get | ^~~~~~~~~~~~~~~~~~~~~~~ | _indexes /home/runner/work/graphia/graphia/source/shared/loading/userelementdata.h:345:9: warning: variable 'jsonAttributes' of type 'json' (aka 'basic_json<>') can be declared 'const' [misc-const-correctness] 345 | json jsonAttributes = json::object(); // misc-const-correctness | ^ | const /home/runner/work/graphia/graphia/source/shared/utils/flags.h:33:5: warning: single-argument constructors must be marked explicit to avoid unintentional implicit conversions [google-explicit-constructor] 33 | Flags(Enum value) : | ^ | explicit /home/runner/work/graphia/graphia/source/shared/utils/flags.h:38:5: warning: constructors that are callable with a single argument must be marked explicit to avoid unintentional implicit conversions [google-explicit-constructor] 38 | Flags(Enum value, Tail... values) | ^ | explicit 19826 warnings generated. [117/195] /home/runner/work/graphia/graphia/source/shared/commands/command.h:46:5: warning: single-argument constructors must be marked explicit to avoid unintentional implicit conversions [google-explicit-constructor] 46 | CommandFn(Fn&& fn) : | ^ | explicit /home/runner/work/graphia/graphia/source/shared/commands/command.h:46:20: warning: forwarding reference parameter 'fn' is never forwarded inside the function body [cppcoreguidelines-missing-std-forward] 46 | CommandFn(Fn&& fn) : | ^ /home/runner/work/graphia/graphia/source/shared/commands/command.h:51:5: warning: single-argument constructors must be marked explicit to avoid unintentional implicit conversions [google-explicit-constructor] 51 | CommandFn(Fn&& fn) : | ^ | explicit /home/runner/work/graphia/graphia/source/shared/commands/command.h:51:20: warning: forwarding reference parameter 'fn' is never forwarded inside the function body [cppcoreguidelines-missing-std-forward] 51 | CommandFn(Fn&& fn) : | ^ /home/runner/work/graphia/graphia/source/shared/commands/command.h:85:9: warning: constructors that are callable with a single argument must be marked explicit to avoid unintentional implicit conversions [google-explicit-constructor] 85 | CommandDescription(const QString& description = {}, | ^ | explicit /home/runner/work/graphia/graphia/source/shared/graph/elementid.h:35:5: warning: single-argument constructors must be marked explicit to avoid unintentional implicit conversions [google-explicit-constructor] 35 | ElementId(int value = NullValue) : | ^ | explicit /home/runner/work/graphia/graphia/source/shared/graph/grapharray.h:92:9: warning: initializer for member '_mutex' is redundant [readability-redundant-member-init] 92 | _mutex(), | ^~~~~~~~ /home/runner/work/graphia/graphia/source/shared/plugins/iplugin.h:101:9: warning: function-like macro 'IPluginIID' used; consider a 'constexpr' template function [cppcoreguidelines-macro-usage] 101 | #define IPluginIID(NAME) "app.graphia.IPlugin:" #NAME "/" VERSION // cppcoreguidelines-macro-usage | ^ /home/runner/work/graphia/graphia/source/shared/utils/flags.h:33:5: warning: single-argument constructors must be marked explicit to avoid unintentional implicit conversions [google-explicit-constructor] 33 | Flags(Enum value) : | ^ | explicit /home/runner/work/graphia/graphia/source/shared/utils/flags.h:38:5: warning: constructors that are callable with a single argument must be marked explicit to avoid unintentional implicit conversions [google-explicit-constructor] 38 | Flags(Enum value, Tail... values) | ^ | explicit 13670 warnings generated. [118/195] /home/runner/work/graphia/graphia/source/shared/commands/command.h:46:5: warning: single-argument constructors must be marked explicit to avoid unintentional implicit conversions [google-explicit-constructor] 46 | CommandFn(Fn&& fn) : | ^ | explicit /home/runner/work/graphia/graphia/source/shared/commands/command.h:46:20: warning: forwarding reference parameter 'fn' is never forwarded inside the function body [cppcoreguidelines-missing-std-forward] 46 | CommandFn(Fn&& fn) : | ^ /home/runner/work/graphia/graphia/source/shared/commands/command.h:51:5: warning: single-argument constructors must be marked explicit to avoid unintentional implicit conversions [google-explicit-constructor] 51 | CommandFn(Fn&& fn) : | ^ | explicit /home/runner/work/graphia/graphia/source/shared/commands/command.h:51:20: warning: forwarding reference parameter 'fn' is never forwarded inside the function body [cppcoreguidelines-missing-std-forward] 51 | CommandFn(Fn&& fn) : | ^ /home/runner/work/graphia/graphia/source/shared/commands/command.h:85:9: warning: constructors that are callable with a single argument must be marked explicit to avoid unintentional implicit conversions [google-explicit-constructor] 85 | CommandDescription(const QString& description = {}, | ^ | explicit /home/runner/work/graphia/graphia/source/shared/graph/elementid.h:35:5: warning: single-argument constructors must be marked explicit to avoid unintentional implicit conversions [google-explicit-constructor] 35 | ElementId(int value = NullValue) : | ^ | explicit /home/runner/work/graphia/graphia/source/shared/graph/grapharray.h:92:9: warning: initializer for member '_mutex' is redundant [readability-redundant-member-init] 92 | _mutex(), | ^~~~~~~~ /home/runner/work/graphia/graphia/source/shared/loading/userelementdata.h:114:16: warning: redundant get() call on smart pointer [readability-redundant-smartptr-get] 114 | return _indexes->get(elementId)._set; // readability-redundant-smartptr-get | ^~~~~~~~~~~~~~~~~~~~~~~ | _indexes /home/runner/work/graphia/graphia/source/shared/loading/userelementdata.h:119:16: warning: redundant get() call on smart pointer [readability-redundant-smartptr-get] 119 | return _indexes->get(elementId)._value; // readability-redundant-smartptr-get | ^~~~~~~~~~~~~~~~~~~~~~~ | _indexes /home/runner/work/graphia/graphia/source/shared/loading/userelementdata.h:345:9: warning: variable 'jsonAttributes' of type 'json' (aka 'basic_json<>') can be declared 'const' [misc-const-correctness] 345 | json jsonAttributes = json::object(); // misc-const-correctness | ^ | const /home/runner/work/graphia/graphia/source/shared/plugins/iplugin.h:101:9: warning: function-like macro 'IPluginIID' used; consider a 'constexpr' template function [cppcoreguidelines-macro-usage] 101 | #define IPluginIID(NAME) "app.graphia.IPlugin:" #NAME "/" VERSION // cppcoreguidelines-macro-usage | ^ /home/runner/work/graphia/graphia/source/shared/utils/flags.h:33:5: warning: single-argument constructors must be marked explicit to avoid unintentional implicit conversions [google-explicit-constructor] 33 | Flags(Enum value) : | ^ | explicit /home/runner/work/graphia/graphia/source/shared/utils/flags.h:38:5: warning: constructors that are callable with a single argument must be marked explicit to avoid unintentional implicit conversions [google-explicit-constructor] 38 | Flags(Enum value, Tail... values) | ^ | explicit /home/runner/work/graphia/graphia/source/shared/utils/scope_exit.h:27:1: warning: nested namespaces can be concatenated [modernize-concat-nested-namespaces] 27 | namespace std{ | ^~~~~~~~~~~~~~ 28 | namespace experimental{ | ~~~~~~~~~~~~~~~~~~~~~~ | namespace std::experimental /home/runner/work/graphia/graphia/source/shared/utils/scope_exit.h:28:11: warning: modification of 'std' namespace can result in undefined behavior [cert-dcl58-cpp] 28 | namespace experimental{ | ^ /home/runner/work/graphia/graphia/source/shared/utils/scope_exit.h:27:11: note: 'std' namespace opened here 27 | namespace std{ | ^ 22526 warnings generated. [119/195] /home/runner/work/graphia/graphia/source/shared/commands/command.h:46:5: warning: single-argument constructors must be marked explicit to avoid unintentional implicit conversions [google-explicit-constructor] 46 | CommandFn(Fn&& fn) : | ^ | explicit /home/runner/work/graphia/graphia/source/shared/commands/command.h:46:20: warning: forwarding reference parameter 'fn' is never forwarded inside the function body [cppcoreguidelines-missing-std-forward] 46 | CommandFn(Fn&& fn) : | ^ /home/runner/work/graphia/graphia/source/shared/commands/command.h:51:5: warning: single-argument constructors must be marked explicit to avoid unintentional implicit conversions [google-explicit-constructor] 51 | CommandFn(Fn&& fn) : | ^ | explicit /home/runner/work/graphia/graphia/source/shared/commands/command.h:51:20: warning: forwarding reference parameter 'fn' is never forwarded inside the function body [cppcoreguidelines-missing-std-forward] 51 | CommandFn(Fn&& fn) : | ^ /home/runner/work/graphia/graphia/source/shared/commands/command.h:85:9: warning: constructors that are callable with a single argument must be marked explicit to avoid unintentional implicit conversions [google-explicit-constructor] 85 | CommandDescription(const QString& description = {}, | ^ | explicit /home/runner/work/graphia/graphia/source/shared/graph/elementid.h:35:5: warning: single-argument constructors must be marked explicit to avoid unintentional implicit conversions [google-explicit-constructor] 35 | ElementId(int value = NullValue) : | ^ | explicit /home/runner/work/graphia/graphia/source/shared/graph/grapharray.h:92:9: warning: initializer for member '_mutex' is redundant [readability-redundant-member-init] 92 | _mutex(), | ^~~~~~~~ /home/runner/work/graphia/graphia/source/shared/plugins/iplugin.h:101:9: warning: function-like macro 'IPluginIID' used; consider a 'constexpr' template function [cppcoreguidelines-macro-usage] 101 | #define IPluginIID(NAME) "app.graphia.IPlugin:" #NAME "/" VERSION // cppcoreguidelines-macro-usage | ^ /home/runner/work/graphia/graphia/source/shared/utils/flags.h:33:5: warning: single-argument constructors must be marked explicit to avoid unintentional implicit conversions [google-explicit-constructor] 33 | Flags(Enum value) : | ^ | explicit /home/runner/work/graphia/graphia/source/shared/utils/flags.h:38:5: warning: constructors that are callable with a single argument must be marked explicit to avoid unintentional implicit conversions [google-explicit-constructor] 38 | Flags(Enum value, Tail... values) | ^ | explicit 13656 warnings generated. [120/195] /home/runner/work/graphia/Qt/6.6.3/gcc_64/include/QtQuick/qsgnode.h:33:11: warning: no definition found for 'Updater', but a definition with the same name 'Updater' found in another namespace '(global)' [bugprone-forward-declaration-namespace] 33 | class Updater; | ^ /home/runner/work/graphia/graphia/source/app/updates/updater.h:35:7: note: a definition of 'Updater' is found here 35 | class Updater : public QObject | ^ /home/runner/work/graphia/graphia/source/shared/graph/elementid.h:35:5: warning: single-argument constructors must be marked explicit to avoid unintentional implicit conversions [google-explicit-constructor] 35 | ElementId(int value = NullValue) : | ^ | explicit /home/runner/work/graphia/graphia/source/shared/graph/grapharray.h:92:9: warning: initializer for member '_mutex' is redundant [readability-redundant-member-init] 92 | _mutex(), | ^~~~~~~~ /home/runner/work/graphia/graphia/source/shared/utils/flags.h:33:5: warning: single-argument constructors must be marked explicit to avoid unintentional implicit conversions [google-explicit-constructor] 33 | Flags(Enum value) : | ^ | explicit /home/runner/work/graphia/graphia/source/shared/utils/flags.h:38:5: warning: constructors that are callable with a single argument must be marked explicit to avoid unintentional implicit conversions [google-explicit-constructor] 38 | Flags(Enum value, Tail... values) | ^ | explicit /home/runner/work/graphia/graphia/source/shared/utils/is_detected.h:24:1: warning: nested namespaces can be concatenated [modernize-concat-nested-namespaces] 24 | namespace std{ | ^~~~~~~~~~~~~~ 25 | namespace experimental{ | ~~~~~~~~~~~~~~~~~~~~~~ | namespace std::experimental /home/runner/work/graphia/graphia/source/shared/utils/is_detected.h:25:11: warning: modification of 'std' namespace can result in undefined behavior [cert-dcl58-cpp] 25 | namespace experimental{ | ^ /home/runner/work/graphia/graphia/source/shared/utils/is_detected.h:24:11: note: 'std' namespace opened here 24 | namespace std{ | ^ /home/runner/work/graphia/graphia/source/shared/utils/threadpool.h:66:109: warning: forwarding reference parameter 'args' is never forwarded inside the function body [cppcoreguidelines-missing-std-forward] 66 | template std::future> makeFuture(Fn f, Args&&... args) | ^ 29124 warnings generated. [121/195] 7326 warnings generated. [122/195] 7336 warnings generated. [123/195] 7320 warnings generated. [124/195] 7323 warnings generated. [125/195] 7320 warnings generated. [126/195] 7320 warnings generated. [127/195] 10201 warnings generated. [128/195] 10794 warnings generated. [129/195] 18495 warnings generated. [130/195] 18747 warnings generated. [131/195] 11362 warnings generated. [132/195] /home/runner/work/graphia/graphia/source/shared/graph/elementid.h:35:5: warning: single-argument constructors must be marked explicit to avoid unintentional implicit conversions [google-explicit-constructor] 35 | ElementId(int value = NullValue) : | ^ | explicit /home/runner/work/graphia/graphia/source/shared/graph/grapharray.h:92:9: warning: initializer for member '_mutex' is redundant [readability-redundant-member-init] 92 | _mutex(), | ^~~~~~~~ /home/runner/work/graphia/graphia/source/shared/loading/userelementdata.h:114:16: warning: redundant get() call on smart pointer [readability-redundant-smartptr-get] 114 | return _indexes->get(elementId)._set; // readability-redundant-smartptr-get | ^~~~~~~~~~~~~~~~~~~~~~~ | _indexes /home/runner/work/graphia/graphia/source/shared/loading/userelementdata.h:119:16: warning: redundant get() call on smart pointer [readability-redundant-smartptr-get] 119 | return _indexes->get(elementId)._value; // readability-redundant-smartptr-get | ^~~~~~~~~~~~~~~~~~~~~~~ | _indexes /home/runner/work/graphia/graphia/source/shared/loading/userelementdata.h:345:9: warning: variable 'jsonAttributes' of type 'json' (aka 'basic_json<>') can be declared 'const' [misc-const-correctness] 345 | json jsonAttributes = json::object(); // misc-const-correctness | ^ | const /home/runner/work/graphia/graphia/source/shared/utils/flags.h:33:5: warning: single-argument constructors must be marked explicit to avoid unintentional implicit conversions [google-explicit-constructor] 33 | Flags(Enum value) : | ^ | explicit /home/runner/work/graphia/graphia/source/shared/utils/flags.h:38:5: warning: constructors that are callable with a single argument must be marked explicit to avoid unintentional implicit conversions [google-explicit-constructor] 38 | Flags(Enum value, Tail... values) | ^ | explicit 30561 warnings generated. [133/195] /home/runner/work/graphia/graphia/source/app/rendering/graphrenderer.h:91:6: warning: redundant 'initialiseFromGraph' declaration [readability-redundant-declaration] 91 | void initialiseFromGraph(const Graph*, Target&); | ^ /home/runner/work/graphia/graphia/source/app/rendering/graphcomponentscene.h:33:6: note: previously declared here 33 | void initialiseFromGraph(const Graph*, Target&); | ^ /home/runner/work/graphia/graphia/source/shared/graph/elementid.h:35:5: warning: single-argument constructors must be marked explicit to avoid unintentional implicit conversions [google-explicit-constructor] 35 | ElementId(int value = NullValue) : | ^ | explicit /home/runner/work/graphia/graphia/source/shared/graph/grapharray.h:92:9: warning: initializer for member '_mutex' is redundant [readability-redundant-member-init] 92 | _mutex(), | ^~~~~~~~ /home/runner/work/graphia/graphia/source/shared/loading/userelementdata.h:114:16: warning: redundant get() call on smart pointer [readability-redundant-smartptr-get] 114 | return _indexes->get(elementId)._set; // readability-redundant-smartptr-get | ^~~~~~~~~~~~~~~~~~~~~~~ | _indexes /home/runner/work/graphia/graphia/source/shared/loading/userelementdata.h:119:16: warning: redundant get() call on smart pointer [readability-redundant-smartptr-get] 119 | return _indexes->get(elementId)._value; // readability-redundant-smartptr-get | ^~~~~~~~~~~~~~~~~~~~~~~ | _indexes /home/runner/work/graphia/graphia/source/shared/loading/userelementdata.h:345:9: warning: variable 'jsonAttributes' of type 'json' (aka 'basic_json<>') can be declared 'const' [misc-const-correctness] 345 | json jsonAttributes = json::object(); // misc-const-correctness | ^ | const /home/runner/work/graphia/graphia/source/shared/utils/flags.h:33:5: warning: single-argument constructors must be marked explicit to avoid unintentional implicit conversions [google-explicit-constructor] 33 | Flags(Enum value) : | ^ | explicit /home/runner/work/graphia/graphia/source/shared/utils/flags.h:38:5: warning: constructors that are callable with a single argument must be marked explicit to avoid unintentional implicit conversions [google-explicit-constructor] 38 | Flags(Enum value, Tail... values) | ^ | explicit /home/runner/work/graphia/graphia/source/shared/utils/scope_exit.h:27:1: warning: nested namespaces can be concatenated [modernize-concat-nested-namespaces] 27 | namespace std{ | ^~~~~~~~~~~~~~ 28 | namespace experimental{ | ~~~~~~~~~~~~~~~~~~~~~~ | namespace std::experimental /home/runner/work/graphia/graphia/source/shared/utils/scope_exit.h:28:11: warning: modification of 'std' namespace can result in undefined behavior [cert-dcl58-cpp] 28 | namespace experimental{ | ^ /home/runner/work/graphia/graphia/source/shared/utils/scope_exit.h:27:11: note: 'std' namespace opened here 27 | namespace std{ | ^ 31101 warnings generated. [134/195] /home/runner/work/graphia/graphia/source/app/rendering/graphrenderer.h:91:6: warning: redundant 'initialiseFromGraph' declaration [readability-redundant-declaration] 91 | void initialiseFromGraph(const Graph*, Target&); | ^ /home/runner/work/graphia/graphia/source/app/rendering/graphoverviewscene.h:47:6: note: previously declared here 47 | void initialiseFromGraph(const Graph*, Target&); | ^ /home/runner/work/graphia/graphia/source/shared/commands/command.h:46:5: warning: single-argument constructors must be marked explicit to avoid unintentional implicit conversions [google-explicit-constructor] 46 | CommandFn(Fn&& fn) : | ^ | explicit /home/runner/work/graphia/graphia/source/shared/commands/command.h:46:20: warning: forwarding reference parameter 'fn' is never forwarded inside the function body [cppcoreguidelines-missing-std-forward] 46 | CommandFn(Fn&& fn) : | ^ /home/runner/work/graphia/graphia/source/shared/commands/command.h:51:5: warning: single-argument constructors must be marked explicit to avoid unintentional implicit conversions [google-explicit-constructor] 51 | CommandFn(Fn&& fn) : | ^ | explicit /home/runner/work/graphia/graphia/source/shared/commands/command.h:51:20: warning: forwarding reference parameter 'fn' is never forwarded inside the function body [cppcoreguidelines-missing-std-forward] 51 | CommandFn(Fn&& fn) : | ^ /home/runner/work/graphia/graphia/source/shared/commands/command.h:85:9: warning: constructors that are callable with a single argument must be marked explicit to avoid unintentional implicit conversions [google-explicit-constructor] 85 | CommandDescription(const QString& description = {}, | ^ | explicit /home/runner/work/graphia/graphia/source/shared/graph/elementid.h:35:5: warning: single-argument constructors must be marked explicit to avoid unintentional implicit conversions [google-explicit-constructor] 35 | ElementId(int value = NullValue) : | ^ | explicit /home/runner/work/graphia/graphia/source/shared/graph/grapharray.h:92:9: warning: initializer for member '_mutex' is redundant [readability-redundant-member-init] 92 | _mutex(), | ^~~~~~~~ /home/runner/work/graphia/graphia/source/shared/loading/userelementdata.h:114:16: warning: redundant get() call on smart pointer [readability-redundant-smartptr-get] 114 | return _indexes->get(elementId)._set; // readability-redundant-smartptr-get | ^~~~~~~~~~~~~~~~~~~~~~~ | _indexes /home/runner/work/graphia/graphia/source/shared/loading/userelementdata.h:119:16: warning: redundant get() call on smart pointer [readability-redundant-smartptr-get] 119 | return _indexes->get(elementId)._value; // readability-redundant-smartptr-get | ^~~~~~~~~~~~~~~~~~~~~~~ | _indexes /home/runner/work/graphia/graphia/source/shared/loading/userelementdata.h:345:9: warning: variable 'jsonAttributes' of type 'json' (aka 'basic_json<>') can be declared 'const' [misc-const-correctness] 345 | json jsonAttributes = json::object(); // misc-const-correctness | ^ | const /home/runner/work/graphia/graphia/source/shared/utils/flags.h:33:5: warning: single-argument constructors must be marked explicit to avoid unintentional implicit conversions [google-explicit-constructor] 33 | Flags(Enum value) : | ^ | explicit /home/runner/work/graphia/graphia/source/shared/utils/flags.h:38:5: warning: constructors that are callable with a single argument must be marked explicit to avoid unintentional implicit conversions [google-explicit-constructor] 38 | Flags(Enum value, Tail... values) | ^ | explicit /home/runner/work/graphia/graphia/source/shared/utils/scope_exit.h:27:1: warning: nested namespaces can be concatenated [modernize-concat-nested-namespaces] 27 | namespace std{ | ^~~~~~~~~~~~~~ 28 | namespace experimental{ | ~~~~~~~~~~~~~~~~~~~~~~ | namespace std::experimental /home/runner/work/graphia/graphia/source/shared/utils/scope_exit.h:28:11: warning: modification of 'std' namespace can result in undefined behavior [cert-dcl58-cpp] 28 | namespace experimental{ | ^ /home/runner/work/graphia/graphia/source/shared/utils/scope_exit.h:27:11: note: 'std' namespace opened here 27 | namespace std{ | ^ 31365 warnings generated. [135/195] /home/runner/work/graphia/Qt/6.6.3/gcc_64/include/QtQuick/qsgnode.h:33:11: warning: no definition found for 'Updater', but a definition with the same name 'Updater' found in another namespace '(global)' [bugprone-forward-declaration-namespace] 33 | class Updater; | ^ /home/runner/work/graphia/graphia/source/app/updates/updater.h:35:7: note: a definition of 'Updater' is found here 35 | class Updater : public QObject | ^ /home/runner/work/graphia/graphia/source/app/rendering/graphcomponentscene.h:33:6: warning: redundant 'initialiseFromGraph' declaration [readability-redundant-declaration] 33 | void initialiseFromGraph(const Graph*, Target&); | ^ /home/runner/work/graphia/graphia/source/app/rendering/graphrenderer.h:91:6: note: previously declared here 91 | void initialiseFromGraph(const Graph*, Target&); | ^ /home/runner/work/graphia/graphia/source/app/rendering/graphoverviewscene.h:47:6: warning: redundant 'initialiseFromGraph' declaration [readability-redundant-declaration] 47 | void initialiseFromGraph(const Graph*, Target&); | ^ /home/runner/work/graphia/graphia/source/app/rendering/graphcomponentscene.h:33:6: note: previously declared here 33 | void initialiseFromGraph(const Graph*, Target&); | ^ /home/runner/work/graphia/graphia/source/shared/graph/elementid.h:35:5: warning: single-argument constructors must be marked explicit to avoid unintentional implicit conversions [google-explicit-constructor] 35 | ElementId(int value = NullValue) : | ^ | explicit /home/runner/work/graphia/graphia/source/shared/graph/grapharray.h:92:9: warning: initializer for member '_mutex' is redundant [readability-redundant-member-init] 92 | _mutex(), | ^~~~~~~~ /home/runner/work/graphia/graphia/source/shared/loading/userelementdata.h:114:16: warning: redundant get() call on smart pointer [readability-redundant-smartptr-get] 114 | return _indexes->get(elementId)._set; // readability-redundant-smartptr-get | ^~~~~~~~~~~~~~~~~~~~~~~ | _indexes /home/runner/work/graphia/graphia/source/shared/loading/userelementdata.h:119:16: warning: redundant get() call on smart pointer [readability-redundant-smartptr-get] 119 | return _indexes->get(elementId)._value; // readability-redundant-smartptr-get | ^~~~~~~~~~~~~~~~~~~~~~~ | _indexes /home/runner/work/graphia/graphia/source/shared/loading/userelementdata.h:345:9: warning: variable 'jsonAttributes' of type 'json' (aka 'basic_json<>') can be declared 'const' [misc-const-correctness] 345 | json jsonAttributes = json::object(); // misc-const-correctness | ^ | const /home/runner/work/graphia/graphia/source/shared/utils/doasyncthen.h:42:28: warning: forwarding reference parameter 'thenFn' is never forwarded inside the function body [cppcoreguidelines-missing-std-forward] 42 | void then(ThenFn&& thenFn) | ^ /home/runner/work/graphia/graphia/source/shared/utils/flags.h:33:5: warning: single-argument constructors must be marked explicit to avoid unintentional implicit conversions [google-explicit-constructor] 33 | Flags(Enum value) : | ^ | explicit /home/runner/work/graphia/graphia/source/shared/utils/flags.h:38:5: warning: constructors that are callable with a single argument must be marked explicit to avoid unintentional implicit conversions [google-explicit-constructor] 38 | Flags(Enum value, Tail... values) | ^ | explicit 31959 warnings generated. [136/195] /home/runner/work/graphia/graphia/source/app/rendering/graphrenderercore.cpp:178:30: warning: integer to pointer cast pessimizes optimization opportunities [performance-no-int-to-ptr] 178 | reinterpret_cast(offsetof(GlyphData, _component))); | ^ /home/runner/work/graphia/graphia/source/app/rendering/graphrenderercore.cpp:181:30: warning: integer to pointer cast pessimizes optimization opportunities [performance-no-int-to-ptr] 181 | reinterpret_cast(offsetof(GlyphData, _textureLayer))); | ^ /home/runner/work/graphia/graphia/source/app/rendering/graphrenderercore.cpp:215:27: warning: integer to pointer cast pessimizes optimization opportunities [performance-no-int-to-ptr] 215 | reinterpret_cast(offsetof(NodeData, _component))); | ^ /home/runner/work/graphia/graphia/source/app/rendering/graphrenderercore.cpp:253:29: warning: integer to pointer cast pessimizes optimization opportunities [performance-no-int-to-ptr] 253 | reinterpret_cast(offsetof(EdgeData, _edgeType))); | ^ /home/runner/work/graphia/graphia/source/app/rendering/graphrenderercore.cpp:255:28: warning: integer to pointer cast pessimizes optimization opportunities [performance-no-int-to-ptr] 255 | reinterpret_cast(offsetof(EdgeData, _component))); | ^ /home/runner/work/graphia/graphia/source/shared/commands/command.h:46:5: warning: single-argument constructors must be marked explicit to avoid unintentional implicit conversions [google-explicit-constructor] 46 | CommandFn(Fn&& fn) : | ^ | explicit /home/runner/work/graphia/graphia/source/shared/commands/command.h:46:20: warning: forwarding reference parameter 'fn' is never forwarded inside the function body [cppcoreguidelines-missing-std-forward] 46 | CommandFn(Fn&& fn) : | ^ /home/runner/work/graphia/graphia/source/shared/commands/command.h:51:5: warning: single-argument constructors must be marked explicit to avoid unintentional implicit conversions [google-explicit-constructor] 51 | CommandFn(Fn&& fn) : | ^ | explicit /home/runner/work/graphia/graphia/source/shared/commands/command.h:51:20: warning: forwarding reference parameter 'fn' is never forwarded inside the function body [cppcoreguidelines-missing-std-forward] 51 | CommandFn(Fn&& fn) : | ^ /home/runner/work/graphia/graphia/source/shared/commands/command.h:85:9: warning: constructors that are callable with a single argument must be marked explicit to avoid unintentional implicit conversions [google-explicit-constructor] 85 | CommandDescription(const QString& description = {}, | ^ | explicit /home/runner/work/graphia/graphia/source/shared/graph/elementid.h:35:5: warning: single-argument constructors must be marked explicit to avoid unintentional implicit conversions [google-explicit-constructor] 35 | ElementId(int value = NullValue) : | ^ | explicit /home/runner/work/graphia/graphia/source/shared/graph/grapharray.h:92:9: warning: initializer for member '_mutex' is redundant [readability-redundant-member-init] 92 | _mutex(), | ^~~~~~~~ /home/runner/work/graphia/graphia/source/shared/plugins/iplugin.h:101:9: warning: function-like macro 'IPluginIID' used; consider a 'constexpr' template function [cppcoreguidelines-macro-usage] 101 | #define IPluginIID(NAME) "app.graphia.IPlugin:" #NAME "/" VERSION // cppcoreguidelines-macro-usage | ^ /home/runner/work/graphia/graphia/source/shared/utils/flags.h:33:5: warning: single-argument constructors must be marked explicit to avoid unintentional implicit conversions [google-explicit-constructor] 33 | Flags(Enum value) : | ^ | explicit /home/runner/work/graphia/graphia/source/shared/utils/flags.h:38:5: warning: constructors that are callable with a single argument must be marked explicit to avoid unintentional implicit conversions [google-explicit-constructor] 38 | Flags(Enum value, Tail... values) | ^ | explicit 22206 warnings generated. [137/195] 18215 warnings generated. [138/195] [139/195] 18534 warnings generated. [140/195] 18537 warnings generated. [141/195] 18534 warnings generated. [142/195] /home/runner/work/graphia/graphia/source/app/rendering/graphcomponentscene.h:33:6: warning: redundant 'initialiseFromGraph' declaration [readability-redundant-declaration] 33 | void initialiseFromGraph(const Graph*, Target&); | ^ /home/runner/work/graphia/graphia/source/app/rendering/graphrenderer.h:91:6: note: previously declared here 91 | void initialiseFromGraph(const Graph*, Target&); | ^ /home/runner/work/graphia/graphia/source/app/rendering/graphoverviewscene.h:47:6: warning: redundant 'initialiseFromGraph' declaration [readability-redundant-declaration] 47 | void initialiseFromGraph(const Graph*, Target&); | ^ /home/runner/work/graphia/graphia/source/app/rendering/graphcomponentscene.h:33:6: note: previously declared here 33 | void initialiseFromGraph(const Graph*, Target&); | ^ /home/runner/work/graphia/graphia/source/shared/commands/command.h:46:5: warning: single-argument constructors must be marked explicit to avoid unintentional implicit conversions [google-explicit-constructor] 46 | CommandFn(Fn&& fn) : | ^ | explicit /home/runner/work/graphia/graphia/source/shared/commands/command.h:46:20: warning: forwarding reference parameter 'fn' is never forwarded inside the function body [cppcoreguidelines-missing-std-forward] 46 | CommandFn(Fn&& fn) : | ^ /home/runner/work/graphia/graphia/source/shared/commands/command.h:51:5: warning: single-argument constructors must be marked explicit to avoid unintentional implicit conversions [google-explicit-constructor] 51 | CommandFn(Fn&& fn) : | ^ | explicit /home/runner/work/graphia/graphia/source/shared/commands/command.h:51:20: warning: forwarding reference parameter 'fn' is never forwarded inside the function body [cppcoreguidelines-missing-std-forward] 51 | CommandFn(Fn&& fn) : | ^ /home/runner/work/graphia/graphia/source/shared/commands/command.h:85:9: warning: constructors that are callable with a single argument must be marked explicit to avoid unintentional implicit conversions [google-explicit-constructor] 85 | CommandDescription(const QString& description = {}, | ^ | explicit /home/runner/work/graphia/graphia/source/shared/graph/elementid.h:35:5: warning: single-argument constructors must be marked explicit to avoid unintentional implicit conversions [google-explicit-constructor] 35 | ElementId(int value = NullValue) : | ^ | explicit /home/runner/work/graphia/graphia/source/shared/graph/grapharray.h:92:9: warning: initializer for member '_mutex' is redundant [readability-redundant-member-init] 92 | _mutex(), | ^~~~~~~~ /home/runner/work/graphia/graphia/source/shared/loading/userelementdata.h:114:16: warning: redundant get() call on smart pointer [readability-redundant-smartptr-get] 114 | return _indexes->get(elementId)._set; // readability-redundant-smartptr-get | ^~~~~~~~~~~~~~~~~~~~~~~ | _indexes /home/runner/work/graphia/graphia/source/shared/loading/userelementdata.h:119:16: warning: redundant get() call on smart pointer [readability-redundant-smartptr-get] 119 | return _indexes->get(elementId)._value; // readability-redundant-smartptr-get | ^~~~~~~~~~~~~~~~~~~~~~~ | _indexes /home/runner/work/graphia/graphia/source/shared/loading/userelementdata.h:345:9: warning: variable 'jsonAttributes' of type 'json' (aka 'basic_json<>') can be declared 'const' [misc-const-correctness] 345 | json jsonAttributes = json::object(); // misc-const-correctness | ^ | const /home/runner/work/graphia/graphia/source/shared/plugins/iplugin.h:101:9: warning: function-like macro 'IPluginIID' used; consider a 'constexpr' template function [cppcoreguidelines-macro-usage] 101 | #define IPluginIID(NAME) "app.graphia.IPlugin:" #NAME "/" VERSION // cppcoreguidelines-macro-usage | ^ /home/runner/work/graphia/graphia/source/shared/utils/flags.h:33:5: warning: single-argument constructors must be marked explicit to avoid unintentional implicit conversions [google-explicit-constructor] 33 | Flags(Enum value) : | ^ | explicit /home/runner/work/graphia/graphia/source/shared/utils/flags.h:38:5: warning: constructors that are callable with a single argument must be marked explicit to avoid unintentional implicit conversions [google-explicit-constructor] 38 | Flags(Enum value, Tail... values) | ^ | explicit 31229 warnings generated. [143/195] /home/runner/work/graphia/graphia/source/shared/utils/scope_exit.h:27:1: warning: nested namespaces can be concatenated [modernize-concat-nested-namespaces] 27 | namespace std{ | ^~~~~~~~~~~~~~ 28 | namespace experimental{ | ~~~~~~~~~~~~~~~~~~~~~~ | namespace std::experimental /home/runner/work/graphia/graphia/source/shared/utils/scope_exit.h:28:11: warning: modification of 'std' namespace can result in undefined behavior [cert-dcl58-cpp] 28 | namespace experimental{ | ^ /home/runner/work/graphia/graphia/source/shared/utils/scope_exit.h:27:11: note: 'std' namespace opened here 27 | namespace std{ | ^ 19212 warnings generated. [144/195] 9702 warnings generated. [145/195] 10206 warnings generated. [146/195] 17851 warnings generated. [147/195] /home/runner/work/graphia/graphia/source/shared/graph/elementid.h:35:5: warning: single-argument constructors must be marked explicit to avoid unintentional implicit conversions [google-explicit-constructor] 35 | ElementId(int value = NullValue) : | ^ | explicit /home/runner/work/graphia/graphia/source/shared/graph/grapharray.h:92:9: warning: initializer for member '_mutex' is redundant [readability-redundant-member-init] 92 | _mutex(), | ^~~~~~~~ /home/runner/work/graphia/graphia/source/shared/loading/userelementdata.h:114:16: warning: redundant get() call on smart pointer [readability-redundant-smartptr-get] 114 | return _indexes->get(elementId)._set; // readability-redundant-smartptr-get | ^~~~~~~~~~~~~~~~~~~~~~~ | _indexes /home/runner/work/graphia/graphia/source/shared/loading/userelementdata.h:119:16: warning: redundant get() call on smart pointer [readability-redundant-smartptr-get] 119 | return _indexes->get(elementId)._value; // readability-redundant-smartptr-get | ^~~~~~~~~~~~~~~~~~~~~~~ | _indexes /home/runner/work/graphia/graphia/source/shared/loading/userelementdata.h:345:9: warning: variable 'jsonAttributes' of type 'json' (aka 'basic_json<>') can be declared 'const' [misc-const-correctness] 345 | json jsonAttributes = json::object(); // misc-const-correctness | ^ | const /home/runner/work/graphia/graphia/source/shared/utils/flags.h:33:5: warning: single-argument constructors must be marked explicit to avoid unintentional implicit conversions [google-explicit-constructor] 33 | Flags(Enum value) : | ^ | explicit /home/runner/work/graphia/graphia/source/shared/utils/flags.h:38:5: warning: constructors that are callable with a single argument must be marked explicit to avoid unintentional implicit conversions [google-explicit-constructor] 38 | Flags(Enum value, Tail... values) | ^ | explicit 23315 warnings generated. [148/195] /home/runner/work/graphia/graphia/source/shared/graph/elementid.h:35:5: warning: single-argument constructors must be marked explicit to avoid unintentional implicit conversions [google-explicit-constructor] 35 | ElementId(int value = NullValue) : | ^ | explicit /home/runner/work/graphia/graphia/source/shared/utils/flags.h:33:5: warning: single-argument constructors must be marked explicit to avoid unintentional implicit conversions [google-explicit-constructor] 33 | Flags(Enum value) : | ^ | explicit /home/runner/work/graphia/graphia/source/shared/utils/flags.h:38:5: warning: constructors that are callable with a single argument must be marked explicit to avoid unintentional implicit conversions [google-explicit-constructor] 38 | Flags(Enum value, Tail... values) | ^ | explicit 19666 warnings generated. [149/195] 25653 warnings generated. [150/195] /home/runner/work/graphia/graphia/source/shared/graph/elementid.h:35:5: warning: single-argument constructors must be marked explicit to avoid unintentional implicit conversions [google-explicit-constructor] 35 | ElementId(int value = NullValue) : | ^ | explicit /home/runner/work/graphia/graphia/source/shared/graph/grapharray.h:92:9: warning: initializer for member '_mutex' is redundant [readability-redundant-member-init] 92 | _mutex(), | ^~~~~~~~ /home/runner/work/graphia/graphia/source/shared/loading/userelementdata.h:114:16: warning: redundant get() call on smart pointer [readability-redundant-smartptr-get] 114 | return _indexes->get(elementId)._set; // readability-redundant-smartptr-get | ^~~~~~~~~~~~~~~~~~~~~~~ | _indexes /home/runner/work/graphia/graphia/source/shared/loading/userelementdata.h:119:16: warning: redundant get() call on smart pointer [readability-redundant-smartptr-get] 119 | return _indexes->get(elementId)._value; // readability-redundant-smartptr-get | ^~~~~~~~~~~~~~~~~~~~~~~ | _indexes /home/runner/work/graphia/graphia/source/shared/loading/userelementdata.h:345:9: warning: variable 'jsonAttributes' of type 'json' (aka 'basic_json<>') can be declared 'const' [misc-const-correctness] 345 | json jsonAttributes = json::object(); // misc-const-correctness | ^ | const /home/runner/work/graphia/graphia/source/shared/utils/flags.h:33:5: warning: single-argument constructors must be marked explicit to avoid unintentional implicit conversions [google-explicit-constructor] 33 | Flags(Enum value) : | ^ | explicit /home/runner/work/graphia/graphia/source/shared/utils/flags.h:38:5: warning: constructors that are callable with a single argument must be marked explicit to avoid unintentional implicit conversions [google-explicit-constructor] 38 | Flags(Enum value, Tail... values) | ^ | explicit /home/runner/work/graphia/graphia/source/shared/utils/passkey.h:28:5: warning: use '= default' to define a trivial default constructor [modernize-use-equals-default] 28 | PassKey() {} | ^ ~~ | = default; /home/runner/work/graphia/graphia/source/shared/utils/passkey.h:29:5: warning: use '= default' to define a trivial copy constructor [modernize-use-equals-default] 29 | PassKey(PassKey const&) {} | ^ ~~ | = default; 22473 warnings generated. [151/195] /home/runner/work/graphia/graphia/source/shared/graph/elementid.h:35:5: warning: single-argument constructors must be marked explicit to avoid unintentional implicit conversions [google-explicit-constructor] 35 | ElementId(int value = NullValue) : | ^ | explicit /home/runner/work/graphia/graphia/source/shared/graph/grapharray.h:92:9: warning: initializer for member '_mutex' is redundant [readability-redundant-member-init] 92 | _mutex(), | ^~~~~~~~ /home/runner/work/graphia/graphia/source/shared/loading/userelementdata.h:114:16: warning: redundant get() call on smart pointer [readability-redundant-smartptr-get] 114 | return _indexes->get(elementId)._set; // readability-redundant-smartptr-get | ^~~~~~~~~~~~~~~~~~~~~~~ | _indexes /home/runner/work/graphia/graphia/source/shared/loading/userelementdata.h:119:16: warning: redundant get() call on smart pointer [readability-redundant-smartptr-get] 119 | return _indexes->get(elementId)._value; // readability-redundant-smartptr-get | ^~~~~~~~~~~~~~~~~~~~~~~ | _indexes /home/runner/work/graphia/graphia/source/shared/loading/userelementdata.h:345:9: warning: variable 'jsonAttributes' of type 'json' (aka 'basic_json<>') can be declared 'const' [misc-const-correctness] 345 | json jsonAttributes = json::object(); // misc-const-correctness | ^ | const /home/runner/work/graphia/graphia/source/shared/utils/flags.h:33:5: warning: single-argument constructors must be marked explicit to avoid unintentional implicit conversions [google-explicit-constructor] 33 | Flags(Enum value) : | ^ | explicit /home/runner/work/graphia/graphia/source/shared/utils/flags.h:38:5: warning: constructors that are callable with a single argument must be marked explicit to avoid unintentional implicit conversions [google-explicit-constructor] 38 | Flags(Enum value, Tail... values) | ^ | explicit /home/runner/work/graphia/graphia/source/shared/utils/passkey.h:28:5: warning: use '= default' to define a trivial default constructor [modernize-use-equals-default] 28 | PassKey() {} | ^ ~~ | = default; /home/runner/work/graphia/graphia/source/shared/utils/passkey.h:29:5: warning: use '= default' to define a trivial copy constructor [modernize-use-equals-default] 29 | PassKey(PassKey const&) {} | ^ ~~ | = default; 22504 warnings generated. [152/195] /home/runner/work/graphia/graphia/source/shared/graph/elementid.h:35:5: warning: single-argument constructors must be marked explicit to avoid unintentional implicit conversions [google-explicit-constructor] 35 | ElementId(int value = NullValue) : | ^ | explicit /home/runner/work/graphia/graphia/source/shared/graph/grapharray.h:92:9: warning: initializer for member '_mutex' is redundant [readability-redundant-member-init] 92 | _mutex(), | ^~~~~~~~ /home/runner/work/graphia/graphia/source/shared/loading/userelementdata.h:114:16: warning: redundant get() call on smart pointer [readability-redundant-smartptr-get] 114 | return _indexes->get(elementId)._set; // readability-redundant-smartptr-get | ^~~~~~~~~~~~~~~~~~~~~~~ | _indexes /home/runner/work/graphia/graphia/source/shared/loading/userelementdata.h:119:16: warning: redundant get() call on smart pointer [readability-redundant-smartptr-get] 119 | return _indexes->get(elementId)._value; // readability-redundant-smartptr-get | ^~~~~~~~~~~~~~~~~~~~~~~ | _indexes /home/runner/work/graphia/graphia/source/shared/loading/userelementdata.h:345:9: warning: variable 'jsonAttributes' of type 'json' (aka 'basic_json<>') can be declared 'const' [misc-const-correctness] 345 | json jsonAttributes = json::object(); // misc-const-correctness | ^ | const /home/runner/work/graphia/graphia/source/shared/utils/flags.h:33:5: warning: single-argument constructors must be marked explicit to avoid unintentional implicit conversions [google-explicit-constructor] 33 | Flags(Enum value) : | ^ | explicit /home/runner/work/graphia/graphia/source/shared/utils/flags.h:38:5: warning: constructors that are callable with a single argument must be marked explicit to avoid unintentional implicit conversions [google-explicit-constructor] 38 | Flags(Enum value, Tail... values) | ^ | explicit /home/runner/work/graphia/graphia/source/shared/utils/passkey.h:28:5: warning: use '= default' to define a trivial default constructor [modernize-use-equals-default] 28 | PassKey() {} | ^ ~~ | = default; /home/runner/work/graphia/graphia/source/shared/utils/passkey.h:29:5: warning: use '= default' to define a trivial copy constructor [modernize-use-equals-default] 29 | PassKey(PassKey const&) {} | ^ ~~ | = default; 22782 warnings generated. [153/195] /home/runner/work/graphia/graphia/source/shared/graph/elementid.h:35:5: warning: single-argument constructors must be marked explicit to avoid unintentional implicit conversions [google-explicit-constructor] 35 | ElementId(int value = NullValue) : | ^ | explicit /home/runner/work/graphia/graphia/source/shared/graph/grapharray.h:92:9: warning: initializer for member '_mutex' is redundant [readability-redundant-member-init] 92 | _mutex(), | ^~~~~~~~ /home/runner/work/graphia/graphia/source/shared/loading/userelementdata.h:114:16: warning: redundant get() call on smart pointer [readability-redundant-smartptr-get] 114 | return _indexes->get(elementId)._set; // readability-redundant-smartptr-get | ^~~~~~~~~~~~~~~~~~~~~~~ | _indexes /home/runner/work/graphia/graphia/source/shared/loading/userelementdata.h:119:16: warning: redundant get() call on smart pointer [readability-redundant-smartptr-get] 119 | return _indexes->get(elementId)._value; // readability-redundant-smartptr-get | ^~~~~~~~~~~~~~~~~~~~~~~ | _indexes /home/runner/work/graphia/graphia/source/shared/loading/userelementdata.h:345:9: warning: variable 'jsonAttributes' of type 'json' (aka 'basic_json<>') can be declared 'const' [misc-const-correctness] 345 | json jsonAttributes = json::object(); // misc-const-correctness | ^ | const /home/runner/work/graphia/graphia/source/shared/utils/flags.h:33:5: warning: single-argument constructors must be marked explicit to avoid unintentional implicit conversions [google-explicit-constructor] 33 | Flags(Enum value) : | ^ | explicit /home/runner/work/graphia/graphia/source/shared/utils/flags.h:38:5: warning: constructors that are callable with a single argument must be marked explicit to avoid unintentional implicit conversions [google-explicit-constructor] 38 | Flags(Enum value, Tail... values) | ^ | explicit /home/runner/work/graphia/graphia/source/shared/utils/passkey.h:28:5: warning: use '= default' to define a trivial default constructor [modernize-use-equals-default] 28 | PassKey() {} | ^ ~~ | = default; /home/runner/work/graphia/graphia/source/shared/utils/passkey.h:29:5: warning: use '= default' to define a trivial copy constructor [modernize-use-equals-default] 29 | PassKey(PassKey const&) {} | ^ ~~ | = default; 22718 warnings generated. [154/195] /home/runner/work/graphia/graphia/source/shared/graph/elementid.h:35:5: warning: single-argument constructors must be marked explicit to avoid unintentional implicit conversions [google-explicit-constructor] 35 | ElementId(int value = NullValue) : | ^ | explicit /home/runner/work/graphia/graphia/source/shared/graph/grapharray.h:92:9: warning: initializer for member '_mutex' is redundant [readability-redundant-member-init] 92 | _mutex(), | ^~~~~~~~ /home/runner/work/graphia/graphia/source/shared/loading/userelementdata.h:114:16: warning: redundant get() call on smart pointer [readability-redundant-smartptr-get] 114 | return _indexes->get(elementId)._set; // readability-redundant-smartptr-get | ^~~~~~~~~~~~~~~~~~~~~~~ | _indexes /home/runner/work/graphia/graphia/source/shared/loading/userelementdata.h:119:16: warning: redundant get() call on smart pointer [readability-redundant-smartptr-get] 119 | return _indexes->get(elementId)._value; // readability-redundant-smartptr-get | ^~~~~~~~~~~~~~~~~~~~~~~ | _indexes /home/runner/work/graphia/graphia/source/shared/loading/userelementdata.h:345:9: warning: variable 'jsonAttributes' of type 'json' (aka 'basic_json<>') can be declared 'const' [misc-const-correctness] 345 | json jsonAttributes = json::object(); // misc-const-correctness | ^ | const /home/runner/work/graphia/graphia/source/shared/utils/flags.h:33:5: warning: single-argument constructors must be marked explicit to avoid unintentional implicit conversions [google-explicit-constructor] 33 | Flags(Enum value) : | ^ | explicit /home/runner/work/graphia/graphia/source/shared/utils/flags.h:38:5: warning: constructors that are callable with a single argument must be marked explicit to avoid unintentional implicit conversions [google-explicit-constructor] 38 | Flags(Enum value, Tail... values) | ^ | explicit /home/runner/work/graphia/graphia/source/shared/utils/passkey.h:28:5: warning: use '= default' to define a trivial default constructor [modernize-use-equals-default] 28 | PassKey() {} | ^ ~~ | = default; /home/runner/work/graphia/graphia/source/shared/utils/passkey.h:29:5: warning: use '= default' to define a trivial copy constructor [modernize-use-equals-default] 29 | PassKey(PassKey const&) {} | ^ ~~ | = default; 22676 warnings generated. [155/195] /home/runner/work/graphia/graphia/source/shared/graph/elementid.h:35:5: warning: single-argument constructors must be marked explicit to avoid unintentional implicit conversions [google-explicit-constructor] 35 | ElementId(int value = NullValue) : | ^ | explicit /home/runner/work/graphia/graphia/source/shared/graph/grapharray.h:92:9: warning: initializer for member '_mutex' is redundant [readability-redundant-member-init] 92 | _mutex(), | ^~~~~~~~ /home/runner/work/graphia/graphia/source/shared/loading/userelementdata.h:114:16: warning: redundant get() call on smart pointer [readability-redundant-smartptr-get] 114 | return _indexes->get(elementId)._set; // readability-redundant-smartptr-get | ^~~~~~~~~~~~~~~~~~~~~~~ | _indexes /home/runner/work/graphia/graphia/source/shared/loading/userelementdata.h:119:16: warning: redundant get() call on smart pointer [readability-redundant-smartptr-get] 119 | return _indexes->get(elementId)._value; // readability-redundant-smartptr-get | ^~~~~~~~~~~~~~~~~~~~~~~ | _indexes /home/runner/work/graphia/graphia/source/shared/loading/userelementdata.h:345:9: warning: variable 'jsonAttributes' of type 'json' (aka 'basic_json<>') can be declared 'const' [misc-const-correctness] 345 | json jsonAttributes = json::object(); // misc-const-correctness | ^ | const /home/runner/work/graphia/graphia/source/shared/utils/flags.h:33:5: warning: single-argument constructors must be marked explicit to avoid unintentional implicit conversions [google-explicit-constructor] 33 | Flags(Enum value) : | ^ | explicit /home/runner/work/graphia/graphia/source/shared/utils/flags.h:38:5: warning: constructors that are callable with a single argument must be marked explicit to avoid unintentional implicit conversions [google-explicit-constructor] 38 | Flags(Enum value, Tail... values) | ^ | explicit /home/runner/work/graphia/graphia/source/shared/utils/is_detected.h:24:1: warning: nested namespaces can be concatenated [modernize-concat-nested-namespaces] 24 | namespace std{ | ^~~~~~~~~~~~~~ 25 | namespace experimental{ | ~~~~~~~~~~~~~~~~~~~~~~ | namespace std::experimental /home/runner/work/graphia/graphia/source/shared/utils/is_detected.h:25:11: warning: modification of 'std' namespace can result in undefined behavior [cert-dcl58-cpp] 25 | namespace experimental{ | ^ /home/runner/work/graphia/graphia/source/shared/utils/is_detected.h:24:11: note: 'std' namespace opened here 24 | namespace std{ | ^ /home/runner/work/graphia/graphia/source/shared/utils/passkey.h:28:5: warning: use '= default' to define a trivial default constructor [modernize-use-equals-default] 28 | PassKey() {} | ^ ~~ | = default; /home/runner/work/graphia/graphia/source/shared/utils/passkey.h:29:5: warning: use '= default' to define a trivial copy constructor [modernize-use-equals-default] 29 | PassKey(PassKey const&) {} | ^ ~~ | = default; /home/runner/work/graphia/graphia/source/shared/utils/threadpool.h:66:109: warning: forwarding reference parameter 'args' is never forwarded inside the function body [cppcoreguidelines-missing-std-forward] 66 | template std::future> makeFuture(Fn f, Args&&... args) | ^ 23402 warnings generated. [156/195] /home/runner/work/graphia/graphia/source/app/attributes/conditionfncreator.h:51:9: warning: single-argument constructors must be marked explicit to avoid unintentional implicit conversions [google-explicit-constructor] 51 | TerminalValueWrapper(GraphTransformConfig::TerminalValue terminalValue) : | ^ | explicit /home/runner/work/graphia/graphia/source/shared/graph/elementid.h:35:5: warning: single-argument constructors must be marked explicit to avoid unintentional implicit conversions [google-explicit-constructor] 35 | ElementId(int value = NullValue) : | ^ | explicit /home/runner/work/graphia/graphia/source/shared/graph/grapharray.h:92:9: warning: initializer for member '_mutex' is redundant [readability-redundant-member-init] 92 | _mutex(), | ^~~~~~~~ /home/runner/work/graphia/graphia/source/shared/loading/userelementdata.h:114:16: warning: redundant get() call on smart pointer [readability-redundant-smartptr-get] 114 | return _indexes->get(elementId)._set; // readability-redundant-smartptr-get | ^~~~~~~~~~~~~~~~~~~~~~~ | _indexes /home/runner/work/graphia/graphia/source/shared/loading/userelementdata.h:119:16: warning: redundant get() call on smart pointer [readability-redundant-smartptr-get] 119 | return _indexes->get(elementId)._value; // readability-redundant-smartptr-get | ^~~~~~~~~~~~~~~~~~~~~~~ | _indexes /home/runner/work/graphia/graphia/source/shared/loading/userelementdata.h:345:9: warning: variable 'jsonAttributes' of type 'json' (aka 'basic_json<>') can be declared 'const' [misc-const-correctness] 345 | json jsonAttributes = json::object(); // misc-const-correctness | ^ | const /home/runner/work/graphia/graphia/source/shared/utils/flags.h:33:5: warning: single-argument constructors must be marked explicit to avoid unintentional implicit conversions [google-explicit-constructor] 33 | Flags(Enum value) : | ^ | explicit /home/runner/work/graphia/graphia/source/shared/utils/flags.h:38:5: warning: constructors that are callable with a single argument must be marked explicit to avoid unintentional implicit conversions [google-explicit-constructor] 38 | Flags(Enum value, Tail... values) | ^ | explicit /home/runner/work/graphia/graphia/source/shared/utils/passkey.h:28:5: warning: use '= default' to define a trivial default constructor [modernize-use-equals-default] 28 | PassKey() {} | ^ ~~ | = default; /home/runner/work/graphia/graphia/source/shared/utils/passkey.h:29:5: warning: use '= default' to define a trivial copy constructor [modernize-use-equals-default] 29 | PassKey(PassKey const&) {} | ^ ~~ | = default; 25263 warnings generated. [157/195] /home/runner/work/graphia/graphia/source/app/attributes/conditionfncreator.h:51:9: warning: single-argument constructors must be marked explicit to avoid unintentional implicit conversions [google-explicit-constructor] 51 | TerminalValueWrapper(GraphTransformConfig::TerminalValue terminalValue) : | ^ | explicit /home/runner/work/graphia/graphia/source/shared/graph/elementid.h:35:5: warning: single-argument constructors must be marked explicit to avoid unintentional implicit conversions [google-explicit-constructor] 35 | ElementId(int value = NullValue) : | ^ | explicit /home/runner/work/graphia/graphia/source/shared/graph/grapharray.h:92:9: warning: initializer for member '_mutex' is redundant [readability-redundant-member-init] 92 | _mutex(), | ^~~~~~~~ /home/runner/work/graphia/graphia/source/shared/loading/userelementdata.h:114:16: warning: redundant get() call on smart pointer [readability-redundant-smartptr-get] 114 | return _indexes->get(elementId)._set; // readability-redundant-smartptr-get | ^~~~~~~~~~~~~~~~~~~~~~~ | _indexes /home/runner/work/graphia/graphia/source/shared/loading/userelementdata.h:119:16: warning: redundant get() call on smart pointer [readability-redundant-smartptr-get] 119 | return _indexes->get(elementId)._value; // readability-redundant-smartptr-get | ^~~~~~~~~~~~~~~~~~~~~~~ | _indexes /home/runner/work/graphia/graphia/source/shared/loading/userelementdata.h:345:9: warning: variable 'jsonAttributes' of type 'json' (aka 'basic_json<>') can be declared 'const' [misc-const-correctness] 345 | json jsonAttributes = json::object(); // misc-const-correctness | ^ | const /home/runner/work/graphia/graphia/source/shared/utils/flags.h:33:5: warning: single-argument constructors must be marked explicit to avoid unintentional implicit conversions [google-explicit-constructor] 33 | Flags(Enum value) : | ^ | explicit /home/runner/work/graphia/graphia/source/shared/utils/flags.h:38:5: warning: constructors that are callable with a single argument must be marked explicit to avoid unintentional implicit conversions [google-explicit-constructor] 38 | Flags(Enum value, Tail... values) | ^ | explicit /home/runner/work/graphia/graphia/source/shared/utils/passkey.h:28:5: warning: use '= default' to define a trivial default constructor [modernize-use-equals-default] 28 | PassKey() {} | ^ ~~ | = default; /home/runner/work/graphia/graphia/source/shared/utils/passkey.h:29:5: warning: use '= default' to define a trivial copy constructor [modernize-use-equals-default] 29 | PassKey(PassKey const&) {} | ^ ~~ | = default; 25248 warnings generated. [158/195] /home/runner/work/graphia/graphia/source/shared/graph/elementid.h:35:5: warning: single-argument constructors must be marked explicit to avoid unintentional implicit conversions [google-explicit-constructor] 35 | ElementId(int value = NullValue) : | ^ | explicit /home/runner/work/graphia/graphia/source/shared/graph/grapharray.h:92:9: warning: initializer for member '_mutex' is redundant [readability-redundant-member-init] 92 | _mutex(), | ^~~~~~~~ /home/runner/work/graphia/graphia/source/shared/loading/userelementdata.h:114:16: warning: redundant get() call on smart pointer [readability-redundant-smartptr-get] 114 | return _indexes->get(elementId)._set; // readability-redundant-smartptr-get | ^~~~~~~~~~~~~~~~~~~~~~~ | _indexes /home/runner/work/graphia/graphia/source/shared/loading/userelementdata.h:119:16: warning: redundant get() call on smart pointer [readability-redundant-smartptr-get] 119 | return _indexes->get(elementId)._value; // readability-redundant-smartptr-get | ^~~~~~~~~~~~~~~~~~~~~~~ | _indexes /home/runner/work/graphia/graphia/source/shared/loading/userelementdata.h:345:9: warning: variable 'jsonAttributes' of type 'json' (aka 'basic_json<>') can be declared 'const' [misc-const-correctness] 345 | json jsonAttributes = json::object(); // misc-const-correctness | ^ | const /home/runner/work/graphia/graphia/source/shared/utils/flags.h:33:5: warning: single-argument constructors must be marked explicit to avoid unintentional implicit conversions [google-explicit-constructor] 33 | Flags(Enum value) : | ^ | explicit /home/runner/work/graphia/graphia/source/shared/utils/flags.h:38:5: warning: constructors that are callable with a single argument must be marked explicit to avoid unintentional implicit conversions [google-explicit-constructor] 38 | Flags(Enum value, Tail... values) | ^ | explicit /home/runner/work/graphia/graphia/source/shared/utils/passkey.h:28:5: warning: use '= default' to define a trivial default constructor [modernize-use-equals-default] 28 | PassKey() {} | ^ ~~ | = default; /home/runner/work/graphia/graphia/source/shared/utils/passkey.h:29:5: warning: use '= default' to define a trivial copy constructor [modernize-use-equals-default] 29 | PassKey(PassKey const&) {} | ^ ~~ | = default; 22707 warnings generated. [159/195] /home/runner/work/graphia/graphia/source/shared/graph/elementid.h:35:5: warning: single-argument constructors must be marked explicit to avoid unintentional implicit conversions [google-explicit-constructor] 35 | ElementId(int value = NullValue) : | ^ | explicit /home/runner/work/graphia/graphia/source/shared/graph/grapharray.h:92:9: warning: initializer for member '_mutex' is redundant [readability-redundant-member-init] 92 | _mutex(), | ^~~~~~~~ /home/runner/work/graphia/graphia/source/shared/loading/userelementdata.h:114:16: warning: redundant get() call on smart pointer [readability-redundant-smartptr-get] 114 | return _indexes->get(elementId)._set; // readability-redundant-smartptr-get | ^~~~~~~~~~~~~~~~~~~~~~~ | _indexes /home/runner/work/graphia/graphia/source/shared/loading/userelementdata.h:119:16: warning: redundant get() call on smart pointer [readability-redundant-smartptr-get] 119 | return _indexes->get(elementId)._value; // readability-redundant-smartptr-get | ^~~~~~~~~~~~~~~~~~~~~~~ | _indexes /home/runner/work/graphia/graphia/source/shared/loading/userelementdata.h:345:9: warning: variable 'jsonAttributes' of type 'json' (aka 'basic_json<>') can be declared 'const' [misc-const-correctness] 345 | json jsonAttributes = json::object(); // misc-const-correctness | ^ | const /home/runner/work/graphia/graphia/source/shared/utils/flags.h:33:5: warning: single-argument constructors must be marked explicit to avoid unintentional implicit conversions [google-explicit-constructor] 33 | Flags(Enum value) : | ^ | explicit /home/runner/work/graphia/graphia/source/shared/utils/flags.h:38:5: warning: constructors that are callable with a single argument must be marked explicit to avoid unintentional implicit conversions [google-explicit-constructor] 38 | Flags(Enum value, Tail... values) | ^ | explicit /home/runner/work/graphia/graphia/source/shared/utils/is_detected.h:24:1: warning: nested namespaces can be concatenated [modernize-concat-nested-namespaces] 24 | namespace std{ | ^~~~~~~~~~~~~~ 25 | namespace experimental{ | ~~~~~~~~~~~~~~~~~~~~~~ | namespace std::experimental /home/runner/work/graphia/graphia/source/shared/utils/is_detected.h:25:11: warning: modification of 'std' namespace can result in undefined behavior [cert-dcl58-cpp] 25 | namespace experimental{ | ^ /home/runner/work/graphia/graphia/source/shared/utils/is_detected.h:24:11: note: 'std' namespace opened here 24 | namespace std{ | ^ /home/runner/work/graphia/graphia/source/shared/utils/passkey.h:28:5: warning: use '= default' to define a trivial default constructor [modernize-use-equals-default] 28 | PassKey() {} | ^ ~~ | = default; /home/runner/work/graphia/graphia/source/shared/utils/passkey.h:29:5: warning: use '= default' to define a trivial copy constructor [modernize-use-equals-default] 29 | PassKey(PassKey const&) {} | ^ ~~ | = default; /home/runner/work/graphia/graphia/source/shared/utils/threadpool.h:66:109: warning: forwarding reference parameter 'args' is never forwarded inside the function body [cppcoreguidelines-missing-std-forward] 66 | template std::future> makeFuture(Fn f, Args&&... args) | ^ 23350 warnings generated. [160/195] /home/runner/work/graphia/graphia/source/app/attributes/conditionfncreator.h:51:9: warning: single-argument constructors must be marked explicit to avoid unintentional implicit conversions [google-explicit-constructor] 51 | TerminalValueWrapper(GraphTransformConfig::TerminalValue terminalValue) : | ^ | explicit /home/runner/work/graphia/graphia/source/shared/graph/elementid.h:35:5: warning: single-argument constructors must be marked explicit to avoid unintentional implicit conversions [google-explicit-constructor] 35 | ElementId(int value = NullValue) : | ^ | explicit /home/runner/work/graphia/graphia/source/shared/graph/grapharray.h:92:9: warning: initializer for member '_mutex' is redundant [readability-redundant-member-init] 92 | _mutex(), | ^~~~~~~~ /home/runner/work/graphia/graphia/source/shared/loading/userelementdata.h:114:16: warning: redundant get() call on smart pointer [readability-redundant-smartptr-get] 114 | return _indexes->get(elementId)._set; // readability-redundant-smartptr-get | ^~~~~~~~~~~~~~~~~~~~~~~ | _indexes /home/runner/work/graphia/graphia/source/shared/loading/userelementdata.h:119:16: warning: redundant get() call on smart pointer [readability-redundant-smartptr-get] 119 | return _indexes->get(elementId)._value; // readability-redundant-smartptr-get | ^~~~~~~~~~~~~~~~~~~~~~~ | _indexes /home/runner/work/graphia/graphia/source/shared/loading/userelementdata.h:345:9: warning: variable 'jsonAttributes' of type 'json' (aka 'basic_json<>') can be declared 'const' [misc-const-correctness] 345 | json jsonAttributes = json::object(); // misc-const-correctness | ^ | const /home/runner/work/graphia/graphia/source/shared/utils/flags.h:33:5: warning: single-argument constructors must be marked explicit to avoid unintentional implicit conversions [google-explicit-constructor] 33 | Flags(Enum value) : | ^ | explicit /home/runner/work/graphia/graphia/source/shared/utils/flags.h:38:5: warning: constructors that are callable with a single argument must be marked explicit to avoid unintentional implicit conversions [google-explicit-constructor] 38 | Flags(Enum value, Tail... values) | ^ | explicit /home/runner/work/graphia/graphia/source/shared/utils/passkey.h:28:5: warning: use '= default' to define a trivial default constructor [modernize-use-equals-default] 28 | PassKey() {} | ^ ~~ | = default; /home/runner/work/graphia/graphia/source/shared/utils/passkey.h:29:5: warning: use '= default' to define a trivial copy constructor [modernize-use-equals-default] 29 | PassKey(PassKey const&) {} | ^ ~~ | = default; 25230 warnings generated. [161/195] /home/runner/work/graphia/graphia/source/shared/graph/elementid.h:35:5: warning: single-argument constructors must be marked explicit to avoid unintentional implicit conversions [google-explicit-constructor] 35 | ElementId(int value = NullValue) : | ^ | explicit /home/runner/work/graphia/graphia/source/shared/graph/grapharray.h:92:9: warning: initializer for member '_mutex' is redundant [readability-redundant-member-init] 92 | _mutex(), | ^~~~~~~~ /home/runner/work/graphia/graphia/source/shared/utils/flags.h:33:5: warning: single-argument constructors must be marked explicit to avoid unintentional implicit conversions [google-explicit-constructor] 33 | Flags(Enum value) : | ^ | explicit /home/runner/work/graphia/graphia/source/shared/utils/flags.h:38:5: warning: constructors that are callable with a single argument must be marked explicit to avoid unintentional implicit conversions [google-explicit-constructor] 38 | Flags(Enum value, Tail... values) | ^ | explicit /home/runner/work/graphia/graphia/source/shared/utils/passkey.h:28:5: warning: use '= default' to define a trivial default constructor [modernize-use-equals-default] 28 | PassKey() {} | ^ ~~ | = default; /home/runner/work/graphia/graphia/source/shared/utils/passkey.h:29:5: warning: use '= default' to define a trivial copy constructor [modernize-use-equals-default] 29 | PassKey(PassKey const&) {} | ^ ~~ | = default; 20048 warnings generated. [162/195] /home/runner/work/graphia/graphia/source/shared/graph/elementid.h:35:5: warning: single-argument constructors must be marked explicit to avoid unintentional implicit conversions [google-explicit-constructor] 35 | ElementId(int value = NullValue) : | ^ | explicit /home/runner/work/graphia/graphia/source/shared/graph/grapharray.h:92:9: warning: initializer for member '_mutex' is redundant [readability-redundant-member-init] 92 | _mutex(), | ^~~~~~~~ /home/runner/work/graphia/graphia/source/shared/loading/userelementdata.h:114:16: warning: redundant get() call on smart pointer [readability-redundant-smartptr-get] 114 | return _indexes->get(elementId)._set; // readability-redundant-smartptr-get | ^~~~~~~~~~~~~~~~~~~~~~~ | _indexes /home/runner/work/graphia/graphia/source/shared/loading/userelementdata.h:119:16: warning: redundant get() call on smart pointer [readability-redundant-smartptr-get] 119 | return _indexes->get(elementId)._value; // readability-redundant-smartptr-get | ^~~~~~~~~~~~~~~~~~~~~~~ | _indexes /home/runner/work/graphia/graphia/source/shared/loading/userelementdata.h:345:9: warning: variable 'jsonAttributes' of type 'json' (aka 'basic_json<>') can be declared 'const' [misc-const-correctness] 345 | json jsonAttributes = json::object(); // misc-const-correctness | ^ | const /home/runner/work/graphia/graphia/source/shared/utils/flags.h:33:5: warning: single-argument constructors must be marked explicit to avoid unintentional implicit conversions [google-explicit-constructor] 33 | Flags(Enum value) : | ^ | explicit /home/runner/work/graphia/graphia/source/shared/utils/flags.h:38:5: warning: constructors that are callable with a single argument must be marked explicit to avoid unintentional implicit conversions [google-explicit-constructor] 38 | Flags(Enum value, Tail... values) | ^ | explicit /home/runner/work/graphia/graphia/source/shared/utils/passkey.h:28:5: warning: use '= default' to define a trivial default constructor [modernize-use-equals-default] 28 | PassKey() {} | ^ ~~ | = default; /home/runner/work/graphia/graphia/source/shared/utils/passkey.h:29:5: warning: use '= default' to define a trivial copy constructor [modernize-use-equals-default] 29 | PassKey(PassKey const&) {} | ^ ~~ | = default; 22763 warnings generated. [163/195] /home/runner/work/graphia/graphia/source/app/attributes/conditionfncreator.h:51:9: warning: single-argument constructors must be marked explicit to avoid unintentional implicit conversions [google-explicit-constructor] 51 | TerminalValueWrapper(GraphTransformConfig::TerminalValue terminalValue) : | ^ | explicit /home/runner/work/graphia/graphia/source/shared/graph/elementid.h:35:5: warning: single-argument constructors must be marked explicit to avoid unintentional implicit conversions [google-explicit-constructor] 35 | ElementId(int value = NullValue) : | ^ | explicit /home/runner/work/graphia/graphia/source/shared/graph/grapharray.h:92:9: warning: initializer for member '_mutex' is redundant [readability-redundant-member-init] 92 | _mutex(), | ^~~~~~~~ /home/runner/work/graphia/graphia/source/shared/loading/userelementdata.h:114:16: warning: redundant get() call on smart pointer [readability-redundant-smartptr-get] 114 | return _indexes->get(elementId)._set; // readability-redundant-smartptr-get | ^~~~~~~~~~~~~~~~~~~~~~~ | _indexes /home/runner/work/graphia/graphia/source/shared/loading/userelementdata.h:119:16: warning: redundant get() call on smart pointer [readability-redundant-smartptr-get] 119 | return _indexes->get(elementId)._value; // readability-redundant-smartptr-get | ^~~~~~~~~~~~~~~~~~~~~~~ | _indexes /home/runner/work/graphia/graphia/source/shared/loading/userelementdata.h:345:9: warning: variable 'jsonAttributes' of type 'json' (aka 'basic_json<>') can be declared 'const' [misc-const-correctness] 345 | json jsonAttributes = json::object(); // misc-const-correctness | ^ | const /home/runner/work/graphia/graphia/source/shared/utils/flags.h:33:5: warning: single-argument constructors must be marked explicit to avoid unintentional implicit conversions [google-explicit-constructor] 33 | Flags(Enum value) : | ^ | explicit /home/runner/work/graphia/graphia/source/shared/utils/flags.h:38:5: warning: constructors that are callable with a single argument must be marked explicit to avoid unintentional implicit conversions [google-explicit-constructor] 38 | Flags(Enum value, Tail... values) | ^ | explicit /home/runner/work/graphia/graphia/source/shared/utils/passkey.h:28:5: warning: use '= default' to define a trivial default constructor [modernize-use-equals-default] 28 | PassKey() {} | ^ ~~ | = default; /home/runner/work/graphia/graphia/source/shared/utils/passkey.h:29:5: warning: use '= default' to define a trivial copy constructor [modernize-use-equals-default] 29 | PassKey(PassKey const&) {} | ^ ~~ | = default; 25229 warnings generated. [164/195] /home/runner/work/graphia/graphia/source/shared/graph/elementid.h:35:5: warning: single-argument constructors must be marked explicit to avoid unintentional implicit conversions [google-explicit-constructor] 35 | ElementId(int value = NullValue) : | ^ | explicit /home/runner/work/graphia/graphia/source/shared/graph/grapharray.h:92:9: warning: initializer for member '_mutex' is redundant [readability-redundant-member-init] 92 | _mutex(), | ^~~~~~~~ /home/runner/work/graphia/graphia/source/shared/loading/userelementdata.h:114:16: warning: redundant get() call on smart pointer [readability-redundant-smartptr-get] 114 | return _indexes->get(elementId)._set; // readability-redundant-smartptr-get | ^~~~~~~~~~~~~~~~~~~~~~~ | _indexes /home/runner/work/graphia/graphia/source/shared/loading/userelementdata.h:119:16: warning: redundant get() call on smart pointer [readability-redundant-smartptr-get] 119 | return _indexes->get(elementId)._value; // readability-redundant-smartptr-get | ^~~~~~~~~~~~~~~~~~~~~~~ | _indexes /home/runner/work/graphia/graphia/source/shared/loading/userelementdata.h:345:9: warning: variable 'jsonAttributes' of type 'json' (aka 'basic_json<>') can be declared 'const' [misc-const-correctness] 345 | json jsonAttributes = json::object(); // misc-const-correctness | ^ | const /home/runner/work/graphia/graphia/source/shared/utils/flags.h:33:5: warning: single-argument constructors must be marked explicit to avoid unintentional implicit conversions [google-explicit-constructor] 33 | Flags(Enum value) : | ^ | explicit /home/runner/work/graphia/graphia/source/shared/utils/flags.h:38:5: warning: constructors that are callable with a single argument must be marked explicit to avoid unintentional implicit conversions [google-explicit-constructor] 38 | Flags(Enum value, Tail... values) | ^ | explicit /home/runner/work/graphia/graphia/source/shared/utils/passkey.h:28:5: warning: use '= default' to define a trivial default constructor [modernize-use-equals-default] 28 | PassKey() {} | ^ ~~ | = default; /home/runner/work/graphia/graphia/source/shared/utils/passkey.h:29:5: warning: use '= default' to define a trivial copy constructor [modernize-use-equals-default] 29 | PassKey(PassKey const&) {} | ^ ~~ | = default; 22647 warnings generated. [165/195] /home/runner/work/graphia/graphia/source/shared/graph/elementid.h:35:5: warning: single-argument constructors must be marked explicit to avoid unintentional implicit conversions [google-explicit-constructor] 35 | ElementId(int value = NullValue) : | ^ | explicit /home/runner/work/graphia/graphia/source/shared/graph/grapharray.h:92:9: warning: initializer for member '_mutex' is redundant [readability-redundant-member-init] 92 | _mutex(), | ^~~~~~~~ /home/runner/work/graphia/graphia/source/shared/loading/userelementdata.h:114:16: warning: redundant get() call on smart pointer [readability-redundant-smartptr-get] 114 | return _indexes->get(elementId)._set; // readability-redundant-smartptr-get | ^~~~~~~~~~~~~~~~~~~~~~~ | _indexes /home/runner/work/graphia/graphia/source/shared/loading/userelementdata.h:119:16: warning: redundant get() call on smart pointer [readability-redundant-smartptr-get] 119 | return _indexes->get(elementId)._value; // readability-redundant-smartptr-get | ^~~~~~~~~~~~~~~~~~~~~~~ | _indexes /home/runner/work/graphia/graphia/source/shared/loading/userelementdata.h:345:9: warning: variable 'jsonAttributes' of type 'json' (aka 'basic_json<>') can be declared 'const' [misc-const-correctness] 345 | json jsonAttributes = json::object(); // misc-const-correctness | ^ | const /home/runner/work/graphia/graphia/source/shared/utils/flags.h:33:5: warning: single-argument constructors must be marked explicit to avoid unintentional implicit conversions [google-explicit-constructor] 33 | Flags(Enum value) : | ^ | explicit /home/runner/work/graphia/graphia/source/shared/utils/flags.h:38:5: warning: constructors that are callable with a single argument must be marked explicit to avoid unintentional implicit conversions [google-explicit-constructor] 38 | Flags(Enum value, Tail... values) | ^ | explicit /home/runner/work/graphia/graphia/source/shared/utils/passkey.h:28:5: warning: use '= default' to define a trivial default constructor [modernize-use-equals-default] 28 | PassKey() {} | ^ ~~ | = default; /home/runner/work/graphia/graphia/source/shared/utils/passkey.h:29:5: warning: use '= default' to define a trivial copy constructor [modernize-use-equals-default] 29 | PassKey(PassKey const&) {} | ^ ~~ | = default; 22831 warnings generated. [166/195] /home/runner/work/graphia/graphia/source/shared/graph/elementid.h:35:5: warning: single-argument constructors must be marked explicit to avoid unintentional implicit conversions [google-explicit-constructor] 35 | ElementId(int value = NullValue) : | ^ | explicit /home/runner/work/graphia/graphia/source/shared/graph/grapharray.h:92:9: warning: initializer for member '_mutex' is redundant [readability-redundant-member-init] 92 | _mutex(), | ^~~~~~~~ /home/runner/work/graphia/graphia/source/shared/loading/userelementdata.h:114:16: warning: redundant get() call on smart pointer [readability-redundant-smartptr-get] 114 | return _indexes->get(elementId)._set; // readability-redundant-smartptr-get | ^~~~~~~~~~~~~~~~~~~~~~~ | _indexes /home/runner/work/graphia/graphia/source/shared/loading/userelementdata.h:119:16: warning: redundant get() call on smart pointer [readability-redundant-smartptr-get] 119 | return _indexes->get(elementId)._value; // readability-redundant-smartptr-get | ^~~~~~~~~~~~~~~~~~~~~~~ | _indexes /home/runner/work/graphia/graphia/source/shared/loading/userelementdata.h:345:9: warning: variable 'jsonAttributes' of type 'json' (aka 'basic_json<>') can be declared 'const' [misc-const-correctness] 345 | json jsonAttributes = json::object(); // misc-const-correctness | ^ | const /home/runner/work/graphia/graphia/source/shared/utils/flags.h:33:5: warning: single-argument constructors must be marked explicit to avoid unintentional implicit conversions [google-explicit-constructor] 33 | Flags(Enum value) : | ^ | explicit /home/runner/work/graphia/graphia/source/shared/utils/flags.h:38:5: warning: constructors that are callable with a single argument must be marked explicit to avoid unintentional implicit conversions [google-explicit-constructor] 38 | Flags(Enum value, Tail... values) | ^ | explicit /home/runner/work/graphia/graphia/source/shared/utils/passkey.h:28:5: warning: use '= default' to define a trivial default constructor [modernize-use-equals-default] 28 | PassKey() {} | ^ ~~ | = default; /home/runner/work/graphia/graphia/source/shared/utils/passkey.h:29:5: warning: use '= default' to define a trivial copy constructor [modernize-use-equals-default] 29 | PassKey(PassKey const&) {} | ^ ~~ | = default; 22647 warnings generated. [167/195] /home/runner/work/graphia/graphia/source/app/attributes/conditionfncreator.h:51:9: warning: single-argument constructors must be marked explicit to avoid unintentional implicit conversions [google-explicit-constructor] 51 | TerminalValueWrapper(GraphTransformConfig::TerminalValue terminalValue) : | ^ | explicit /home/runner/work/graphia/graphia/source/shared/graph/elementid.h:35:5: warning: single-argument constructors must be marked explicit to avoid unintentional implicit conversions [google-explicit-constructor] 35 | ElementId(int value = NullValue) : | ^ | explicit /home/runner/work/graphia/graphia/source/shared/graph/grapharray.h:92:9: warning: initializer for member '_mutex' is redundant [readability-redundant-member-init] 92 | _mutex(), | ^~~~~~~~ /home/runner/work/graphia/graphia/source/shared/loading/userelementdata.h:114:16: warning: redundant get() call on smart pointer [readability-redundant-smartptr-get] 114 | return _indexes->get(elementId)._set; // readability-redundant-smartptr-get | ^~~~~~~~~~~~~~~~~~~~~~~ | _indexes /home/runner/work/graphia/graphia/source/shared/loading/userelementdata.h:119:16: warning: redundant get() call on smart pointer [readability-redundant-smartptr-get] 119 | return _indexes->get(elementId)._value; // readability-redundant-smartptr-get | ^~~~~~~~~~~~~~~~~~~~~~~ | _indexes /home/runner/work/graphia/graphia/source/shared/loading/userelementdata.h:345:9: warning: variable 'jsonAttributes' of type 'json' (aka 'basic_json<>') can be declared 'const' [misc-const-correctness] 345 | json jsonAttributes = json::object(); // misc-const-correctness | ^ | const /home/runner/work/graphia/graphia/source/shared/utils/flags.h:33:5: warning: single-argument constructors must be marked explicit to avoid unintentional implicit conversions [google-explicit-constructor] 33 | Flags(Enum value) : | ^ | explicit /home/runner/work/graphia/graphia/source/shared/utils/flags.h:38:5: warning: constructors that are callable with a single argument must be marked explicit to avoid unintentional implicit conversions [google-explicit-constructor] 38 | Flags(Enum value, Tail... values) | ^ | explicit /home/runner/work/graphia/graphia/source/shared/utils/passkey.h:28:5: warning: use '= default' to define a trivial default constructor [modernize-use-equals-default] 28 | PassKey() {} | ^ ~~ | = default; /home/runner/work/graphia/graphia/source/shared/utils/passkey.h:29:5: warning: use '= default' to define a trivial copy constructor [modernize-use-equals-default] 29 | PassKey(PassKey const&) {} | ^ ~~ | = default; 25324 warnings generated. [168/195] /home/runner/work/graphia/graphia/source/shared/graph/elementid.h:35:5: warning: single-argument constructors must be marked explicit to avoid unintentional implicit conversions [google-explicit-constructor] 35 | ElementId(int value = NullValue) : | ^ | explicit /home/runner/work/graphia/graphia/source/shared/graph/grapharray.h:92:9: warning: initializer for member '_mutex' is redundant [readability-redundant-member-init] 92 | _mutex(), | ^~~~~~~~ /home/runner/work/graphia/graphia/source/shared/loading/userelementdata.h:114:16: warning: redundant get() call on smart pointer [readability-redundant-smartptr-get] 114 | return _indexes->get(elementId)._set; // readability-redundant-smartptr-get | ^~~~~~~~~~~~~~~~~~~~~~~ | _indexes /home/runner/work/graphia/graphia/source/shared/loading/userelementdata.h:119:16: warning: redundant get() call on smart pointer [readability-redundant-smartptr-get] 119 | return _indexes->get(elementId)._value; // readability-redundant-smartptr-get | ^~~~~~~~~~~~~~~~~~~~~~~ | _indexes /home/runner/work/graphia/graphia/source/shared/loading/userelementdata.h:345:9: warning: variable 'jsonAttributes' of type 'json' (aka 'basic_json<>') can be declared 'const' [misc-const-correctness] 345 | json jsonAttributes = json::object(); // misc-const-correctness | ^ | const /home/runner/work/graphia/graphia/source/shared/utils/flags.h:33:5: warning: single-argument constructors must be marked explicit to avoid unintentional implicit conversions [google-explicit-constructor] 33 | Flags(Enum value) : | ^ | explicit /home/runner/work/graphia/graphia/source/shared/utils/flags.h:38:5: warning: constructors that are callable with a single argument must be marked explicit to avoid unintentional implicit conversions [google-explicit-constructor] 38 | Flags(Enum value, Tail... values) | ^ | explicit /home/runner/work/graphia/graphia/source/shared/utils/is_detected.h:24:1: warning: nested namespaces can be concatenated [modernize-concat-nested-namespaces] 24 | namespace std{ | ^~~~~~~~~~~~~~ 25 | namespace experimental{ | ~~~~~~~~~~~~~~~~~~~~~~ | namespace std::experimental /home/runner/work/graphia/graphia/source/shared/utils/is_detected.h:25:11: warning: modification of 'std' namespace can result in undefined behavior [cert-dcl58-cpp] 25 | namespace experimental{ | ^ /home/runner/work/graphia/graphia/source/shared/utils/is_detected.h:24:11: note: 'std' namespace opened here 24 | namespace std{ | ^ /home/runner/work/graphia/graphia/source/shared/utils/passkey.h:28:5: warning: use '= default' to define a trivial default constructor [modernize-use-equals-default] 28 | PassKey() {} | ^ ~~ | = default; /home/runner/work/graphia/graphia/source/shared/utils/passkey.h:29:5: warning: use '= default' to define a trivial copy constructor [modernize-use-equals-default] 29 | PassKey(PassKey const&) {} | ^ ~~ | = default; /home/runner/work/graphia/graphia/source/shared/utils/threadpool.h:66:109: warning: forwarding reference parameter 'args' is never forwarded inside the function body [cppcoreguidelines-missing-std-forward] 66 | template std::future> makeFuture(Fn f, Args&&... args) | ^ 31621 warnings generated. [169/195] /home/runner/work/graphia/graphia/source/shared/graph/elementid.h:35:5: warning: single-argument constructors must be marked explicit to avoid unintentional implicit conversions [google-explicit-constructor] 35 | ElementId(int value = NullValue) : | ^ | explicit /home/runner/work/graphia/graphia/source/shared/graph/grapharray.h:92:9: warning: initializer for member '_mutex' is redundant [readability-redundant-member-init] 92 | _mutex(), | ^~~~~~~~ /home/runner/work/graphia/graphia/source/shared/loading/userelementdata.h:114:16: warning: redundant get() call on smart pointer [readability-redundant-smartptr-get] 114 | return _indexes->get(elementId)._set; // readability-redundant-smartptr-get | ^~~~~~~~~~~~~~~~~~~~~~~ | _indexes /home/runner/work/graphia/graphia/source/shared/loading/userelementdata.h:119:16: warning: redundant get() call on smart pointer [readability-redundant-smartptr-get] 119 | return _indexes->get(elementId)._value; // readability-redundant-smartptr-get | ^~~~~~~~~~~~~~~~~~~~~~~ | _indexes /home/runner/work/graphia/graphia/source/shared/loading/userelementdata.h:345:9: warning: variable 'jsonAttributes' of type 'json' (aka 'basic_json<>') can be declared 'const' [misc-const-correctness] 345 | json jsonAttributes = json::object(); // misc-const-correctness | ^ | const /home/runner/work/graphia/graphia/source/shared/utils/flags.h:33:5: warning: single-argument constructors must be marked explicit to avoid unintentional implicit conversions [google-explicit-constructor] 33 | Flags(Enum value) : | ^ | explicit /home/runner/work/graphia/graphia/source/shared/utils/flags.h:38:5: warning: constructors that are callable with a single argument must be marked explicit to avoid unintentional implicit conversions [google-explicit-constructor] 38 | Flags(Enum value, Tail... values) | ^ | explicit /home/runner/work/graphia/graphia/source/shared/utils/passkey.h:28:5: warning: use '= default' to define a trivial default constructor [modernize-use-equals-default] 28 | PassKey() {} | ^ ~~ | = default; /home/runner/work/graphia/graphia/source/shared/utils/passkey.h:29:5: warning: use '= default' to define a trivial copy constructor [modernize-use-equals-default] 29 | PassKey(PassKey const&) {} | ^ ~~ | = default; 30780 warnings generated. [170/195] /home/runner/work/graphia/graphia/source/shared/graph/elementid.h:35:5: warning: single-argument constructors must be marked explicit to avoid unintentional implicit conversions [google-explicit-constructor] 35 | ElementId(int value = NullValue) : | ^ | explicit /home/runner/work/graphia/graphia/source/shared/graph/grapharray.h:92:9: warning: initializer for member '_mutex' is redundant [readability-redundant-member-init] 92 | _mutex(), | ^~~~~~~~ /home/runner/work/graphia/graphia/source/shared/utils/flags.h:33:5: warning: single-argument constructors must be marked explicit to avoid unintentional implicit conversions [google-explicit-constructor] 33 | Flags(Enum value) : | ^ | explicit /home/runner/work/graphia/graphia/source/shared/utils/flags.h:38:5: warning: constructors that are callable with a single argument must be marked explicit to avoid unintentional implicit conversions [google-explicit-constructor] 38 | Flags(Enum value, Tail... values) | ^ | explicit /home/runner/work/graphia/graphia/source/shared/utils/passkey.h:28:5: warning: use '= default' to define a trivial default constructor [modernize-use-equals-default] 28 | PassKey() {} | ^ ~~ | = default; /home/runner/work/graphia/graphia/source/shared/utils/passkey.h:29:5: warning: use '= default' to define a trivial copy constructor [modernize-use-equals-default] 29 | PassKey(PassKey const&) {} | ^ ~~ | = default; 20015 warnings generated. [171/195] /home/runner/work/graphia/graphia/source/shared/graph/elementid.h:35:5: warning: single-argument constructors must be marked explicit to avoid unintentional implicit conversions [google-explicit-constructor] 35 | ElementId(int value = NullValue) : | ^ | explicit /home/runner/work/graphia/graphia/source/shared/graph/grapharray.h:92:9: warning: initializer for member '_mutex' is redundant [readability-redundant-member-init] 92 | _mutex(), | ^~~~~~~~ /home/runner/work/graphia/graphia/source/shared/loading/userelementdata.h:114:16: warning: redundant get() call on smart pointer [readability-redundant-smartptr-get] 114 | return _indexes->get(elementId)._set; // readability-redundant-smartptr-get | ^~~~~~~~~~~~~~~~~~~~~~~ | _indexes /home/runner/work/graphia/graphia/source/shared/loading/userelementdata.h:119:16: warning: redundant get() call on smart pointer [readability-redundant-smartptr-get] 119 | return _indexes->get(elementId)._value; // readability-redundant-smartptr-get | ^~~~~~~~~~~~~~~~~~~~~~~ | _indexes /home/runner/work/graphia/graphia/source/shared/loading/userelementdata.h:345:9: warning: variable 'jsonAttributes' of type 'json' (aka 'basic_json<>') can be declared 'const' [misc-const-correctness] 345 | json jsonAttributes = json::object(); // misc-const-correctness | ^ | const /home/runner/work/graphia/graphia/source/shared/utils/flags.h:33:5: warning: single-argument constructors must be marked explicit to avoid unintentional implicit conversions [google-explicit-constructor] 33 | Flags(Enum value) : | ^ | explicit /home/runner/work/graphia/graphia/source/shared/utils/flags.h:38:5: warning: constructors that are callable with a single argument must be marked explicit to avoid unintentional implicit conversions [google-explicit-constructor] 38 | Flags(Enum value, Tail... values) | ^ | explicit 22421 warnings generated. [172/195] /home/runner/work/graphia/graphia/source/shared/graph/elementid.h:35:5: warning: single-argument constructors must be marked explicit to avoid unintentional implicit conversions [google-explicit-constructor] 35 | ElementId(int value = NullValue) : | ^ | explicit /home/runner/work/graphia/graphia/source/shared/graph/grapharray.h:92:9: warning: initializer for member '_mutex' is redundant [readability-redundant-member-init] 92 | _mutex(), | ^~~~~~~~ /home/runner/work/graphia/graphia/source/shared/utils/flags.h:33:5: warning: single-argument constructors must be marked explicit to avoid unintentional implicit conversions [google-explicit-constructor] 33 | Flags(Enum value) : | ^ | explicit /home/runner/work/graphia/graphia/source/shared/utils/flags.h:38:5: warning: constructors that are callable with a single argument must be marked explicit to avoid unintentional implicit conversions [google-explicit-constructor] 38 | Flags(Enum value, Tail... values) | ^ | explicit /home/runner/work/graphia/graphia/source/shared/utils/passkey.h:28:5: warning: use '= default' to define a trivial default constructor [modernize-use-equals-default] 28 | PassKey() {} | ^ ~~ | = default; /home/runner/work/graphia/graphia/source/shared/utils/passkey.h:29:5: warning: use '= default' to define a trivial copy constructor [modernize-use-equals-default] 29 | PassKey(PassKey const&) {} | ^ ~~ | = default; 19903 warnings generated. [173/195] /home/runner/work/graphia/graphia/source/app/attributes/conditionfncreator.h:51:9: warning: single-argument constructors must be marked explicit to avoid unintentional implicit conversions [google-explicit-constructor] 51 | TerminalValueWrapper(GraphTransformConfig::TerminalValue terminalValue) : | ^ | explicit /home/runner/work/graphia/graphia/source/shared/commands/command.h:46:5: warning: single-argument constructors must be marked explicit to avoid unintentional implicit conversions [google-explicit-constructor] 46 | CommandFn(Fn&& fn) : | ^ | explicit /home/runner/work/graphia/graphia/source/shared/commands/command.h:46:20: warning: forwarding reference parameter 'fn' is never forwarded inside the function body [cppcoreguidelines-missing-std-forward] 46 | CommandFn(Fn&& fn) : | ^ /home/runner/work/graphia/graphia/source/shared/commands/command.h:51:5: warning: single-argument constructors must be marked explicit to avoid unintentional implicit conversions [google-explicit-constructor] 51 | CommandFn(Fn&& fn) : | ^ | explicit /home/runner/work/graphia/graphia/source/shared/commands/command.h:51:20: warning: forwarding reference parameter 'fn' is never forwarded inside the function body [cppcoreguidelines-missing-std-forward] 51 | CommandFn(Fn&& fn) : | ^ /home/runner/work/graphia/graphia/source/shared/commands/command.h:85:9: warning: constructors that are callable with a single argument must be marked explicit to avoid unintentional implicit conversions [google-explicit-constructor] 85 | CommandDescription(const QString& description = {}, | ^ | explicit /home/runner/work/graphia/graphia/source/shared/graph/elementid.h:35:5: warning: single-argument constructors must be marked explicit to avoid unintentional implicit conversions [google-explicit-constructor] 35 | ElementId(int value = NullValue) : | ^ | explicit /home/runner/work/graphia/graphia/source/shared/graph/grapharray.h:92:9: warning: initializer for member '_mutex' is redundant [readability-redundant-member-init] 92 | _mutex(), | ^~~~~~~~ /home/runner/work/graphia/graphia/source/shared/loading/userelementdata.h:114:16: warning: redundant get() call on smart pointer [readability-redundant-smartptr-get] 114 | return _indexes->get(elementId)._set; // readability-redundant-smartptr-get | ^~~~~~~~~~~~~~~~~~~~~~~ | _indexes /home/runner/work/graphia/graphia/source/shared/loading/userelementdata.h:119:16: warning: redundant get() call on smart pointer [readability-redundant-smartptr-get] 119 | return _indexes->get(elementId)._value; // readability-redundant-smartptr-get | ^~~~~~~~~~~~~~~~~~~~~~~ | _indexes /home/runner/work/graphia/graphia/source/shared/loading/userelementdata.h:345:9: warning: variable 'jsonAttributes' of type 'json' (aka 'basic_json<>') can be declared 'const' [misc-const-correctness] 345 | json jsonAttributes = json::object(); // misc-const-correctness | ^ | const /home/runner/work/graphia/graphia/source/shared/plugins/iplugin.h:101:9: warning: function-like macro 'IPluginIID' used; consider a 'constexpr' template function [cppcoreguidelines-macro-usage] 101 | #define IPluginIID(NAME) "app.graphia.IPlugin:" #NAME "/" VERSION // cppcoreguidelines-macro-usage | ^ /home/runner/work/graphia/graphia/source/shared/utils/flags.h:33:5: warning: single-argument constructors must be marked explicit to avoid unintentional implicit conversions [google-explicit-constructor] 33 | Flags(Enum value) : | ^ | explicit /home/runner/work/graphia/graphia/source/shared/utils/flags.h:38:5: warning: constructors that are callable with a single argument must be marked explicit to avoid unintentional implicit conversions [google-explicit-constructor] 38 | Flags(Enum value, Tail... values) | ^ | explicit 30759 warnings generated. [174/195] /home/runner/work/graphia/graphia/source/app/rendering/graphcomponentscene.h:33:6: warning: redundant 'initialiseFromGraph' declaration [readability-redundant-declaration] 33 | void initialiseFromGraph(const Graph*, Target&); | ^ /home/runner/work/graphia/graphia/source/app/rendering/graphrenderer.h:91:6: note: previously declared here 91 | void initialiseFromGraph(const Graph*, Target&); | ^ /home/runner/work/graphia/graphia/source/shared/commands/command.h:46:5: warning: single-argument constructors must be marked explicit to avoid unintentional implicit conversions [google-explicit-constructor] 46 | CommandFn(Fn&& fn) : | ^ | explicit /home/runner/work/graphia/graphia/source/shared/commands/command.h:46:20: warning: forwarding reference parameter 'fn' is never forwarded inside the function body [cppcoreguidelines-missing-std-forward] 46 | CommandFn(Fn&& fn) : | ^ /home/runner/work/graphia/graphia/source/shared/commands/command.h:51:5: warning: single-argument constructors must be marked explicit to avoid unintentional implicit conversions [google-explicit-constructor] 51 | CommandFn(Fn&& fn) : | ^ | explicit /home/runner/work/graphia/graphia/source/shared/commands/command.h:51:20: warning: forwarding reference parameter 'fn' is never forwarded inside the function body [cppcoreguidelines-missing-std-forward] 51 | CommandFn(Fn&& fn) : | ^ /home/runner/work/graphia/graphia/source/shared/commands/command.h:85:9: warning: constructors that are callable with a single argument must be marked explicit to avoid unintentional implicit conversions [google-explicit-constructor] 85 | CommandDescription(const QString& description = {}, | ^ | explicit /home/runner/work/graphia/graphia/source/shared/graph/elementid.h:35:5: warning: single-argument constructors must be marked explicit to avoid unintentional implicit conversions [google-explicit-constructor] 35 | ElementId(int value = NullValue) : | ^ | explicit /home/runner/work/graphia/graphia/source/shared/graph/grapharray.h:92:9: warning: initializer for member '_mutex' is redundant [readability-redundant-member-init] 92 | _mutex(), | ^~~~~~~~ /home/runner/work/graphia/graphia/source/shared/loading/userelementdata.h:114:16: warning: redundant get() call on smart pointer [readability-redundant-smartptr-get] 114 | return _indexes->get(elementId)._set; // readability-redundant-smartptr-get | ^~~~~~~~~~~~~~~~~~~~~~~ | _indexes /home/runner/work/graphia/graphia/source/shared/loading/userelementdata.h:119:16: warning: redundant get() call on smart pointer [readability-redundant-smartptr-get] 119 | return _indexes->get(elementId)._value; // readability-redundant-smartptr-get | ^~~~~~~~~~~~~~~~~~~~~~~ | _indexes /home/runner/work/graphia/graphia/source/shared/loading/userelementdata.h:345:9: warning: variable 'jsonAttributes' of type 'json' (aka 'basic_json<>') can be declared 'const' [misc-const-correctness] 345 | json jsonAttributes = json::object(); // misc-const-correctness | ^ | const /home/runner/work/graphia/graphia/source/shared/utils/flags.h:33:5: warning: single-argument constructors must be marked explicit to avoid unintentional implicit conversions [google-explicit-constructor] 33 | Flags(Enum value) : | ^ | explicit /home/runner/work/graphia/graphia/source/shared/utils/flags.h:38:5: warning: constructors that are callable with a single argument must be marked explicit to avoid unintentional implicit conversions [google-explicit-constructor] 38 | Flags(Enum value, Tail... values) | ^ | explicit 31100 warnings generated. [175/195] /home/runner/work/graphia/graphia/source/app/rendering/graphrenderer.h:91:6: warning: redundant 'initialiseFromGraph' declaration [readability-redundant-declaration] 91 | void initialiseFromGraph(const Graph*, Target&); | ^ /home/runner/work/graphia/graphia/source/app/rendering/graphcomponentscene.h:33:6: note: previously declared here 33 | void initialiseFromGraph(const Graph*, Target&); | ^ /home/runner/work/graphia/graphia/source/shared/commands/command.h:46:5: warning: single-argument constructors must be marked explicit to avoid unintentional implicit conversions [google-explicit-constructor] 46 | CommandFn(Fn&& fn) : | ^ | explicit /home/runner/work/graphia/graphia/source/shared/commands/command.h:46:20: warning: forwarding reference parameter 'fn' is never forwarded inside the function body [cppcoreguidelines-missing-std-forward] 46 | CommandFn(Fn&& fn) : | ^ /home/runner/work/graphia/graphia/source/shared/commands/command.h:51:5: warning: single-argument constructors must be marked explicit to avoid unintentional implicit conversions [google-explicit-constructor] 51 | CommandFn(Fn&& fn) : | ^ | explicit /home/runner/work/graphia/graphia/source/shared/commands/command.h:51:20: warning: forwarding reference parameter 'fn' is never forwarded inside the function body [cppcoreguidelines-missing-std-forward] 51 | CommandFn(Fn&& fn) : | ^ /home/runner/work/graphia/graphia/source/shared/commands/command.h:85:9: warning: constructors that are callable with a single argument must be marked explicit to avoid unintentional implicit conversions [google-explicit-constructor] 85 | CommandDescription(const QString& description = {}, | ^ | explicit /home/runner/work/graphia/graphia/source/shared/graph/elementid.h:35:5: warning: single-argument constructors must be marked explicit to avoid unintentional implicit conversions [google-explicit-constructor] 35 | ElementId(int value = NullValue) : | ^ | explicit /home/runner/work/graphia/graphia/source/shared/graph/grapharray.h:92:9: warning: initializer for member '_mutex' is redundant [readability-redundant-member-init] 92 | _mutex(), | ^~~~~~~~ /home/runner/work/graphia/graphia/source/shared/loading/userelementdata.h:114:16: warning: redundant get() call on smart pointer [readability-redundant-smartptr-get] 114 | return _indexes->get(elementId)._set; // readability-redundant-smartptr-get | ^~~~~~~~~~~~~~~~~~~~~~~ | _indexes /home/runner/work/graphia/graphia/source/shared/loading/userelementdata.h:119:16: warning: redundant get() call on smart pointer [readability-redundant-smartptr-get] 119 | return _indexes->get(elementId)._value; // readability-redundant-smartptr-get | ^~~~~~~~~~~~~~~~~~~~~~~ | _indexes /home/runner/work/graphia/graphia/source/shared/loading/userelementdata.h:345:9: warning: variable 'jsonAttributes' of type 'json' (aka 'basic_json<>') can be declared 'const' [misc-const-correctness] 345 | json jsonAttributes = json::object(); // misc-const-correctness | ^ | const /home/runner/work/graphia/graphia/source/shared/utils/flags.h:33:5: warning: single-argument constructors must be marked explicit to avoid unintentional implicit conversions [google-explicit-constructor] 33 | Flags(Enum value) : | ^ | explicit /home/runner/work/graphia/graphia/source/shared/utils/flags.h:38:5: warning: constructors that are callable with a single argument must be marked explicit to avoid unintentional implicit conversions [google-explicit-constructor] 38 | Flags(Enum value, Tail... values) | ^ | explicit 30958 warnings generated. [176/195] /home/runner/work/graphia/graphia/source/app/rendering/graphoverviewscene.h:47:6: warning: redundant 'initialiseFromGraph' declaration [readability-redundant-declaration] 47 | void initialiseFromGraph(const Graph*, Target&); | ^ /home/runner/work/graphia/graphia/source/app/rendering/graphrenderer.h:91:6: note: previously declared here 91 | void initialiseFromGraph(const Graph*, Target&); | ^ /home/runner/work/graphia/graphia/source/shared/commands/command.h:46:5: warning: single-argument constructors must be marked explicit to avoid unintentional implicit conversions [google-explicit-constructor] 46 | CommandFn(Fn&& fn) : | ^ | explicit /home/runner/work/graphia/graphia/source/shared/commands/command.h:46:20: warning: forwarding reference parameter 'fn' is never forwarded inside the function body [cppcoreguidelines-missing-std-forward] 46 | CommandFn(Fn&& fn) : | ^ /home/runner/work/graphia/graphia/source/shared/commands/command.h:51:5: warning: single-argument constructors must be marked explicit to avoid unintentional implicit conversions [google-explicit-constructor] 51 | CommandFn(Fn&& fn) : | ^ | explicit /home/runner/work/graphia/graphia/source/shared/commands/command.h:51:20: warning: forwarding reference parameter 'fn' is never forwarded inside the function body [cppcoreguidelines-missing-std-forward] 51 | CommandFn(Fn&& fn) : | ^ /home/runner/work/graphia/graphia/source/shared/commands/command.h:85:9: warning: constructors that are callable with a single argument must be marked explicit to avoid unintentional implicit conversions [google-explicit-constructor] 85 | CommandDescription(const QString& description = {}, | ^ | explicit /home/runner/work/graphia/graphia/source/shared/graph/elementid.h:35:5: warning: single-argument constructors must be marked explicit to avoid unintentional implicit conversions [google-explicit-constructor] 35 | ElementId(int value = NullValue) : | ^ | explicit /home/runner/work/graphia/graphia/source/shared/graph/grapharray.h:92:9: warning: initializer for member '_mutex' is redundant [readability-redundant-member-init] 92 | _mutex(), | ^~~~~~~~ /home/runner/work/graphia/graphia/source/shared/loading/userelementdata.h:114:16: warning: redundant get() call on smart pointer [readability-redundant-smartptr-get] 114 | return _indexes->get(elementId)._set; // readability-redundant-smartptr-get | ^~~~~~~~~~~~~~~~~~~~~~~ | _indexes /home/runner/work/graphia/graphia/source/shared/loading/userelementdata.h:119:16: warning: redundant get() call on smart pointer [readability-redundant-smartptr-get] 119 | return _indexes->get(elementId)._value; // readability-redundant-smartptr-get | ^~~~~~~~~~~~~~~~~~~~~~~ | _indexes /home/runner/work/graphia/graphia/source/shared/loading/userelementdata.h:345:9: warning: variable 'jsonAttributes' of type 'json' (aka 'basic_json<>') can be declared 'const' [misc-const-correctness] 345 | json jsonAttributes = json::object(); // misc-const-correctness | ^ | const /home/runner/work/graphia/graphia/source/shared/utils/flags.h:33:5: warning: single-argument constructors must be marked explicit to avoid unintentional implicit conversions [google-explicit-constructor] 33 | Flags(Enum value) : | ^ | explicit /home/runner/work/graphia/graphia/source/shared/utils/flags.h:38:5: warning: constructors that are callable with a single argument must be marked explicit to avoid unintentional implicit conversions [google-explicit-constructor] 38 | Flags(Enum value, Tail... values) | ^ | explicit 30954 warnings generated. [177/195] /home/runner/work/graphia/graphia/source/shared/commands/command.h:46:5: warning: single-argument constructors must be marked explicit to avoid unintentional implicit conversions [google-explicit-constructor] 46 | CommandFn(Fn&& fn) : | ^ | explicit /home/runner/work/graphia/graphia/source/shared/commands/command.h:46:20: warning: forwarding reference parameter 'fn' is never forwarded inside the function body [cppcoreguidelines-missing-std-forward] 46 | CommandFn(Fn&& fn) : | ^ /home/runner/work/graphia/graphia/source/shared/commands/command.h:51:5: warning: single-argument constructors must be marked explicit to avoid unintentional implicit conversions [google-explicit-constructor] 51 | CommandFn(Fn&& fn) : | ^ | explicit /home/runner/work/graphia/graphia/source/shared/commands/command.h:51:20: warning: forwarding reference parameter 'fn' is never forwarded inside the function body [cppcoreguidelines-missing-std-forward] 51 | CommandFn(Fn&& fn) : | ^ /home/runner/work/graphia/graphia/source/shared/commands/command.h:85:9: warning: constructors that are callable with a single argument must be marked explicit to avoid unintentional implicit conversions [google-explicit-constructor] 85 | CommandDescription(const QString& description = {}, | ^ | explicit /home/runner/work/graphia/graphia/source/shared/graph/elementid.h:35:5: warning: single-argument constructors must be marked explicit to avoid unintentional implicit conversions [google-explicit-constructor] 35 | ElementId(int value = NullValue) : | ^ | explicit /home/runner/work/graphia/graphia/source/shared/graph/grapharray.h:92:9: warning: initializer for member '_mutex' is redundant [readability-redundant-member-init] 92 | _mutex(), | ^~~~~~~~ /home/runner/work/graphia/graphia/source/shared/loading/userelementdata.h:114:16: warning: redundant get() call on smart pointer [readability-redundant-smartptr-get] 114 | return _indexes->get(elementId)._set; // readability-redundant-smartptr-get | ^~~~~~~~~~~~~~~~~~~~~~~ | _indexes /home/runner/work/graphia/graphia/source/shared/loading/userelementdata.h:119:16: warning: redundant get() call on smart pointer [readability-redundant-smartptr-get] 119 | return _indexes->get(elementId)._value; // readability-redundant-smartptr-get | ^~~~~~~~~~~~~~~~~~~~~~~ | _indexes /home/runner/work/graphia/graphia/source/shared/loading/userelementdata.h:345:9: warning: variable 'jsonAttributes' of type 'json' (aka 'basic_json<>') can be declared 'const' [misc-const-correctness] 345 | json jsonAttributes = json::object(); // misc-const-correctness | ^ | const /home/runner/work/graphia/graphia/source/shared/utils/flags.h:33:5: warning: single-argument constructors must be marked explicit to avoid unintentional implicit conversions [google-explicit-constructor] 33 | Flags(Enum value) : | ^ | explicit /home/runner/work/graphia/graphia/source/shared/utils/flags.h:38:5: warning: constructors that are callable with a single argument must be marked explicit to avoid unintentional implicit conversions [google-explicit-constructor] 38 | Flags(Enum value, Tail... values) | ^ | explicit 31088 warnings generated. [178/195] /home/runner/work/graphia/graphia/source/app/attributes/conditionfncreator.h:51:9: warning: single-argument constructors must be marked explicit to avoid unintentional implicit conversions [google-explicit-constructor] 51 | TerminalValueWrapper(GraphTransformConfig::TerminalValue terminalValue) : | ^ | explicit /home/runner/work/graphia/graphia/source/shared/graph/elementid.h:35:5: warning: single-argument constructors must be marked explicit to avoid unintentional implicit conversions [google-explicit-constructor] 35 | ElementId(int value = NullValue) : | ^ | explicit /home/runner/work/graphia/graphia/source/shared/graph/grapharray.h:92:9: warning: initializer for member '_mutex' is redundant [readability-redundant-member-init] 92 | _mutex(), | ^~~~~~~~ /home/runner/work/graphia/graphia/source/shared/loading/userelementdata.h:114:16: warning: redundant get() call on smart pointer [readability-redundant-smartptr-get] 114 | return _indexes->get(elementId)._set; // readability-redundant-smartptr-get | ^~~~~~~~~~~~~~~~~~~~~~~ | _indexes /home/runner/work/graphia/graphia/source/shared/loading/userelementdata.h:119:16: warning: redundant get() call on smart pointer [readability-redundant-smartptr-get] 119 | return _indexes->get(elementId)._value; // readability-redundant-smartptr-get | ^~~~~~~~~~~~~~~~~~~~~~~ | _indexes /home/runner/work/graphia/graphia/source/shared/loading/userelementdata.h:345:9: warning: variable 'jsonAttributes' of type 'json' (aka 'basic_json<>') can be declared 'const' [misc-const-correctness] 345 | json jsonAttributes = json::object(); // misc-const-correctness | ^ | const /home/runner/work/graphia/graphia/source/shared/utils/flags.h:33:5: warning: single-argument constructors must be marked explicit to avoid unintentional implicit conversions [google-explicit-constructor] 33 | Flags(Enum value) : | ^ | explicit /home/runner/work/graphia/graphia/source/shared/utils/flags.h:38:5: warning: constructors that are callable with a single argument must be marked explicit to avoid unintentional implicit conversions [google-explicit-constructor] 38 | Flags(Enum value, Tail... values) | ^ | explicit 24885 warnings generated. [179/195] /home/runner/work/graphia/graphia/source/shared/graph/elementid.h:35:5: warning: single-argument constructors must be marked explicit to avoid unintentional implicit conversions [google-explicit-constructor] 35 | ElementId(int value = NullValue) : | ^ | explicit /home/runner/work/graphia/graphia/source/shared/graph/grapharray.h:92:9: warning: initializer for member '_mutex' is redundant [readability-redundant-member-init] 92 | _mutex(), | ^~~~~~~~ /home/runner/work/graphia/graphia/source/shared/loading/userelementdata.h:114:16: warning: redundant get() call on smart pointer [readability-redundant-smartptr-get] 114 | return _indexes->get(elementId)._set; // readability-redundant-smartptr-get | ^~~~~~~~~~~~~~~~~~~~~~~ | _indexes /home/runner/work/graphia/graphia/source/shared/loading/userelementdata.h:119:16: warning: redundant get() call on smart pointer [readability-redundant-smartptr-get] 119 | return _indexes->get(elementId)._value; // readability-redundant-smartptr-get | ^~~~~~~~~~~~~~~~~~~~~~~ | _indexes /home/runner/work/graphia/graphia/source/shared/loading/userelementdata.h:345:9: warning: variable 'jsonAttributes' of type 'json' (aka 'basic_json<>') can be declared 'const' [misc-const-correctness] 345 | json jsonAttributes = json::object(); // misc-const-correctness | ^ | const /home/runner/work/graphia/graphia/source/shared/utils/flags.h:33:5: warning: single-argument constructors must be marked explicit to avoid unintentional implicit conversions [google-explicit-constructor] 33 | Flags(Enum value) : | ^ | explicit /home/runner/work/graphia/graphia/source/shared/utils/flags.h:38:5: warning: constructors that are callable with a single argument must be marked explicit to avoid unintentional implicit conversions [google-explicit-constructor] 38 | Flags(Enum value, Tail... values) | ^ | explicit 19392 warnings generated. [180/195] 28952 warnings generated. [181/195] /home/runner/work/graphia/graphia/source/shared/graph/elementid.h:35:5: warning: single-argument constructors must be marked explicit to avoid unintentional implicit conversions [google-explicit-constructor] 35 | ElementId(int value = NullValue) : | ^ | explicit /home/runner/work/graphia/graphia/source/shared/utils/flags.h:33:5: warning: single-argument constructors must be marked explicit to avoid unintentional implicit conversions [google-explicit-constructor] 33 | Flags(Enum value) : | ^ | explicit /home/runner/work/graphia/graphia/source/shared/utils/flags.h:38:5: warning: constructors that are callable with a single argument must be marked explicit to avoid unintentional implicit conversions [google-explicit-constructor] 38 | Flags(Enum value, Tail... values) | ^ | explicit 10960 warnings generated. [182/195] /home/runner/work/graphia/graphia/source/shared/graph/elementid.h:35:5: warning: single-argument constructors must be marked explicit to avoid unintentional implicit conversions [google-explicit-constructor] 35 | ElementId(int value = NullValue) : | ^ | explicit /home/runner/work/graphia/graphia/source/shared/utils/flags.h:33:5: warning: single-argument constructors must be marked explicit to avoid unintentional implicit conversions [google-explicit-constructor] 33 | Flags(Enum value) : | ^ | explicit /home/runner/work/graphia/graphia/source/shared/utils/flags.h:38:5: warning: constructors that are callable with a single argument must be marked explicit to avoid unintentional implicit conversions [google-explicit-constructor] 38 | Flags(Enum value, Tail... values) | ^ | explicit 10846 warnings generated. [183/195] /home/runner/work/graphia/graphia/source/app/attributes/conditionfncreator.h:51:9: warning: single-argument constructors must be marked explicit to avoid unintentional implicit conversions [google-explicit-constructor] 51 | TerminalValueWrapper(GraphTransformConfig::TerminalValue terminalValue) : | ^ | explicit /home/runner/work/graphia/graphia/source/shared/graph/elementid.h:35:5: warning: single-argument constructors must be marked explicit to avoid unintentional implicit conversions [google-explicit-constructor] 35 | ElementId(int value = NullValue) : | ^ | explicit /home/runner/work/graphia/graphia/source/shared/graph/grapharray.h:92:9: warning: initializer for member '_mutex' is redundant [readability-redundant-member-init] 92 | _mutex(), | ^~~~~~~~ /home/runner/work/graphia/graphia/source/shared/loading/userelementdata.h:114:16: warning: redundant get() call on smart pointer [readability-redundant-smartptr-get] 114 | return _indexes->get(elementId)._set; // readability-redundant-smartptr-get | ^~~~~~~~~~~~~~~~~~~~~~~ | _indexes /home/runner/work/graphia/graphia/source/shared/loading/userelementdata.h:119:16: warning: redundant get() call on smart pointer [readability-redundant-smartptr-get] 119 | return _indexes->get(elementId)._value; // readability-redundant-smartptr-get | ^~~~~~~~~~~~~~~~~~~~~~~ | _indexes /home/runner/work/graphia/graphia/source/shared/loading/userelementdata.h:345:9: warning: variable 'jsonAttributes' of type 'json' (aka 'basic_json<>') can be declared 'const' [misc-const-correctness] 345 | json jsonAttributes = json::object(); // misc-const-correctness | ^ | const /home/runner/work/graphia/graphia/source/shared/utils/flags.h:33:5: warning: single-argument constructors must be marked explicit to avoid unintentional implicit conversions [google-explicit-constructor] 33 | Flags(Enum value) : | ^ | explicit /home/runner/work/graphia/graphia/source/shared/utils/flags.h:38:5: warning: constructors that are callable with a single argument must be marked explicit to avoid unintentional implicit conversions [google-explicit-constructor] 38 | Flags(Enum value, Tail... values) | ^ | explicit /home/runner/work/graphia/graphia/source/shared/utils/passkey.h:28:5: warning: use '= default' to define a trivial default constructor [modernize-use-equals-default] 28 | PassKey() {} | ^ ~~ | = default; /home/runner/work/graphia/graphia/source/shared/utils/passkey.h:29:5: warning: use '= default' to define a trivial copy constructor [modernize-use-equals-default] 29 | PassKey(PassKey const&) {} | ^ ~~ | = default; 25361 warnings generated. [184/195] /home/runner/work/graphia/graphia/source/shared/graph/elementid.h:35:5: warning: single-argument constructors must be marked explicit to avoid unintentional implicit conversions [google-explicit-constructor] 35 | ElementId(int value = NullValue) : | ^ | explicit /home/runner/work/graphia/graphia/source/shared/graph/grapharray.h:92:9: warning: initializer for member '_mutex' is redundant [readability-redundant-member-init] 92 | _mutex(), | ^~~~~~~~ 8003 warnings generated. [185/195] /home/runner/work/graphia/graphia/source/shared/graph/elementid.h:35:5: warning: single-argument constructors must be marked explicit to avoid unintentional implicit conversions [google-explicit-constructor] 35 | ElementId(int value = NullValue) : | ^ | explicit /home/runner/work/graphia/graphia/source/shared/graph/grapharray.h:92:9: warning: initializer for member '_mutex' is redundant [readability-redundant-member-init] 92 | _mutex(), | ^~~~~~~~ /home/runner/work/graphia/graphia/source/shared/utils/flags.h:33:5: warning: single-argument constructors must be marked explicit to avoid unintentional implicit conversions [google-explicit-constructor] 33 | Flags(Enum value) : | ^ | explicit /home/runner/work/graphia/graphia/source/shared/utils/flags.h:38:5: warning: constructors that are callable with a single argument must be marked explicit to avoid unintentional implicit conversions [google-explicit-constructor] 38 | Flags(Enum value, Tail... values) | ^ | explicit 22055 warnings generated. [186/195] /home/runner/work/graphia/graphia/source/shared/graph/elementid.h:35:5: warning: single-argument constructors must be marked explicit to avoid unintentional implicit conversions [google-explicit-constructor] 35 | ElementId(int value = NullValue) : | ^ | explicit /home/runner/work/graphia/graphia/source/shared/utils/flags.h:33:5: warning: single-argument constructors must be marked explicit to avoid unintentional implicit conversions [google-explicit-constructor] 33 | Flags(Enum value) : | ^ | explicit /home/runner/work/graphia/graphia/source/shared/utils/flags.h:38:5: warning: constructors that are callable with a single argument must be marked explicit to avoid unintentional implicit conversions [google-explicit-constructor] 38 | Flags(Enum value, Tail... values) | ^ | explicit 10863 warnings generated. [187/195] /home/runner/work/graphia/graphia/source/shared/graph/elementid.h:35:5: warning: single-argument constructors must be marked explicit to avoid unintentional implicit conversions [google-explicit-constructor] 35 | ElementId(int value = NullValue) : | ^ | explicit /home/runner/work/graphia/graphia/source/shared/utils/flags.h:33:5: warning: single-argument constructors must be marked explicit to avoid unintentional implicit conversions [google-explicit-constructor] 33 | Flags(Enum value) : | ^ | explicit /home/runner/work/graphia/graphia/source/shared/utils/flags.h:38:5: warning: constructors that are callable with a single argument must be marked explicit to avoid unintentional implicit conversions [google-explicit-constructor] 38 | Flags(Enum value, Tail... values) | ^ | explicit 10846 warnings generated. [188/195] /home/runner/work/graphia/graphia/source/shared/graph/elementid.h:35:5: warning: single-argument constructors must be marked explicit to avoid unintentional implicit conversions [google-explicit-constructor] 35 | ElementId(int value = NullValue) : | ^ | explicit /home/runner/work/graphia/graphia/source/shared/utils/flags.h:33:5: warning: single-argument constructors must be marked explicit to avoid unintentional implicit conversions [google-explicit-constructor] 33 | Flags(Enum value) : | ^ | explicit /home/runner/work/graphia/graphia/source/shared/utils/flags.h:38:5: warning: constructors that are callable with a single argument must be marked explicit to avoid unintentional implicit conversions [google-explicit-constructor] 38 | Flags(Enum value, Tail... values) | ^ | explicit 10899 warnings generated. [189/195] 9973 warnings generated. [190/195] 24382 warnings generated. [191/195] 16602 warnings generated. [192/195] 28656 warnings generated. [193/195] 18389 warnings generated. [194/195] /home/runner/work/graphia/graphia/source/shared/utils/doasyncthen.h:42:28: warning: forwarding reference parameter 'thenFn' is never forwarded inside the function body [cppcoreguidelines-missing-std-forward] 42 | void then(ThenFn&& thenFn) | ^ 20245 warnings generated. [195/195] 12997 warnings generated.